From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E6168C433E2 for ; Mon, 31 Aug 2020 01:24:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CB9B4207DA for ; Mon, 31 Aug 2020 01:24:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726804AbgHaBYi (ORCPT ); Sun, 30 Aug 2020 21:24:38 -0400 Received: from szxga05-in.huawei.com ([45.249.212.191]:10733 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726525AbgHaBYh (ORCPT ); Sun, 30 Aug 2020 21:24:37 -0400 Received: from DGGEMS409-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id 9BB0270C4E370445B9FE; Mon, 31 Aug 2020 09:24:34 +0800 (CST) Received: from [10.136.114.67] (10.136.114.67) by smtp.huawei.com (10.3.19.209) with Microsoft SMTP Server (TLS) id 14.3.487.0; Mon, 31 Aug 2020 09:24:28 +0800 Subject: Re: [f2fs-dev] [PATCH] f2fs: prevent compressed file from being disabled after releasing cblocks To: Daeho Jeong , Chao Yu CC: Daeho Jeong , , , References: <20200828054629.583577-1-daeho43@gmail.com> <61996dcd-6db1-13fc-8239-7e684f3ec49e@kernel.org> From: Chao Yu Message-ID: Date: Mon, 31 Aug 2020 09:24:28 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Originating-IP: [10.136.114.67] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020/8/31 7:42, Daeho Jeong wrote: > Do you have any reason not to put this check here? No, the place is okay to me. :) > If we do this check outside of here, we definitely make a mistake > sooner or later. I just want to see whether we can cover all cases in where we missed to add immutable check condition if necessary. Thanks, > > 2020년 8월 30일 (일) 오후 12:24, Chao Yu 님이 작성: >> >> On 2020-8-28 13:46, Daeho Jeong wrote: >>> From: Daeho Jeong >>> >>> After releasing cblocks, the compressed file can be accidentally >>> disabled in compression mode, since it has zero cblocks. As we are >>> using IMMUTABLE flag to present released cblocks state, we can add >>> IMMUTABLE state check when considering the compressed file disabling. >>> >>> Signed-off-by: Daeho Jeong >>> --- >>> fs/f2fs/f2fs.h | 2 ++ >>> 1 file changed, 2 insertions(+) >>> >>> diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h >>> index 02811ce15059..14d30740ba03 100644 >>> --- a/fs/f2fs/f2fs.h >>> +++ b/fs/f2fs/f2fs.h >>> @@ -3936,6 +3936,8 @@ static inline u64 f2fs_disable_compressed_file(struct inode *inode) >>> if (!f2fs_compressed_file(inode)) >>> return 0; >>> if (S_ISREG(inode->i_mode)) { >>> + if (IS_IMMUTABLE(inode)) >>> + return 1; >> >> It looks most of callers are from ioctl, should we add immutable check in f2fs >> ioctl interfaces if necessary? or I missed existed check. >> >> Thanks, >> >>> if (get_dirty_pages(inode)) >>> return 1; >>> if (fi->i_compr_blocks) >>> > > > _______________________________________________ > Linux-f2fs-devel mailing list > Linux-f2fs-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel >