From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0CD0AC004D4 for ; Thu, 19 Jan 2023 18:54:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229674AbjASSyL (ORCPT ); Thu, 19 Jan 2023 13:54:11 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37902 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229811AbjASSyD (ORCPT ); Thu, 19 Jan 2023 13:54:03 -0500 Received: from mail-il1-x12c.google.com (mail-il1-x12c.google.com [IPv6:2607:f8b0:4864:20::12c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 128C637B52 for ; Thu, 19 Jan 2023 10:54:03 -0800 (PST) Received: by mail-il1-x12c.google.com with SMTP id i1so1631086ilu.8 for ; Thu, 19 Jan 2023 10:54:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=sa8Oz+7EARYAtQ0WLnCqgtp/WsCMus/3I6/+CNJ1OPw=; b=sPzq1KJuKnyasXRpxYhl2vyV/bYi9yVZ56Vqego/VjuHdzz/5dWCi47UX2CUDpoDNC CcC5wYt/hUVVEpFkHtyZ89U3S4NTWky0LrDtrtiFDdFrjZELyHOpVBHxbNELtKnQ2iw4 nr1fs0E0gGKpdnwRST07vzvNPYUzWsF4Vi012BPK68GyqhQejq7mymG62LbNctNk1H5z ANiECjUYn3uY98+hJ+kIU7gfPJH2vu/HOgNnNuH23TbDVW4pbv+weD5qebAzq+j5ja3T n2GpBO55V9L6Il8+jeulDNzuo2GKi68Gu59deOK6KEDsKNVjB9594cAWwGeunxMF6FhC vCiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=sa8Oz+7EARYAtQ0WLnCqgtp/WsCMus/3I6/+CNJ1OPw=; b=OlE5WtaG7/u3c+BwNK4KSZSBS3DQxZ/W1pFDrt8VadhS/HgygHFtapumEnrf+VTMzx PmOkWHvfM27WiFHN7yTaXo8w2dabFC8yAeKJDLWpIdB32qVVbebAqMteiuj4yzTsn19v cRcpsRp6uylboFvjxy1hD9zdZcMdjUuPZexxliwx5NPwkFqdaC2PlLR41L7GEMH2fhwy H7aANd89QL7ik70pWyT+Zxcl3pwCURA627UFj78ja37R5oMhYU0iQiQZLpjY6c0dOz9N MHKI4+E7D+f5WWXE0BK9dN82rCCljZBOBh1UfhWGh3gvj0hF0oUhoz3Sw6xNegPTlsRu qmqQ== X-Gm-Message-State: AFqh2krrZJ+DWivqPlqeFG9xIeBKhDUq9d7U6BZraK7k0NvL1r0SqF8/ xhCYXE7UdY15zAW9V/brudjOYA== X-Google-Smtp-Source: AMrXdXuIIp/c0w2El/LzauKFa6i872EXwxoi+fHEVHbXfB+cDnoMsFA/jCYUDrbbR0SKLLTI269Tgg== X-Received: by 2002:a92:cda4:0:b0:30d:bf1a:b174 with SMTP id g4-20020a92cda4000000b0030dbf1ab174mr2555528ild.1.1674154442314; Thu, 19 Jan 2023 10:54:02 -0800 (PST) Received: from [192.168.1.94] ([96.43.243.2]) by smtp.gmail.com with ESMTPSA id e36-20020a028627000000b003a7c2e97005sm763264jai.126.2023.01.19.10.54.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 19 Jan 2023 10:54:01 -0800 (PST) Message-ID: Date: Thu, 19 Jan 2023 11:54:00 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH -next v3 0/3] blk-cgroup: make sure pd_free_fn() is called in order Content-Language: en-US To: Yu Kuai , tj@kernel.org, hch@lst.de, josef@toxicpanda.com Cc: cgroups@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, yukuai3@huawei.com, yi.zhang@huawei.com, yangerkun@huawei.com References: <20230119110350.2287325-1-yukuai1@huaweicloud.com> From: Jens Axboe In-Reply-To: <20230119110350.2287325-1-yukuai1@huaweicloud.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 1/19/23 4:03 AM, Yu Kuai wrote: > From: Yu Kuai > > Changes in v3: > - add ack tag from Tejun for patch 1,2 > - as suggested by Tejun, update commit message and comments in patch 3 > > The problem was found in iocost orignally([1]) that ioc can be freed in > ioc_pd_free(). And later we found that there are more problem in > iocost([2]). > > After some discussion, as suggested by Tejun([3]), we decide to fix the > problem that parent pd can be freed before child pd in cgroup layer > first. And the problem in [1] will be fixed later if this patchset is > applied. Doesn't apply against for-6.3/block (or linux-next or my for-next, for that matter). Can you resend a tested one against for-6.3/block? -- Jens Axboe