From: Yijie Yang <quic_yijiyang@quicinc.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Richard Cochran <richardcochran@gmail.com>,
<linux-arm-msm@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <netdev@vger.kernel.org>,
<quic_tingweiz@quicinc.com>, <quic_aiquny@quicinc.com>
Subject: Re: [PATCH 4/5] arm64: dts: qcom: move common parts for qcs8300-ride variants into a .dtsi
Date: Thu, 10 Oct 2024 18:14:21 +0800 [thread overview]
Message-ID: <bd209e3c-41b5-4e70-ad15-b3f2ff265afb@quicinc.com> (raw)
In-Reply-To: <75vxiq4n2tdx3ssmnbq7qpp2ujtzjs4bkgpkpsi623fs3mpslx@ijmaos2gg5ps>
On 2024-10-10 14:18, Krzysztof Kozlowski wrote:
> On Thu, Oct 10, 2024 at 10:57:18AM +0800, Yijie Yang wrote:
>> In order to support multiple revisions of the qcs8300-ride board, create
>> a .dtsi containing the common parts and split out the ethernet bits into
>> the actual board file as they will change in revision 2.
>>
>> Signed-off-by: Yijie Yang <quic_yijiyang@quicinc.com>
>> ---
>> arch/arm64/boot/dts/qcom/qcs8300-ride.dts | 373 +----------------------------
>> arch/arm64/boot/dts/qcom/qcs8300-ride.dtsi | 364 ++++++++++++++++++++++++++++
>
> This is tricky to review. Use proper -M/-B/-C arguments for
> format-patch, so the rename will be detected.
>
> You basically renamed entire file!
Sure, I'll handle the optimization of that.
>
> Best regards,
> Krzysztof
>
next prev parent reply other threads:[~2024-10-10 10:14 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-10 2:57 [PATCH 0/5] Enable ethernet for qcs8300 Yijie Yang
2024-10-10 2:57 ` [PATCH 1/5] dt-bindings: arm: qcom: add qcs8300-ride Rev 2 Yijie Yang
2024-10-10 6:16 ` Krzysztof Kozlowski
2024-10-10 6:56 ` Yijie Yang
2024-10-10 2:57 ` [PATCH 2/5] arm64: dts: qcom: qcs8300: add the first 1Gb ethernet Yijie Yang
2024-10-10 2:57 ` [PATCH 3/5] arm64: dts: qcom: qcs8300-ride: enable ethernet0 Yijie Yang
2024-10-10 2:57 ` [PATCH 4/5] arm64: dts: qcom: move common parts for qcs8300-ride variants into a .dtsi Yijie Yang
2024-10-10 6:18 ` Krzysztof Kozlowski
2024-10-10 10:14 ` Yijie Yang [this message]
2024-10-10 2:57 ` [PATCH 5/5] arm64: dts: qcom: qcs8300-ride-r2: add new board file Yijie Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bd209e3c-41b5-4e70-ad15-b3f2ff265afb@quicinc.com \
--to=quic_yijiyang@quicinc.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=quic_aiquny@quicinc.com \
--cc=quic_tingweiz@quicinc.com \
--cc=richardcochran@gmail.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®