From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9386E149C6F for ; Wed, 18 Mar 2026 00:17:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773793068; cv=none; b=QKR0Wz3QPjX9qx+6kvdkYS+rt+wShBlyagO7F9Gz6nLd7337faSOEDTD8kSjIuHtPE8WJshUHMr4Lxcm3R6Z5HrzkwD/2nosDpnulzl4pIlGwMwvwR8+2zSm9Zhq8HLItlWbGZkQGaXo8mrMfrbeFLNgxEWgung4QeTrWv4lngM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773793068; c=relaxed/simple; bh=pMzEFpBgPkJUxC29kYMMi15r+hM4G9FRX3nLEfSPDN0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=BUT2FrkLQVi9wuhqNT/qhdKRJGxum/tpBP/MhSOw0zw4fEfY0ju3bHHScvkwBafG78A0qFRa8mQ9sVh7Kxazfi32le+Rhy40u1LLRE6/Zx2ocU0X3dDQCoHrmweKY7tO2iFMYp2Mswg0wAqeB1RSWqF4VWWLsr8+QRBRW+nUkPQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=KmGyGi1o; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=IbfgPOgS; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="KmGyGi1o"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="IbfgPOgS" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62HIJKqQ2294016 for ; Wed, 18 Mar 2026 00:17:46 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= OsEuIeYeunUYsxBkTNU3Sm5E54z1MAxMRTKCi/1j9sI=; b=KmGyGi1o9NzO7og5 oqnSYYow0dmSh652yLmJVOP4f10dL1IcOPxreXJvDG6/7ycLDJ9jUf5RBVNHxNmn cCkI4fSv2IkHR9Y+gqgsXhrIVcDYaK/O3yAB9lTgos2H7pY1qQbWvZpBa2JdhzYf 1wMOzySSgkxRP62E0LTRqMIyDSLkmXq84nRHgxKZ+ZecOsUi199Ji0cDVeabcDzZ FVNM1F4t6nK3X9cMD9gYwkwBCGoMAOeR1387TXgnNYcjzz7i0e5IqiIv+3q1lUG5 Mp81eGNb5MmPHjVVXSPTSW+AI70O6/Gg3SKLCzZGlqdsF4KGfKK9kOdI/HeF9D0S hyE8GA== Received: from mail-dy1-f197.google.com (mail-dy1-f197.google.com [74.125.82.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cya83smtn-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 18 Mar 2026 00:17:46 +0000 (GMT) Received: by mail-dy1-f197.google.com with SMTP id 5a478bee46e88-2c0cb775215so12510457eec.0 for ; Tue, 17 Mar 2026 17:17:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773793066; x=1774397866; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=OsEuIeYeunUYsxBkTNU3Sm5E54z1MAxMRTKCi/1j9sI=; b=IbfgPOgSjDJhjfvdR7/ybnH0ljqdYOmBMCVSY5m98ZJBV/Os1ga4mUvanlkOmhfnzf nr688GKEH5EZlY4M5AuzLeyAPPB5qbhHkb7ZXhErt5rfxpK/hyLgAxZcuatnMTrrxWfT xPgH5nCMvwUlND5IFVAPPOguqw/hyOnHY8uurrbA9kAH2NZmyF73ibqYiq2KUM/bJW01 CpKjx5e613pwnhLcVEAX42yZQId4UVjiRoj///2XkgSeq0b5LLMBG7RfCzHAZFP7d4rU +CZ9Zb+6fa9w8b4/DvzUSMeDSPzgdOQJfwY5TUS18OOJQF0MYYiF3rNoD8fBCw30qpB1 GYxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773793066; x=1774397866; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=OsEuIeYeunUYsxBkTNU3Sm5E54z1MAxMRTKCi/1j9sI=; b=myxEM6VXLPVP5ud71xsoafWd2S1FrcwHbAYiqQ3/0e1J1OL0x4hRv445MfIOaRNrbN z7C2M05BDlfwoxg2eGZPZTHKwaoAuY+5NQ7sxUK6FGyhnXG6QbJu8va7r397XZEpsrv4 MF9wkyrE3tehRRFk5g7RFcnaG932IIOw6rT9Ihxc41+ByH6YBA2ToPi9f1X36JuH3Z2L mlo+KSPxwvxHQ7cIDYeOLiaSTQfZtwapMkZ5z8jarnLe8CFaDr7jtUT+nY7qsQwrWaFr j0ndLGipQ6852sV7VYhnFpActEL606LCmOdu7RRtHwfovNMTUaOHkFumhYfkRJ2zNJfB sVYg== X-Forwarded-Encrypted: i=1; AJvYcCWN0MI7N0B6tecSnBpHK1NMWvK18hz44o1DRYOFa+gMhLj3s8yyRT6VBlVV/qnaclRCZPfcjkG+Cnrpu54=@vger.kernel.org X-Gm-Message-State: AOJu0YxvjEwTDxMmnhkj0puixcEJvEkYEV9w4NzDpel6akKAULICvl3k uc/vymk9Yy1Mu8Hx5Iu2vlzWPIGOrzMKIq1tWi+b2KMY0mDDyQgMCML43mvo36g3gnoHCOU4qQy wmn+pW33SJAKjBjdc9D/l/eIZk1NqT16j7zq+eNKjfkR+T6KKyorihvYD/Bc3sg5Tj2Y= X-Gm-Gg: ATEYQzyav766oLn/+rB/bjXvQ4XAnW0J7o2PCjlZQyDimTl2x/I4rFAsuNF2Mb5gssA RKBjn+1No1Qpx74mOfSnD4KbqdxKa3PSs9nYs/4g5TndqPx2f/gyBHNuE47QOJg48T/Ntuquxxe 5hUMK41+YBmeLVY3mtY5DyJW9Tk8kKARN2Cn9NObhsaciWCHJDIdGBMaU2lWOMHXWITnECZokbr EW3QPkVQepj4nC25gmZW/GjfvPhIfI4c527fd1gxh2gcx6BhsNfvCxmsZaPzbJobmm/lifsKtpl TD6MDWxjIk8uDJAnfKs5XZLkgj7dekraQQ+EvxNFCfvxv0qk9RO9YrQb8YOtiPo5hgXMewkQpvu wQV0A+thuvHz9Zw/5Kt8mOxrUaYNJpIR0Fm0+df+iWHVGtcE7NdH+JAajTsZ1FkvB67buou53J8 4JJ1KLyOWB7Jec5A== X-Received: by 2002:a05:7301:4b03:b0:2b7:32a6:82d1 with SMTP id 5a478bee46e88-2c0e4f90b9dmr829578eec.13.1773793065588; Tue, 17 Mar 2026 17:17:45 -0700 (PDT) X-Received: by 2002:a05:7301:4b03:b0:2b7:32a6:82d1 with SMTP id 5a478bee46e88-2c0e4f90b9dmr829557eec.13.1773793064958; Tue, 17 Mar 2026 17:17:44 -0700 (PDT) Received: from [192.168.1.41] (c-24-130-122-79.hsd1.ca.comcast.net. [24.130.122.79]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2c0e560fb5fsm1907343eec.31.2026.03.17.17.17.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 17 Mar 2026 17:17:44 -0700 (PDT) Message-ID: Date: Tue, 17 Mar 2026 17:17:43 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] wifi: ath12k: fix HE/EHT capability handling on big endian To: Alexander Wilhelm , Jeff Johnson Cc: linux-wireless@vger.kernel.org, ath12k@lists.infradead.org, linux-kernel@vger.kernel.org References: <20260317-fix-he-eht-capabilities-on-big-endian-v1-1-e7b937b32768@westermo.com> From: Jeff Johnson Content-Language: en-US In-Reply-To: <20260317-fix-he-eht-capabilities-on-big-endian-v1-1-e7b937b32768@westermo.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-ORIG-GUID: 70DjzCodOE1NeWX9MBJcbqAQutYHRHJK X-Proofpoint-GUID: 70DjzCodOE1NeWX9MBJcbqAQutYHRHJK X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzE4MDAwMSBTYWx0ZWRfX0XzV/PEKyjNS Ohg8JiCXaRlgJDvkoPDol3ADadfexiJjzQ2clYItAKB+ZYgw7ZMePtzHO5l18oSdijy5pP3yznm 0HBEKIL2A1ZJdOVWcI4xy1fJEEfTxZW4F6pwXV8KEJ2Exf/faNDrjfQ0Z0NH+j2hqawPx/mwpR8 bnyD75YZIsXiKFF4IeZNE3pGtP63sk0iJFD71/b332/N6goLt9juCZX80nh64l+niuGho7k/r6L Q8xoFP5WZOl/hdQha7XJkJaHR59JQsOAADBzkZ+NzepshICPhiSxv3S0OiuMWxuvk7AaVCbjjRe lZ+OTdWGG30PefMxoEwIRl0/na6bkqM/Z8CI0UlFYNGagOJlV5PuT9LbfS0HSgqB38SBnK6MQYo j0AfLp70ShAqMnYaCbFac4LVWHFtcp8DqkPnjb0YIzNuNRRR253Cba5NrkUtzsUAOBfp8uBdSRh 5+HAQB7zZF+vtPvunOw== X-Authority-Analysis: v=2.4 cv=Y8n1cxeN c=1 sm=1 tr=0 ts=69b9ef2a cx=c_pps a=Uww141gWH0fZj/3QKPojxA==:117 a=Tg7Z00WN3eLgNEO9NLUKUQ==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=N9GNhs4bAAAA:8 a=YmICAkyFvM6EgTkIZ6oA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=PxkB5W3o20Ba91AHUih5:22 a=PZhj9NlD-CKO8hVp7yCs:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-17_05,2026-03-17_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 adultscore=0 bulkscore=0 impostorscore=0 phishscore=0 clxscore=1015 lowpriorityscore=0 malwarescore=0 spamscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603180001 On 3/17/2026 3:59 AM, Alexander Wilhelm wrote: > Currently the driver uses u32 data types for the HE/EHT capabilities in > CPU‑native order. However, the ieee80211.h header defines these fields as > u8 arrays. This causes the ieee80211 registration failure on big‑endian > platforms, as shown in the following log: > > ath12k_pci 0001:01:00.0: BAR 0: assigned [mem 0xc00000000-0xc001fffff 64bit] > ath12k_pci 0001:01:00.0: MSI vectors: 1 > ath12k_pci 0001:01:00.0: Hardware name: qcn9274 hw2.0 > ath12k_pci 0001:01:00.0: qmi dma allocation failed (29360128 B type 1), will try later with small size > ath12k_pci 0001:01:00.0: memory type 10 not supported > ath12k_pci 0001:01:00.0: chip_id 0x0 chip_family 0xb board_id 0x1005 soc_id 0x401a2200 > ath12k_pci 0001:01:00.0: fw_version 0x111300d6 fw_build_timestamp 2024-08-06 08:43 fw_build_id QC_IMAGE_VERSION_STRING=WLAN.WBE.1.1.1-00214-QCAHKSWPL_SILICONZ-1 > ath12k_pci 0001:01:00.0: leaving PCI ASPM disabled to avoid MHI M2 problems > ath12k_pci 0001:01:00.0: Invalid module id 2 > ath12k_pci 0001:01:00.0: failed to parse tlv -22 > ath12k_pci 0001:01:00.0: ieee80211 registration failed: -22 > ath12k_pci 0001:01:00.0: failed register the radio with mac80211: -22 > ath12k_pci 0001:01:00.0: failed to create pdev core: -22 > ath12k_pci 0001:01:00.0: qmi failed set mode request, mode: 4, err = -110 > ath12k_pci 0001:01:00.0: qmi failed to send wlan mode off > > Use the __le32 data type for the HE/EHT capabilities instead and avoid > swapping, so that both platform endiannesses are supported. > > Signed-off-by: Alexander Wilhelm With this series applied I see with make W=1 C=1: drivers/net/wireless/ath/ath12k/debugfs.c:413:65: warning: incorrect type in argument 1 (different base types) drivers/net/wireless/ath/ath12k/debugfs.c:413:65: expected unsigned int [usertype] v drivers/net/wireless/ath/ath12k/debugfs.c:413:65: got restricted __le32 >From existing code: f5c90ff80b4c0 (Sowmiya Sree Elavalagan 2025-01-30 11:41:04 +0530 413) extra_mcs_supported = u32_get_bits(cap_band->he_cap_info[1],