From: Sidhartha Kumar <sidhartha.kumar@oracle.com>
To: Vlastimil Babka <vbabka@suse.cz>,
"Liam R. Howlett" <Liam.Howlett@oracle.com>,
Matthew Wilcox <willy@infradead.org>,
Lorenzo Stoakes <lorenzo.stoakes@oracle.com>,
Jann Horn <jannh@google.com>, Pedro Falcato <pfalcato@suse.de>,
Suren Baghdasaryan <surenb@google.com>
Cc: Harry Yoo <harry.yoo@oracle.com>,
Andrew Morton <akpm@linux-foundation.org>,
maple-tree@lists.infradead.org, linux-mm@kvack.org,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 01/12] maple_tree: Fix check_bulk_rebalance() test locks
Date: Tue, 2 Sep 2025 15:36:22 -0400 [thread overview]
Message-ID: <bd2804ce-2d81-4a39-9623-32fb2fbf5351@oracle.com> (raw)
In-Reply-To: <20250901-maple-sheaves-v1-1-d6a1166b53f2@suse.cz>
On 9/1/25 7:08 AM, Vlastimil Babka wrote:
> From: "Liam R. Howlett" <Liam.Howlett@oracle.com>
>
> The check_bulk_rebalance() test was not correctly locking the tree which
> caused issues with the sheaves testing in later patches. Adding the
> missing locks fixed the issue.
>
> Signed-off-by: Liam R. Howlett <Liam.Howlett@oracle.com>
> Signed-off-by: Vlastimil Babka <vbabka@suse.cz>
If needed,
Fixes: a6e0ceb7bf48 ("maple_tree: check for MA_STATE_BULK on setting
wr_rebalance")
Reviewed-by: Sidhartha Kumar <sidhartha.kumar@oracle.com>
> ---
> tools/testing/radix-tree/maple.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/tools/testing/radix-tree/maple.c b/tools/testing/radix-tree/maple.c
> index 172700fb7784d29f9403003b4484a5ebd7aa316b..159d5307b30a4b37e6cf2941848b8718e1b891d9 100644
> --- a/tools/testing/radix-tree/maple.c
> +++ b/tools/testing/radix-tree/maple.c
> @@ -36465,6 +36465,7 @@ static inline void check_bulk_rebalance(struct maple_tree *mt)
>
> build_full_tree(mt, 0, 2);
>
> + mas_lock(&mas);
> /* erase every entry in the tree */
> do {
> /* set up bulk store mode */
> @@ -36474,6 +36475,7 @@ static inline void check_bulk_rebalance(struct maple_tree *mt)
> } while (mas_prev(&mas, 0) != NULL);
>
> mas_destroy(&mas);
> + mas_unlock(&mas);
> }
>
> void farmer_tests(void)
>
next prev parent reply other threads:[~2025-09-02 19:36 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-01 11:08 [PATCH 00/12] maple_tree: slub sheaves conversion Vlastimil Babka
2025-09-01 11:08 ` [PATCH 01/12] maple_tree: Fix check_bulk_rebalance() test locks Vlastimil Babka
2025-09-02 19:36 ` Sidhartha Kumar [this message]
2025-09-01 11:08 ` [PATCH 02/12] tools: Add testing support for changes to slab for sheaves Vlastimil Babka
2025-09-01 11:08 ` [PATCH 03/12] maple_tree: use percpu sheaves for maple_node_cache Vlastimil Babka
2025-09-02 19:39 ` Sidhartha Kumar
2025-09-01 11:08 ` [PATCH 04/12] tools/testing: include maple-shared.h in maple.c Vlastimil Babka
2025-09-01 11:08 ` [PATCH 05/12] tools/testing/vma: Implement vm_refcnt reset Vlastimil Babka
2025-09-01 11:08 ` [PATCH 06/12] testing/radix-tree/maple: Hack around kfree_rcu not existing Vlastimil Babka
2025-09-01 11:08 ` [PATCH 07/12] maple_tree: Use kfree_rcu in ma_free_rcu Vlastimil Babka
2025-09-01 11:08 ` [PATCH 08/12] maple_tree: Replace mt_free_one() with kfree() Vlastimil Babka
2025-09-01 11:08 ` [PATCH 09/12] tools: Add sheaf to slab testing Vlastimil Babka
2025-09-01 11:09 ` [PATCH 10/12] maple_tree: Sheaf conversion and testing Vlastimil Babka
2025-09-01 11:09 ` [PATCH 11/12] maple_tree: Add single node allocation support to maple state Vlastimil Babka
2025-09-01 11:09 ` [PATCH 12/12] maple_tree: Convert forking to use the sheaf interface Vlastimil Babka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bd2804ce-2d81-4a39-9623-32fb2fbf5351@oracle.com \
--to=sidhartha.kumar@oracle.com \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=harry.yoo@oracle.com \
--cc=jannh@google.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=maple-tree@lists.infradead.org \
--cc=pfalcato@suse.de \
--cc=surenb@google.com \
--cc=vbabka@suse.cz \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®