From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f42.google.com (mail-ot1-f42.google.com [209.85.210.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 95FED3126C0 for ; Fri, 5 Jun 2026 12:25:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780662325; cv=none; b=j2FB+7/bg6BdevJ/lcmeXaiFWPqNqVLWggQOkWd0JcaXrsbb37W8HP1WYUL4JNYks/KHVfRTpQWDpgTnZ+UU7CAXAUxhMpxh56FPZ63cfwDOeLzS9L94bvUQMFj9dqsGG3JIjYtskkBKRJpC+91Z6rsuFy7/06VKy7YrK2UxsLw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780662325; c=relaxed/simple; bh=Cco+vFiWz8nH8jHJl25YPtjf0AjyxuJKLseQuLXyV6w=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=q7DWDrhCSMQ7saX+IVPZGhkiTbqRbZVUaR2TW8d+slTNOBoedlS94UPTMkL+5/kxlX+0UFJ5qoOFt93B9YzuFyLr5zCclI+2H+r6wvOM7UXITVwB3XUch9BHvBfb6Vio2Me5Ql+Bk5dQm9F2USUWTGW1c+aFezYqoOEGAjA3dAc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=riscstar.com; spf=pass smtp.mailfrom=riscstar.com; dkim=pass (2048-bit key) header.d=riscstar-com.20251104.gappssmtp.com header.i=@riscstar-com.20251104.gappssmtp.com header.b=IXBmic84; arc=none smtp.client-ip=209.85.210.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=riscstar.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=riscstar.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=riscstar-com.20251104.gappssmtp.com header.i=@riscstar-com.20251104.gappssmtp.com header.b="IXBmic84" Received: by mail-ot1-f42.google.com with SMTP id 46e09a7af769-7e6dcc22cbcso1540452a34.1 for ; Fri, 05 Jun 2026 05:25:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=riscstar-com.20251104.gappssmtp.com; s=20251104; t=1780662323; x=1781267123; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=hOWy2W3C8F0epU9cKoqDrCPhuhX/iOel8Vt4x+uvwak=; b=IXBmic84U3qhLy2OlFCVw1TfMbmt5f1V8pMbgaI9C2HWqGtb3bUBwCKHZs4Co/Wc2c rJQk7x5IRxnMXh9Gw4VZyjscsrDHn7w8zoPb9xk+5gjJsN42yGVa9ka0hF9mVVZPvI2y Iki12w1JvSIIMV1wyLsWxMoc/QCWprwf2RAHIsM8xkUJDYVkUyr3+yBLI6LMmaYK4TKp nu9TGkgkqSXsaBs1QpZVIlfdgtPStBtGwkaThjDxbiJS+VkjWXgu4HjU1Drgprkid0nS Vf/ezm1WuC2+FIp//RYqQutxGVQigFQV87WEQo0TuxlnO/AMMeVt7ok7eRLhq8LrIIF4 wbDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780662323; x=1781267123; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=hOWy2W3C8F0epU9cKoqDrCPhuhX/iOel8Vt4x+uvwak=; b=PhLpt9XwC9VlpMSspYvifig29+Km6kA8FerGix/23PKDt5K5xRNlQQ7dfe+IvsdS5r HCLTS5Lh5c18AkCJGkr8aPTtl4JVI6ZinKMTiNzurfS7B+TM4I6QiiGZbMBO61NBl8l8 x1qPH2HJqDsO7IjTOTYqHqQAbP+a0WMvJoASdelijDwk6WDdJLRL65MX8lZHL3F5u2Hr +u3dJXIkSR16ObCLqcpoOwMGsqsCcrtwnj8vY9owQTFsOONZn7XAYpW0xtT3EVI91lRe rjJ6KJa+6iD6bI/TOXgyf5uUk8jq0SUM4AQyLH5kBN6iYaW5rU9Nn7Iy42JUj4HxpB6g aSAA== X-Forwarded-Encrypted: i=1; AFNElJ/vXCu2JZ3qfKKi32lmruaXD2yo/WSG/4Jzaw2JamfYii1CCCtwW2jtUDabWMsiuwTBC42RDkRPSVK5MsM=@vger.kernel.org X-Gm-Message-State: AOJu0YxT/Ze4Hy1ridEKS79gnDfCx6g11xoT/lUbUbd6I65NLNFaXAcE Y4wQPOqlgfIORTEec6dSQ3kHnhLDjVREJj75kODlhjqtFiG/Aa11pWiyHrZBJbWyGcc= X-Gm-Gg: Acq92OFdxD6pKdAHvCAO1DaNB6obLOwVV+9TSoSdSZZ9Mnh5B6azjOnL/VMsegB7j0T DlPVPGeXaU7UhcuHPlBDe0fMPsMkK3qCsDxcG5Gw3PXthbbcq8y8kB9jpj2OCpzKPHyH4MdGSTT iF3EjBv46XmIlCwqXhKZWhbWNTF2WKwurHXoUI/dRwTRhr0wXWjc1gftWxKF2fNCkAuG0ViC+kK YdVouZOsDbSs7iPLvNvVYFZfi5zyC+g6OjFmp+xLX4NuzF9f+NGIuxLZLWnOITgqJUwxu2ChyNS pZYLUnXF7xqO1NAmIQscbyvXqynoSG15U68YYqVj4jmOHQfDbspdDTTJeIHBkXVMf6w+U0ENk0A ze22DSvR9PL6DE6kqDkm2CQWcjg6ldsbSQvGVKcQux7UgD4r/fyDXEI28W/QlmLlOl6NPNQT8fS L+iRF5NIj+nrnqXG4mF2P0RxPXGYK14VEQlXk= X-Received: by 2002:a05:6830:6685:b0:7e6:deb1:484d with SMTP id 46e09a7af769-7e70c7b1386mr1725355a34.13.1780662284484; Fri, 05 Jun 2026 05:24:44 -0700 (PDT) Received: from [172.22.22.234] ([73.62.185.64]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-7e6e7974f22sm5817653a34.25.2026.06.05.05.24.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 05 Jun 2026 05:24:44 -0700 (PDT) Message-ID: Date: Fri, 5 Jun 2026 07:24:40 -0500 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v2 10/14] dt-bindings: net: toshiba,tc9654-dwmac: add TC9564 Ethernet bridge To: "Rob Herring (Arm)" Cc: weishangjuan@eswincomputing.com, linux-gpio@vger.kernel.org, inochiama@gmail.com, davem@davemloft.net, devicetree@vger.kernel.org, kuba@kernel.org, me@ziyao.cc, hawk@kernel.org, arnd@arndb.de, konradybcio@kernel.org, mohd.anwar@oss.qualcomm.com, hkallweit1@gmail.com, pabeni@redhat.com, ast@kernel.org, maxime.chevallier@bootlin.com, bpf@vger.kernel.org, boon.khai.ng@altera.com, linusw@kernel.org, andersson@kernel.org, sdf@fomichev.me, linux-kernel@vger.kernel.org, livelycarpet87@gmail.com, a0987203069@gmail.com, linux-stm32@st-md-mailman.stormreply.com, daniel@iogearbox.net, john.fastabend@gmail.com, alexandre.torgue@foss.st.com, richardcochran@gmail.com, rmk+kernel@armlinux.org.uk, krzk+dt@kernel.org, conor+dt@kernel.org, rohan.g.thomas@altera.com, gregkh@linuxfoundation.org, Daniel Thompson , chenchuangyu@xiaomi.com, andrew+netdev@lunn.ch, mcoquelin.stm32@gmail.com, edumazet@google.com, siyanteng@cqsoftware.com.cn, wens@kernel.org, brgl@kernel.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, julianbraha@gmail.com, netdev@vger.kernel.org, chenhuacai@kernel.org, prabhakar.mahadev-lad.rj@bp.renesas.com References: <20260605010022.968612-1-elder@riscstar.com> <20260605010022.968612-11-elder@riscstar.com> <178062720108.1744752.12164392208085928081.robh@kernel.org> Content-Language: en-US From: Alex Elder In-Reply-To: <178062720108.1744752.12164392208085928081.robh@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 6/4/26 9:40 PM, Rob Herring (Arm) wrote: > > On Thu, 04 Jun 2026 20:00:17 -0500, Alex Elder wrote: >> From: Daniel Thompson >> >> Add devicetree bindings for the Toshiba TC956x family of Ethernet-AVB/TSN >> bridges. >> >> The TC9564 contains a PCIe switch with one upstream and three downstream >> PCIe ports. The third PCIe downstream port has an attached embedded PCIe >> endpoint, and that endpoint implements two PCIe functions. Each internal >> PCIe function has a Synopsys XGMAC Ethernet interface capable of 10 Gbps >> operation. >> >> The TC9564 also implements an embedded GPIO controller, which exposes >> 10 lines externally. Some platforms use these GPIO lines, so this >> GPIO controller is managed by a separate driver. Other embedded >> peripherals (like a microcontroller, SRAM, and UART) are currently >> unused. >> >> The GPIO controller is managed by registers accessed via MMIO on an >> internal PCIe function's registers. >> >> Signed-off-by: Daniel Thompson >> Signed-off-by: Alex Elder >> --- >> .../bindings/net/toshiba,tc9564-dwmac.yaml | 120 ++++++++++++++++++ >> MAINTAINERS | 6 + >> 2 files changed, 126 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/net/toshiba,tc9564-dwmac.yaml >> > > My bot found errors running 'make dt_binding_check' on your patch: Thank you for this report. After upgrading the "dtschema" package I also see these errors. The "gpio" and "ethernet" properties will have an "unevaluatedProperties: false" constraint added in the next version of this series. The name of the binding file will also be correct in the MAINTAINERS file. -Alex > yamllint warnings/errors: > > dtschema/dtc warnings/errors: > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/toshiba,tc9564-dwmac.yaml: gpio: Missing additionalProperties/unevaluatedProperties constraint > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/toshiba,tc9564-dwmac.yaml: ethernet: Missing additionalProperties/unevaluatedProperties constraint > > doc reference errors (make refcheckdocs): > Warning: MAINTAINERS references a file that doesn't exist: Documentation/devicetree/bindings/net/toshiba,tc956x-dwmac.yaml > MAINTAINERS: Documentation/devicetree/bindings/net/toshiba,tc956x-dwmac.yaml > > See https://patchwork.kernel.org/project/devicetree/patch/20260605010022.968612-11-elder@riscstar.com > > The base for the series is generally the latest rc1. A different dependency > should be noted in *this* patch. > > If you already ran 'make dt_binding_check' and didn't see the above > error(s), then make sure 'yamllint' is installed and dt-schema is up to > date: > > pip3 install dtschema --upgrade > > Please check and re-submit after running the above command yourself. Note > that DT_SCHEMA_FILES can be set to your schema file to speed up checking > your schema. However, it must be unset to test all examples with your schema. >