From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753215AbdJLUFa (ORCPT ); Thu, 12 Oct 2017 16:05:30 -0400 Received: from mail-sn1nam02on0052.outbound.protection.outlook.com ([104.47.36.52]:30811 "EHLO NAM02-SN1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751348AbdJLUF1 (ORCPT ); Thu, 12 Oct 2017 16:05:27 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=brijesh.singh@amd.com; Cc: brijesh.singh@amd.com, Paolo Bonzini , =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= , Herbert Xu , Gary Hook , Tom Lendacky , linux-crypto@vger.kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [Part2 PATCH v5.2 12.2/31] crypto: ccp: Add Secure Encrypted Virtualization (SEV) command support To: Borislav Petkov References: <20171007010607.78088-1-brijesh.singh@amd.com> <20171011165030.115696-1-brijesh.singh@amd.com> <20171012182102.ffyxggnhyymtmhky@pd.tnic> From: Brijesh Singh Message-ID: Date: Thu, 12 Oct 2017 15:05:20 -0500 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <20171012182102.ffyxggnhyymtmhky@pd.tnic> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US X-Originating-IP: [165.204.77.1] X-ClientProxiedBy: MWHPR04CA0031.namprd04.prod.outlook.com (2603:10b6:300:ee::17) To DM2PR12MB0153.namprd12.prod.outlook.com (2a01:111:e400:50ce::16) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 38611bd4-48b9-49ac-ea3d-08d511ac93ed X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(2017030254152)(48565401081)(2017052603199)(201703131423075)(201703031133081)(201702281549075);SRVR:DM2PR12MB0153; X-Microsoft-Exchange-Diagnostics: 1;DM2PR12MB0153;3:ckJ/FeWqPZOH/MYaFUuhuZppd1Nwm3lJEiFBGv/7ItxuvqNyIz+NoYJ3OMaTLqKgjceFEiWxMkSOQQZBVYY1SyqWuDb5MIH+2EmrfklK3do/bzktjQe26X73IRTvLdP5xHM/gvvC+Ia2W1pMN8cMvD6hUC5eC+OSoyI5yrhyJE/cPJYEEUEn7/1J9tqOFYXjn36nBLNYqxGj5xnHNPDjNPi8p2vAWtLSgXkExuBoaOZVn6XC76favVFpEksVXEPC;25:1XlYRs0s05jfa68zBSK0WWoIltxgL2rOmvY0Gi8vf7oc7WkUZVOU/Z6ifykw1zTZ5I8xnictvvkiU5n4f+gslL/IoU++99JLsgg6xhOwVuEtY8+VQnoKistg/zSJBchEXFx+ocufdP/PjGRXUZ+D8uQa6st5Cwni03O07gU1hRKC/NaB4sJX0lnaCwDqHRlEfZtIE9ob6pwK86BWIvEYGdb2x6NaxX01jWp4kBqB3E0ktQ4QZr8GZOhiH3UQLRFKhcK7T6flNg1Z7PGfYv7+yg8q6p6JbCvsJ3Vx2pzViWulwPFqV2cGJJZNRjOJmZwyib+raWWLZNwIrOJUWZYODw==;31:2sYFfSiD7u3gUZVxOLHNDyL0gu4jUAV9dvlyQ1SVQgrcUM4IDM21jL3jRtXlJwhEmpdcwHozJmQ+3yBJkVnB1rXuQCzi8GRWgTg59Hc4iphxe2cB7FPNEUpXgn2cA/0VvGwHZLjgkJfmv/QkZTutwWSEL0qEB8xcn/FUr7CrBb+Bj3r4lsEtMO0tcUZJb71m8zMSThJRLgL0wSdyZjoRcW7Bj4T0RlwCAdZQayAk6JU= X-MS-TrafficTypeDiagnostic: DM2PR12MB0153: X-Microsoft-Exchange-Diagnostics: 1;DM2PR12MB0153;20:X+44dJqouB9VEGxlYxzH2LBe0YD3iVva9em2aRueNrW/xDD36YiCfz+YZ3Kj2lBuwWmxB+8R3AqXnM8v10wtGHDiOJSgbMdV2s57sNG/zRgc5dcPv5uv3XPnSl3x01QWPYjUuKxl7Q6irCxG6RXE4IJRlcH8f8+j9IRddttM6qLa/x7j8uv4SzI0Ot2PWmuwAEajPQVWOUpW24ctk2XO67Xua24faDdYNieOM1BxpNjfoZ82qRiaFXms+WE14newDyBkh4GU19qEjeqwxq/SlnGyO7V07srEWuBMcUuFqhXRlWGYUVI5pp2C/X0PK/K+losG/ymV0c7f3juydzFmaFG8vMwnd4riVk9vgAgsgoUdgeYk4qcfRmLipAZjamfIudWujhXEillrbAYiJTP/Xtz/ikQTfbDH1csXIIla+zSYjMKMlQntiM1BegDgVrm68KquRr/yIUmEyWrRQxb9WY9615cQKqNiK4++sguznNVxIQsY+stmqP8tmS1CkXB7;4:8XjnTQNy5enGR3iD6w1qw7+Pol5tIqg0IrQrdCcAtGt8FmyV+Llxoh0aJsH9PmrshwTdIsaIp/w/vRNrqpJbNGz8bR/4mck++tc0JvM+bSloYDNTibuSrQR5/NUOBZfdW7XjZcRyr8FPzCBNeQJqsudQG3+nWxdsLldR85vQ2huINAjbmooIS9B4Y43OzeWdRVppHEbkKwltYBPEr4iC/qJBo/kD8wapceZLFZYz1URPH87jCh87ih0f97gceLcn X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(100000703101)(100105400095)(93006095)(93001095)(10201501046)(3002001)(6055026)(6041248)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(20161123562025)(20161123564025)(20161123558100)(20161123560025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:DM2PR12MB0153;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:DM2PR12MB0153; X-Forefront-PRVS: 04583CED1A X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6009001)(346002)(376002)(39860400002)(199003)(24454002)(377454003)(189002)(5423002)(86362001)(7736002)(31696002)(83506001)(105586002)(305945005)(8676002)(558084003)(230700001)(50466002)(53416004)(64126003)(6486002)(2906002)(33646002)(68736007)(36756003)(106356001)(4326008)(189998001)(6916009)(16526018)(8936002)(25786009)(101416001)(47776003)(2950100002)(53546010)(54906003)(76176999)(54356999)(6666003)(50986999)(58126008)(31686004)(23676002)(316002)(65956001)(81156014)(81166006)(53936002)(5660300001)(6246003)(65826007)(97736004)(229853002)(66066001)(6116002)(3846002)(65806001)(478600001);DIR:OUT;SFP:1101;SCL:1;SRVR:DM2PR12MB0153;H:wsp094352wss.amd.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtETTJQUjEyTUIwMTUzOzIzOlJpUHY0Um96cGlKbGI0RUtwZTZRWWdRcjdw?= =?utf-8?B?MjhNSk14ZDBwZ0pvNURpWVlrSmpJZVFWVWpGYkRoU3lydWJPeVg2WUhWNC9H?= =?utf-8?B?aTA3dE93K1l6cktSZWRwU21wd3duT2R1M05SVmhXSCtxUkJPZlBZZkE5RSs3?= =?utf-8?B?YVlrWFhyd1hqaDBtK1FOM010T2hDcmtQR0kyczlKR0R3YlNENE9qMzVJaCtx?= =?utf-8?B?QlpZOXYrSEMySGRURHJaamk3cG84eDVWblNKQ1ZnQllBZVRORzJnb01FTGNU?= =?utf-8?B?bzdlcXpmZTdrN3FRYkNqcEQzSDVENVhaQ2pnSCtTUFo0allxMUVJTVQ1OThm?= =?utf-8?B?TWFpZ3grd3ZCUmRTeW9JU3N6NmliMVBlak5SOWVyNWhrR2JPTXpabklCK05a?= =?utf-8?B?c0VuaWxIMm1hU21ycldqNTB2RkplNHJMb21HMEtOV3c2VFI2MGR6YW54aEFO?= =?utf-8?B?UC9MNTlOZGJHbVAvZ1NROWF4V1R1eGRzeEJnTXFtVXlRaUQzTk5CRzBSNVBq?= =?utf-8?B?UVRZdWFsdUdIa0FNWDlnRVpiNGsyelVXRVlTa0NNYkFFN0drclVlU2thZlZP?= =?utf-8?B?T3Z2OFgwVkpZU2JxeS9oSndZQ1FDcDhjL0I2bmhQbVRFRk9GT200VG43bSts?= =?utf-8?B?OURqRlhiamVzbnA0a0ZDemRISlhNcHRnSXoyeGY0OTBmdXZubzFBUkhSVG85?= =?utf-8?B?NjBxVjY3ZEU5dUtIdFl2SEROOFVwQ1E3VldUaGNlVHkrZERHWEJDTHZCVjly?= =?utf-8?B?ZUhGVjMrWXFrUUN3cThJclVKMjZwYTFVR2pMTVp4Z2s4cGdjamVvVTJPK1RX?= =?utf-8?B?ZiswWlhNYmNkN3FsR3pnYjIybjZJU3d4Wmt1eFlhTDZ6OFl4TFd6QTU5SXcr?= =?utf-8?B?U3l4UVd1a1ZVcHIranpUOGFtTWZ3RDJSU2IvenZtV1R3WWhRaHNub25jUmVH?= =?utf-8?B?dWhFUEEvVmhGNTM2dDBmYWJUTmEyczlNTDF2M050cWJNdTJHazl0NUs1Smp3?= =?utf-8?B?cXA0S2RtVmxmRzhCTjVWb3hqRUlFanRLeVNkUTRBZHRlSzdCTm5veGFJanRt?= =?utf-8?B?UXFrSktnNjRyVXlaU2lNR0JuaWRBTldVK2doSDBLOTdXUng1bFkzcVZkYU1N?= =?utf-8?B?cWJabFh4UVR5OFNxMC9sMkxPNnZaUC8xKzIrSS91N3FYdmNJa3NQUTZWVkZH?= =?utf-8?B?eWN6NzA5NGpGT2U3WEY4elBaaWEvQnBnbmtsY2xwbDlvWkYzQ1J5Qm0yUGNo?= =?utf-8?B?cGpaU0Vsd2FyS3liWnJ2YkNKTTUzWndzU2xYMFFhSGpjUVh2Q2tJRTJtYXNq?= =?utf-8?B?V3R5VEtTNW4vS3huc0VNUXpQQXFySTRFVnNsWUJQSzk0YlJERXpRZkRlMWR1?= =?utf-8?B?Q3dsZklaYmFJUTUrQWZFclh5WFo4OVgzRVp5RzY0dWtRK3hvYUd4bFBabU5X?= =?utf-8?B?MDNzRjJHK0k5OEtLZWdmNFFMVTFDa1RIVDN2bWVLQ1JxUVRGOHYwQ2N6T2Vk?= =?utf-8?B?RDlndnRkb1VselNub3UvUE95QU9tUkd5NHhtdUFBWWJ3Z1VVc2llWUdPSFFO?= =?utf-8?B?QzgxWlhwNkVXZ0xnclN4Q0dTNkZMZjRWeEFJRUxFdllGVlhaMGJyZXgxbCtL?= =?utf-8?B?THJhcXk1UWcwTjJmalZTem1Tc2V3czRUS3dtVkkwQk9BR3BYck0vQzdjbGxr?= =?utf-8?B?eDlZbW1KR3lnLzB1V3h2ZUxxbitESS9wM25kSXBxbTdGZXlHemErQzV6aVZS?= =?utf-8?B?VktWeHJleXJWR0FPUGd5MGlmL2pmaDhQSkowQTdkcEV2aEFha0cwc3A5eSt4?= =?utf-8?B?bXlndTFydDd2eDkvUmdueVcyYVhRZjNobUpqQXZCbjZtMjdubHl3VllHL3pX?= =?utf-8?Q?5kqfh2d7ltdzwP4DqBaXMP+B7coPUxAr?= X-Microsoft-Exchange-Diagnostics: 1;DM2PR12MB0153;6:r4bcu+oe68oq7oBNBAMeg1+Kl+3WVYxI0fHWRhk70ZIZSl49saedXZ9Ncu0qtBpJQoGfejfKZSw0PRf5lRZxJ6CHyE19MHxEDgp2YtlppthASBGM81kmUWmCJQzBbnV+NTMXTnJdgGzHack/M+yMLJPnaG0FB2B6m4aZ2p2hbd5ywwznzq0+tsC5npTTemnI7mEnhuTZBNO5VWGBaqR9vVPT8QaCuomjPgDOzLZE9i9iD8pq1mengBnnravW7kz9J5wc96cFMQsMpIjRa+PnZJFdoCajuOX//3f3nTENydp6bFiv9YV1dI4kjuoMFZ5B9vu5MW4mF+zJ9RvwpDj5lw==;5:gXZYY/BRS8Hcp4jQ79AgjatQbdRhA3Pnnh/iJajzhtUqZ7ViETja5malHstrPXErd29PoWdPFnplF/X+3PfZt597d+M3TpfVtfQ4Xiv7/pr6oxYxXSptDHriB2tczrOcy6BP87C75ACn48kCfaNfmw==;24:raUMMoF4UPTUtemxYejxAInvofI48EckcQn8VmJYhJrVs1ofvfPYx336Zsz7Y6s9HvZ4e8rkrHVCw1SYfOLhSoZxTVQviqJd5z0Se6kopVQ=;7:EC+oMHytmlGyTUdypRxL5vcDBMI95i4/BcYgLtSsElIJGWs2FZz++4ozTpXzkJHyTYQikTsMUunO7AmECyAsvaQKmERSTqziTVX/OC1dPFmSbaP/at7/LqzbbIrM4PUVR1fV/HS40itxUGDAFMITkn6yB6q2Ay/UwuCZnBInCSu4rD0NHYVGtKLeXZXJoM8VyuP9Y9jnMwIeaG67BRj0RCRQ+/+6A4r3NBIPQ2hl5q4= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;DM2PR12MB0153;20:K55M54DjhwiamlmHs1UJbqMj2ZbAny84EOMQASw+2leMojWcIvasv5YwdtfbMUmUT5uN3f2h3KxJ/b0Ew21zJZVci18DVtypHvnQk5azhiN/KFyNkL1zyzIOINnIXkFCY0sDKAzWijfz0sOucYBhlfiJveKEOjGvFciSv2ELzBixdslno0HPSLwbjSfrKo1VUDWMpDlBOzGxm0mDRTbaHAt6gT/JNF85ik634Kjp9LdA3DG+7sqdK+FYA0j02lL3 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Oct 2017 20:05:24.1995 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM2PR12MB0153 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/12/17 1:21 PM, Borislav Petkov wrote: ..... > Btw, that function returns 0 unconditionally. So you can make it return > void and... Will do >> + if (ret) >> + goto unlock; > ... remove this check and initialize ret to 0 at the beginning. > Will do