mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Enrico Weigelt, metux IT consult" <lkml@metux.net>
To: Sven Van Asbroeck <thesven73@gmail.com>
Cc: "Rob Herring" <robh+dt@kernel.org>,
	"Linus Walleij" <linus.walleij@linaro.org>,
	"Lee Jones" <lee.jones@linaro.org>,
	mark.rutland@arm.com, "Andreas Färber" <afaerber@suse.de>,
	treding@nvidia.com, "David Lechner" <david@lechnology.com>,
	noralf@tronnes.org, johan@kernel.org,
	"Michal Simek" <monstr@monstr.eu>,
	michal.vokac@ysoft.com, "Arnd Bergmann" <arnd@arndb.de>,
	"Greg KH" <gregkh@linuxfoundation.org>,
	john.garry@huawei.com, geert+renesas@glider.be,
	robin.murphy@arm.com,
	"Paul Gortmaker" <paul.gortmaker@windriver.com>,
	sebastien.bourdelin@savoirfairelinux.com, icenowy@aosc.io,
	"Stuart Yoder" <stuyoder@gmail.com>,
	"J. Kiszka" <jan.kiszka@siemens.com>,
	maxime.ripard@bootlin.com,
	"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
	netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH v11 3/7] anybus-s: support the Arcx anybus controller
Date: Tue, 16 Apr 2019 23:05:40 +0200	[thread overview]
Message-ID: <bd36b798-d129-c81a-ab2d-22a5b46567f6@metux.net> (raw)
In-Reply-To: <CAGngYiXZSaUwrCiqavMGDRb5Vuo2x8fTjDetT00PAjjtrYW+NA@mail.gmail.com>

On 16.04.19 20:35, Sven Van Asbroeck wrote:

Hi,

> The "CAN stuff" is just a binary power read-out, routed from an external CAN
> card, which may or may not be present. The CAN card is not accessed from
> within this driver. This situation arises because our h/w developer team
> decided to integrate various unrelated pieces of functionality into the
> same hardware card (even into the same 8-bit register).

BRRR!

> This arcx-anybus controller card has two unrelated pieces of functionality:
> 1. implements an anybus-s slot
> 2. implements a power read-out from an external CAN card

So, it's an mfd (multi function device) ... hmm.

By the grey theory it would be better to split it into two separate
drivers. But obviously, they need need a common part (a third piece).

Does it ever make sense to only use one of two functionalities ?

Does this power read-out involve some CAN traffic, or is it just
fetching from some card that just happens to be some CAN interface ?
(IOW: is cansocket needed for that ?)


--mtx

-- 
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
info@metux.net -- +49-151-27565287

  reply	other threads:[~2019-04-16 21:07 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-16 15:56 [PATCH v11 0/7] Add Fieldbus subsystem + support HMS Profinet card Sven Van Asbroeck
2019-04-16 15:56 ` [PATCH v11 1/7] fieldbus_dev: add Fieldbus Device subsystem Sven Van Asbroeck
2019-04-16 15:56 ` [PATCH v11 2/7] anybus-s: support HMS Anybus-S bus Sven Van Asbroeck
2019-04-16 17:06   ` Enrico Weigelt, metux IT consult
2019-04-16 18:43     ` Sven Van Asbroeck
2019-04-16 20:58       ` Enrico Weigelt, metux IT consult
2019-04-16 22:00         ` Sven Van Asbroeck
2019-04-17 15:25           ` Enrico Weigelt, metux IT consult
2019-04-18 17:44             ` Sven Van Asbroeck
2019-04-24 10:25               ` Enrico Weigelt, metux IT consult
2019-04-24 13:58                 ` Sven Van Asbroeck
2019-04-16 15:56 ` [PATCH v11 3/7] anybus-s: support the Arcx anybus controller Sven Van Asbroeck
2019-04-16 17:27   ` Enrico Weigelt, metux IT consult
2019-04-16 18:35     ` Sven Van Asbroeck
2019-04-16 21:05       ` Enrico Weigelt, metux IT consult [this message]
2019-04-16 21:23         ` Sven Van Asbroeck
2019-04-17  8:39           ` Enrico Weigelt, metux IT consult
2019-04-17 14:17             ` Sven Van Asbroeck
2019-04-18  8:15               ` Enrico Weigelt, metux IT consult
2019-04-18  8:18               ` Enrico Weigelt, metux IT consult
2019-04-18 13:18                 ` Sven Van Asbroeck
2019-04-16 15:56 ` [PATCH v11 4/7] dt-bindings: anybus-controller: document devicetree binding Sven Van Asbroeck
2019-04-16 15:56 ` [PATCH v11 5/7] dt-bindings: Add vendor prefix for arcx / Archronix Sven Van Asbroeck
2019-04-16 15:56 ` [PATCH v11 6/7] fieldbus_dev: support HMS Profinet IRT industrial controller Sven Van Asbroeck
2019-04-16 15:56 ` [PATCH v11 7/7] staging: fieldbus_dev: add TODO Sven Van Asbroeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bd36b798-d129-c81a-ab2d-22a5b46567f6@metux.net \
    --to=lkml@metux.net \
    --cc=afaerber@suse.de \
    --cc=arnd@arndb.de \
    --cc=david@lechnology.com \
    --cc=geert+renesas@glider.be \
    --cc=gregkh@linuxfoundation.org \
    --cc=icenowy@aosc.io \
    --cc=jan.kiszka@siemens.com \
    --cc=johan@kernel.org \
    --cc=john.garry@huawei.com \
    --cc=lee.jones@linaro.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=maxime.ripard@bootlin.com \
    --cc=michal.vokac@ysoft.com \
    --cc=monstr@monstr.eu \
    --cc=netdev@vger.kernel.org \
    --cc=noralf@tronnes.org \
    --cc=paul.gortmaker@windriver.com \
    --cc=robh+dt@kernel.org \
    --cc=robin.murphy@arm.com \
    --cc=sebastien.bourdelin@savoirfairelinux.com \
    --cc=stuyoder@gmail.com \
    --cc=thesven73@gmail.com \
    --cc=treding@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®