From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21B5FC4332F for ; Thu, 9 Nov 2023 17:59:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344886AbjKIR7k convert rfc822-to-8bit (ORCPT ); Thu, 9 Nov 2023 12:59:40 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58134 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231478AbjKIR7i (ORCPT ); Thu, 9 Nov 2023 12:59:38 -0500 Received: from eu-smtp-delivery-151.mimecast.com (eu-smtp-delivery-151.mimecast.com [185.58.86.151]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C0AE83AA5 for ; Thu, 9 Nov 2023 09:59:35 -0800 (PST) Received: from AcuMS.aculab.com (156.67.243.121 [156.67.243.121]) by relay.mimecast.com with ESMTP with both STARTTLS and AUTH (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id uk-mta-33-bLC80emNPv-UQE7EuSLIUQ-1; Thu, 09 Nov 2023 17:59:32 +0000 X-MC-Unique: bLC80emNPv-UQE7EuSLIUQ-1 Received: from AcuMS.Aculab.com (10.202.163.4) by AcuMS.aculab.com (10.202.163.4) with Microsoft SMTP Server (TLS) id 15.0.1497.48; Thu, 9 Nov 2023 17:59:24 +0000 Received: from AcuMS.Aculab.com ([::1]) by AcuMS.aculab.com ([::1]) with mapi id 15.00.1497.048; Thu, 9 Nov 2023 17:59:24 +0000 From: David Laight To: 'Viacheslav Bocharov' , Neil Armstrong , Jerome Brunet , "Kevin Hilman" , Martin Blumenstingl , "linux-amlogic@lists.infradead.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" Subject: RE: [PATCH] firmware: meson-sm: change sprintf to scnprintf Thread-Topic: [PATCH] firmware: meson-sm: change sprintf to scnprintf Thread-Index: AQHaEunNN2AngpIfEUOhTXwrGwSTX7ByRpLw Date: Thu, 9 Nov 2023 17:59:24 +0000 Message-ID: References: <20231109085029.2079176-1-adeep@lexina.in> In-Reply-To: <20231109085029.2079176-1-adeep@lexina.in> Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.202.205.107] MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: aculab.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Viacheslav Bocharov > Sent: 09 November 2023 08:50 > > Update sprintf in serial_show frunction to scnprintf command to > prevent sysfs buffer overflow (buffer always is PAGE_SIZE bytes). Isn't the correct function sysfs_emit() ? In any case that particular example can't possibly overflow. David > > Signed-off-by: Viacheslav Bocharov > --- > drivers/firmware/meson/meson_sm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/firmware/meson/meson_sm.c b/drivers/firmware/meson/meson_sm.c > index ed60f1103053..c1c694b485ee 100644 > --- a/drivers/firmware/meson/meson_sm.c > +++ b/drivers/firmware/meson/meson_sm.c > @@ -265,7 +265,7 @@ static ssize_t serial_show(struct device *dev, struct device_attribute *attr, > return ret; > } > > - ret = sprintf(buf, "%12phN\n", &id_buf[SM_CHIP_ID_OFFSET]); > + ret = scnprintf(buf, PAGE_SIZE, "%12phN\n", &id_buf[SM_CHIP_ID_OFFSET]); > > kfree(id_buf); > > -- > 2.34.1 - Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK Registration No: 1397386 (Wales)