From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04FBFC3A59F for ; Mon, 26 Aug 2019 14:17:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CC3A121852 for ; Mon, 26 Aug 2019 14:17:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732368AbfHZORa (ORCPT ); Mon, 26 Aug 2019 10:17:30 -0400 Received: from out30-42.freemail.mail.aliyun.com ([115.124.30.42]:50628 "EHLO out30-42.freemail.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729138AbfHZORa (ORCPT ); Mon, 26 Aug 2019 10:17:30 -0400 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R131e4;CH=green;DM=||false|;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e07417;MF=alex.shi@linux.alibaba.com;NM=1;PH=DS;RN=11;SR=0;TI=SMTPD_---0TaX0VPG_1566829040; Received: from IT-FVFX43SYHV2H.local(mailfrom:alex.shi@linux.alibaba.com fp:SMTPD_---0TaX0VPG_1566829040) by smtp.aliyun-inc.com(127.0.0.1); Mon, 26 Aug 2019 22:17:23 +0800 Subject: Re: [PATCH 03/14] lru/memcg: using per lruvec lock in un/lock_page_lru To: Konstantin Khlebnikov , cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andrew Morton , Mel Gorman , Tejun Heo Cc: Johannes Weiner , Michal Hocko , Vladimir Davydov , Hugh Dickins References: <1566294517-86418-1-git-send-email-alex.shi@linux.alibaba.com> <1566294517-86418-4-git-send-email-alex.shi@linux.alibaba.com> <936eb865-d8da-8e53-3e2b-6858c586aa49@yandex-team.ru> From: Alex Shi Message-ID: Date: Mon, 26 Aug 2019 22:16:58 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <936eb865-d8da-8e53-3e2b-6858c586aa49@yandex-team.ru> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 在 2019/8/26 下午4:30, Konstantin Khlebnikov 写道: >> >>   > > What protects lruvec from freeing at this point? > After reading resolving lruvec page could be moved and cgroup deleted. > > In this old patches I've used RCU for that: https://lkml.org/lkml/2012/2/20/276 > Pointer to lruvec should be resolved under disabled irq. > Not sure this works these days. Thanks for reminder! I will reconsider this point and come up with changes. Thanks Alex