From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7FC00423EA1 for ; Thu, 16 Jul 2026 13:21:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784208130; cv=none; b=cY0ZJPjhgeiRXJ5+kiXCFcBG1BdkGD4Zip85zgwRgNS9nbjwy5N0Tj5bChw38erTN3XoYFjLifSoXnyIE/nSAdoMBxLZ4NTqMK3JKYDS5TkXqzdG6n+FsQskJFKGouTVsI9ey7eCKEGQf00P/ojBiHZahcSTX8hgDgsZLGQVz8M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784208130; c=relaxed/simple; bh=ZSTIBwU9mElCm+RjDc/TUhXiFwYyDqgmP5WvMxHUR5c=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=McJdBjxUy1SDyg2B8y3YXO9P3BLSJIZ6f37ytsCBB4BqcOCMgE9TiAl/ikoOOqM3KBwupaXjOa3H8R6cRRIw8AlRF7ozNLl+D5DmVtNqJuU0EwKDSQ9zCwnMqi6bcHFl+bQ3NYUQgNsljiHpeQydQGH5OeX9Ldv9kHL49GyZvTU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=EP5nlmqv; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="EP5nlmqv" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B91671F000E9; Thu, 16 Jul 2026 13:21:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1784208118; bh=C4ER0ARPZVqrIt9/HEi4s0ywOJQD5VxpjcYpqQLDuD8=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=EP5nlmqvYqmgjIUmzbo/Jqeuw9KrIKm17s8DXd3gEQ75mUqG3s4gUX3lzlsSVbIJk dy5Xg92dMwdTgmzSZo3dng7MAVF3yo4CJGNC2uwsbdTu7P3C8mJsy8aH4jvVlqlr3P GOdPigKbi/S0iiZR/nE3WyCLuNQQcmhvnNiFKpnqthP+DMaAX6+Tf9RXuXnzLFQH96 RTH/mKgOFJUPT6IYqTuB+z8Y3xBshGBpMTNLH7G1A8wvaqKL0WG9dfBUaI5170D0Uy XBq4n/b4zG3rdrZ52umF6i3sHRplTKlodw35PZa/jtsPmfoywuMwCYF4jDx8gPOSMr eHSeqONjox0fw== Message-ID: Date: Thu, 16 Jul 2026 08:21:56 -0500 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] drm/radeon: Only define radeon_acpi_vfct_match when actually used Content-Language: en-US To: =?UTF-8?Q?Uwe_Kleine-K=C3=B6nig?= , Alex Deucher , =?UTF-8?Q?Christian_K=C3=B6nig?= Cc: David Airlie , Simona Vetter , amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20260716123646.1933293-2-u.kleine-koenig@baylibre.com> From: Mario Limonciello In-Reply-To: <20260716123646.1933293-2-u.kleine-koenig@baylibre.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 7/16/26 07:36, Uwe Kleine-König wrote: > This fixes the build failure > > drivers/gpu/drm/radeon/radeon_bios.c:614:12: error: ‘radeon_acpi_vfct_match’ defined but not used [-Werror=unused-function] > 614 | static int radeon_acpi_vfct_match(struct radeon_device *rdev, > | ^~~~~~~~~~~~~~~~~~~~~~ > > for builds with CONFIG_ACPI unset. > > Fixes: 33a18ecd2fbf ("drm/radeon: Fix VFCT bus number matching with soft filter") > Signed-off-by: Uwe Kleine-König Reviewed-by: Mario Limonciello (AMD) > --- > Hello, > > 33a18ecd2fbf is currently in next via > > https://gitlab.freedesktop.org/agd5f/linux.git drm-next > > . > > Best regards > Uwe > > drivers/gpu/drm/radeon/radeon_bios.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/radeon/radeon_bios.c b/drivers/gpu/drm/radeon/radeon_bios.c > index cc10880af096..cd7a5d458157 100644 > --- a/drivers/gpu/drm/radeon/radeon_bios.c > +++ b/drivers/gpu/drm/radeon/radeon_bios.c > @@ -596,6 +596,7 @@ static bool radeon_read_disabled_bios(struct radeon_device *rdev) > return legacy_read_disabled_bios(rdev); > } > > +#ifdef CONFIG_ACPI > /** > * radeon_acpi_vfct_match() - Check if a VFCT entry matches the device > * @rdev: Radeon device > @@ -635,7 +636,6 @@ static int radeon_acpi_vfct_match(struct radeon_device *rdev, > return 0; > } > > -#ifdef CONFIG_ACPI > static bool radeon_acpi_vfct_bios(struct radeon_device *rdev) > { > struct acpi_table_header *hdr; > > base-commit: 33a18ecd2fbf6bcbf803836e94eb31c26f4c7f41