From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4EA5AC4332F for ; Tue, 2 Nov 2021 09:55:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3871E60F24 for ; Tue, 2 Nov 2021 09:55:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230333AbhKBJ6K (ORCPT ); Tue, 2 Nov 2021 05:58:10 -0400 Received: from smtp-relay-internal-1.canonical.com ([185.125.188.123]:60886 "EHLO smtp-relay-internal-1.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229783AbhKBJ6I (ORCPT ); Tue, 2 Nov 2021 05:58:08 -0400 Received: from mail-lf1-f69.google.com (mail-lf1-f69.google.com [209.85.167.69]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id 586DD3F1AA for ; Tue, 2 Nov 2021 09:55:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1635846933; bh=D5VCGyo/EkhIr12Vj9NeHrXDS/X5WmXY/nUH6wa2pHA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=k3Ky9KO/zSa1FRGTloYoiBLCcEuAbxyeCmykdiTaRclL9sZhwH1x8GJA3nHlba8BQ WIsfGx7d3B2C+Rq1jDM5+apztbJkmCstyzdOEajFwEtW/h4bK/PSWJtE7rWbieHveb tKyxtisR2kU7u9d0IJMQppDKGZiewol/JsPj3V1VBPidHl7c5iU/YZVeAdQfVWF9Y4 jdfGRBFRZ3fitzEm8WmlwMD0zDkrBnpN8+e95pwfYzGS1Y1yFX+vPr9zCOr51qS2cD HBl6Ei82QXJUbCWtjylXVbSKTBrku9uIzANTPUnv8FC7Qi6tY4IFg4zEyQRV/MS3xK 97TskJ092ukMg== Received: by mail-lf1-f69.google.com with SMTP id c13-20020a05651200cd00b004001aab328aso1192314lfp.1 for ; Tue, 02 Nov 2021 02:55:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=D5VCGyo/EkhIr12Vj9NeHrXDS/X5WmXY/nUH6wa2pHA=; b=Y3ZoeoF/lBYJ8Rn193LVngvpAUohkzXXjF4imWA7Ff76Ara9kysh2ANpG1PWP8Fvi1 n7Tly4a8CHG3TDOSvM3xL7HeLOCoEwBQKx+xXX/enYmV6EDyUVUE1ixpfDk/J1HgeGVH oFCmQIZzypMNh4M/KFiumkodNA03nYilv0+OqZwo21cvL8X1lYfsZ80FObcEXAmdOsfH mBYuU468zRKMBNMcllwdVIelixNgIzZxHZ28PGr/n4YZMCV7bmewi2IRJMBV/+U5kjW+ 7I5UWFpC3lN0gPkYWkKS39K2P36GB8Oin1OyItIozPwwQqHpcJDfqSirHLmZx8kV9ur6 yvAg== X-Gm-Message-State: AOAM531s2AIrwRQ9V/4Rq7g9y9nW+C4eLR6K/T8gK0IzToKm0tk3puta kWX0YWZG/CQbOcnDBarvrMSkszxuQe0yfpkkSRW+7ptIaGwYd3AcZGcF4fykHv43+X69NGLUvIX XoSFzxYDiF+5yiU9wDx1g6ym9R/x07JxVKjpozh2kKQ== X-Received: by 2002:a2e:a789:: with SMTP id c9mr16370086ljf.207.1635846932475; Tue, 02 Nov 2021 02:55:32 -0700 (PDT) X-Google-Smtp-Source: ABdhPJykgYTwyNmlD0ClXvAZbn/Fd88xx1Po6qCMFLwUAPRSjJtbrNvKtBER1w8/MasJz6xZqJsHEw== X-Received: by 2002:a2e:a789:: with SMTP id c9mr16370065ljf.207.1635846932330; Tue, 02 Nov 2021 02:55:32 -0700 (PDT) Received: from [192.168.3.67] (89-77-68-124.dynamic.chello.pl. [89.77.68.124]) by smtp.gmail.com with ESMTPSA id v138sm1645009lfa.51.2021.11.02.02.55.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 02 Nov 2021 02:55:31 -0700 (PDT) Message-ID: Date: Tue, 2 Nov 2021 10:55:31 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.1.2 Subject: Re: [PATCH v2 06/12] watchdog: s3c2410: Extract disable and mask code into separate functions Content-Language: en-US To: Sam Protsenko , Wim Van Sebroeck , Guenter Roeck , Rob Herring Cc: linux-watchdog@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org References: <20211031122216.30212-1-semen.protsenko@linaro.org> <20211031122216.30212-7-semen.protsenko@linaro.org> From: Krzysztof Kozlowski In-Reply-To: <20211031122216.30212-7-semen.protsenko@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 31/10/2021 13:22, Sam Protsenko wrote: > The s3c2410wdt_mask_and_disable_reset() function content is bound to be > changed further. Prepare it for upcoming changes by splitting into > separate "mask reset" and "disable reset" functions. But keep > s3c2410wdt_mask_and_disable_reset() function present as a facade. > > This commit doesn't bring any functional change to existing devices, but > merely provides an infrastructure for upcoming chips support. > > Signed-off-by: Sam Protsenko > --- > Changes in v2: > - (none): it's a new patch > > drivers/watchdog/s3c2410_wdt.c | 54 ++++++++++++++++++++++------------ > 1 file changed, 35 insertions(+), 19 deletions(-) > Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof