From: Stephane Eranian <eranian@google.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: linux-kernel@vger.kernel.org, mingo@elte.hu, paulus@samba.org,
perfmon2-devel@lists.sourceforge.net, eranian@gmail.com
Subject: Re: [PATCH] perf_events: fix read() bogus counts when in error state
Date: Thu, 26 Nov 2009 18:48:43 +0100 [thread overview]
Message-ID: <bd4cb8900911260948j6fd743c1u26343073fd1abc46@mail.gmail.com> (raw)
In-Reply-To: <1259257016.31676.308.camel@laptop>
On Thu, Nov 26, 2009 at 6:36 PM, Peter Zijlstra <peterz@infradead.org> wrote:
> On Thu, 2009-11-26 at 09:24 -0800, Stephane Eranian wrote:
>> When a pinned group cannot be scheduled it goes into error state.
>> Normally a group cannot go out of error state without being explicitly
>> re-enabled or disabled. There was a bug in per-thread mode, whereby
>> upon termination of the thread, the group would transition from error
>> to off leading to bogus counts and timing information returned by
>> read().
>
>> Signed-off-by: Stephane Eranian <eranian@google.com>
>
> Right, good catch, totally forgot about error state :/
>
You need to clarify what pin actually means for per-thread
and I'd like to see an explanation for what happens when
sampling.
next prev parent reply other threads:[~2009-11-26 17:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-26 17:24 Stephane Eranian
2009-11-26 17:36 ` Peter Zijlstra
2009-11-26 17:48 ` Stephane Eranian [this message]
2009-11-26 17:51 ` [tip:perf/core] perf_events: Fix " tip-bot for Stephane Eranian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bd4cb8900911260948j6fd743c1u26343073fd1abc46@mail.gmail.com \
--to=eranian@google.com \
--cc=eranian@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=paulus@samba.org \
--cc=perfmon2-devel@lists.sourceforge.net \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®