From: Stephane Eranian <eranian@google.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: linux-kernel@vger.kernel.org, mingo@elte.hu, paulus@samba.org,
davem@davemloft.net, fweisbec@gmail.com, robert.richter@amd.com,
perfmon2-devel@lists.sf.net, eranian@gmail.com
Subject: Re: [PATCH] perf_events: fix ordering bug in perf_output_sample()
Date: Thu, 18 Mar 2010 22:29:04 +0100 [thread overview]
Message-ID: <bd4cb8901003181429j235ac282pe0440f02b9138015@mail.gmail.com> (raw)
In-Reply-To: <1268937194.9440.373.camel@laptop>
On Thu, Mar 18, 2010 at 7:33 PM, Peter Zijlstra <peterz@infradead.org> wrote:
> On Thu, 2010-03-18 at 14:42 +0200, Stephane Eranian wrote:
>> In order to parse a sample correctly based on the information
>> requested via sample_type, the kernel needs to save each component
>> in a known order. There is no type value saved with each component.
>> The current convention is that each component is saved according to
>> the order in enum perf_event_sample_format. But perf_output_sample()
>> was not completely following this convention, thereby making samples
>> impossible to parse without internal kernel knowledge.
>>
>> This patch puts things in the right order.
>
> NAK, not so actually, its in the order specified in the
> PERF_RECORD_SAMPLE comment.
>
And why is that order different than the one in the enum?
next prev parent reply other threads:[~2010-03-18 21:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-18 12:42 Stephane Eranian
2010-03-18 18:33 ` Peter Zijlstra
2010-03-18 21:29 ` Stephane Eranian [this message]
2010-03-19 0:14 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bd4cb8901003181429j235ac282pe0440f02b9138015@mail.gmail.com \
--to=eranian@google.com \
--cc=davem@davemloft.net \
--cc=eranian@gmail.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=paulus@samba.org \
--cc=perfmon2-devel@lists.sf.net \
--cc=peterz@infradead.org \
--cc=robert.richter@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®