From: Enric Balletbo i Serra <enric.balletbo@collabora.com>
To: kbuild test robot <lkp@intel.com>,
Tim Wawrzynczak <twawrzynczak@chromium.org>
Cc: kbuild-all@01.org, Benson Leung <bleung@chromium.org>,
Guenter Roeck <groeck@chromium.org>,
linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH chrome-platform-linux] platform/chrome: cros_ec_debugfs: cros_ec_uptime_fops can be static
Date: Tue, 18 Jun 2019 10:35:39 +0200 [thread overview]
Message-ID: <bd518a39-8aa4-d22f-0fad-6cd24697b218@collabora.com> (raw)
In-Reply-To: <20190615105512.GA152427@lkp-kbuild11>
On 15/6/19 12:55, kbuild test robot wrote:
>
> Fixes: 909447f683b3 ("platform/chrome: cros_ec_debugfs: Add debugfs entry to retrieve EC uptime")
> Signed-off-by: kbuild test robot <lkp@intel.com>
> ---
> cros_ec_debugfs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/platform/chrome/cros_ec_debugfs.c b/drivers/platform/chrome/cros_ec_debugfs.c
> index 970ba13d..d40902e 100644
> --- a/drivers/platform/chrome/cros_ec_debugfs.c
> +++ b/drivers/platform/chrome/cros_ec_debugfs.c
> @@ -285,7 +285,7 @@ static const struct file_operations cros_ec_pdinfo_fops = {
> .llseek = default_llseek,
> };
>
> -const struct file_operations cros_ec_uptime_fops = {
> +static const struct file_operations cros_ec_uptime_fops = {
> .owner = THIS_MODULE,
> .open = simple_open,
> .read = cros_ec_uptime_read,
>
applied for chrome-platform-5.3
prev parent reply other threads:[~2019-06-18 8:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-15 10:55 [chrome-platform-linux:for-next 14/16] drivers/platform/chrome/cros_ec_debugfs.c:288:30: sparse: sparse: symbol 'cros_ec_uptime_fops' was not declared. Should it be static? kbuild test robot
2019-06-15 10:55 ` [RFC PATCH chrome-platform-linux] platform/chrome: cros_ec_debugfs: cros_ec_uptime_fops can be static kbuild test robot
2019-06-18 8:35 ` Enric Balletbo i Serra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bd518a39-8aa4-d22f-0fad-6cd24697b218@collabora.com \
--to=enric.balletbo@collabora.com \
--cc=bleung@chromium.org \
--cc=groeck@chromium.org \
--cc=kbuild-all@01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=twawrzynczak@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®