From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f45.google.com (mail-ej1-f45.google.com [209.85.218.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 73BC323BCF3 for ; Tue, 3 Jun 2025 15:25:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748964336; cv=none; b=WYDfyvXIcS0PGmSCOBuD79VCsTIQGdrrrEfq18fBHg6d3S2Lzdic1wjSGTtcJo9RYzzCKICdS62bb8iYWRWCtRSduh8/m6bDhfyFRprqnMpqjcjCz3GIaKYzAvBbCx8QTktaUMCtR3YxijbTPsEYiQe+26H6u9W0iemNDdmGIY0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748964336; c=relaxed/simple; bh=GRF3f1LYqvxYkJuZ98Z2f/j5mjNLlD7tN5Zlj+pTDSs=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ZN2ztAZduhYgZR25cJIo2VZf/WrlrEPk8lP9O4NYhYZZJsFhTtGmzg7AGYV7uraPxx9Ez/tuZH8esrFd5CLW63V4yRMfnsEnNWGvyCrRjZUKi/ZYghEY/RWivNeMZvysUJbbzNDxnHyj1XjAS2Xmh5yhi+b7fSiIvFA8fuUy6n0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=IXc9I7UM; arc=none smtp.client-ip=209.85.218.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="IXc9I7UM" Received: by mail-ej1-f45.google.com with SMTP id a640c23a62f3a-ad55d6aeb07so896221066b.0 for ; Tue, 03 Jun 2025 08:25:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1748964333; x=1749569133; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=5wW03XFrUSVeu8mwtKJy+rZxza/kHZKA3kHeUE/Zbf4=; b=IXc9I7UMGwULlXle4M1pHakGg2RCwwWylEH3t2tt6wqaKqt+LTEO6cm8+TTTM2dmtm lnaF6EjQqG8MVKlVcF5pJEJ0kbkkxkWi+TOVG4zweb390Zrvi/u3B7tapRJxBdEzF0yD HeprDxYaYMjwtRtY5j5Fqtb4eHTM7hmjrRGamIasjzTzIl0X69n/quNKWYMCqAhVrPAA bY7CGAB0FB/lH8dpAnfoBnuYlzSByVgv111+cMhK0XEmCQk56olnzPpNi5PO1heyQbDq 2J9AM8FQ+C81jRkePJEYo6Ex/1e0izqLO9IE391WnM/p7WElcOfA9/qtNbXrITmcmRwt dBNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748964333; x=1749569133; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=5wW03XFrUSVeu8mwtKJy+rZxza/kHZKA3kHeUE/Zbf4=; b=am6syuNqxUlpcK+7+B1lKsOkj6TbKCltREJn4naJPDFo8VKRLhglPB0UzaJoHUSFp+ R5JWXNaf5s0pAg6V4OPmztH9noTFmqOa0AT2kgNCb5qfPO+HJt6lAmZqcbUi0xEE9DdD 5BuMiWVq0QnnMKFwBaF4XnbyBmiKkkAhymFhRUSC6qE3meRaBjCJ59B34f5XyaMGGc/b t7SvDizh8WCVQD+R8M2ocyXMovjFJ6q3RPmNwQNP8rhn7KoLbeCPUA2gbsrcE6jCpl4U ObnGdegZmIFUJii2OpX961o7SzAR2qq3EkA4N76Ha8er/VdLkwAIu7RmWN1vP4JFj+RZ mJ7g== X-Forwarded-Encrypted: i=1; AJvYcCUCn2I8MK1F3WsKxSPnpAP9+c2anzEzRxiOnXj8S+Mj7gUwys00lxfWvcbf6H7utUTuSsJJLhDzxo5HzZY=@vger.kernel.org X-Gm-Message-State: AOJu0Yym+qUPx9dD6XQrpQDWs2IWtnrvK6Ve4c65ronPRBckmqcqzIb8 j9HKnN7b8uWJoxukH5T9xS+RuZ8tzAKaP7bABjwLKzQoXSXBcHp1ZfKhs5rUSbDqFqo= X-Gm-Gg: ASbGncuW3Xy9HwiIPpZ/iQOjwynTD8L1Vjj9kl3PWhVyP4MKa3l9fWfJ7575WqNGFKs l8Ct+TlC3jeAA4x+H8PmhHbpbfBrAulhi2K/vjkbMc7BVpBuCVKXv58isxzdtEYX8UtytHz3dF/ ihdiGson8mcldLGLOxEkD5QhXrWLEZzdmKNSh9/SHoFiKl+BTuW7nbYHTlSGohOo3Tf2cSAZ+Kl dMFEEPDFZAlUEMc9tvkppe6AvQGxSF2HS95mwa08NZ9p2DqM6A/SaWzdQIwqbAFrfQd2mUV21CQ AQIy3OjRMzh2ga+9hGV5Kadbaw4I6V7N/huc1fkXWlg+JsvaVfGHMhIeaTG1 X-Google-Smtp-Source: AGHT+IENJ5hA+onG71OWUo/WB8VWtaRrN2gxUzJbh00nrZECX8zCpqavdRYFahZC7MMqM6VHbK/Bgw== X-Received: by 2002:a17:906:f58c:b0:ad8:9041:7706 with SMTP id a640c23a62f3a-adb36c18b0emr1655179266b.56.1748964332581; Tue, 03 Jun 2025 08:25:32 -0700 (PDT) Received: from [192.168.0.14] ([79.115.63.247]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-added7edf9asm51930166b.152.2025.06.03.08.25.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 03 Jun 2025 08:25:31 -0700 (PDT) Message-ID: Date: Tue, 3 Jun 2025 16:25:30 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 24/25] PCI: Perform reset_resource() and build fail list in sync To: =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= Cc: Bjorn Helgaas , linux-pci@vger.kernel.org, =?UTF-8?Q?Micha=C5=82_Winiarski?= , Igor Mammedov , LKML , Mika Westerberg , William McVicker References: <20241216175632.4175-1-ilpo.jarvinen@linux.intel.com> <20241216175632.4175-25-ilpo.jarvinen@linux.intel.com> <5f103643-5e1c-43c6-b8fe-9617d3b5447c@linaro.org> <8f281667-b4ef-9385-868f-93893b9d6611@linux.intel.com> <3a47fc82-dc21-46c3-873d-68e713304af3@linaro.org> <867e47dc-9454-c00f-6d80-9718e5705480@linux.intel.com> <7e882cfb-a35a-bab0-c333-76a4e79243b6@linux.intel.com> <19ccc09c-1d6b-930e-6ed6-398b34020ca1@linux.intel.com> Content-Language: en-US From: Tudor Ambarus In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 6/3/25 3:13 PM, Ilpo Järvinen wrote: > On Tue, 3 Jun 2025, Tudor Ambarus wrote: >> On 6/3/25 9:13 AM, Ilpo Järvinen wrote: >>> So please test if this patch solves your problem: >> >> It fails in a different way, the bridge window resource never gets >> assigned with the proposed patch. > > Is that a failure? I was expecting that to occur. It didn't assign > any resources into that bridge window. It leads to a watchdog interrupt on my pixel6. Last print I see on my console is related to the modem booting status. My wild guess is that that modem accesses something from the unassigned bridge window. In the working case I see the bridge window printed: [ 15.457310][ T1083] pcieport 0000:00:00.0: [s51xx_pcie_probe] BAR 14: tmp rsc : [mem 0x40000000-0x401fffff] [ 15.457683][ T1083] cpif: s51xx_pcie_probe: Set Doorbell register address. In the failing case I see: [ 15.623270][ T1113] pcieport 0000:00:00.0: [s51xx_pcie_probe] BAR 14: tmp rsc : [??? 0x00000000 flags 0x0] [ 15.623638][ T1113] cpif: s51xx_pcie_probe: Set Doorbell register address. > > If there's nothing to be assigned into the bridge window, the bridge > window itself is not created, that is the expected behavior (working as > designed). So you're comparing to the bridge window that was made too > large due to the disparity (and left unused, AFAICT). > > It would be possible to put the condition inside the block which adds > the resource to the realloc_head, I initially put it there but then > decided to remove the disparity completely because why keep it if no > resource is going to be placed into the bridge window. > Thanks for the educative answers. > What's that class 0 device anyway? Why it has class 0? > I don't know yet, it's the first time I'm dealing with a PCI driver. Any idea where is the class typically assigned? >> With the patch applied: https://termbin.com/h3w0 >> With the blamed commit reverted: https://termbin.com/3rh6 >