From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-03.galae.net (smtpout-03.galae.net [185.246.85.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D2923326938 for ; Wed, 8 Apr 2026 16:17:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.246.85.4 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775665054; cv=none; b=f1tJKigickZdD6aGZHwoENRM8/jDEgVO/UrqBhAwxzxuGyDF7RRMvuUt9EBZJvVXjrH9V2ZbPmpllzPGQTjDp9LghzpxKsIAQHWmbRbmP7HmfrFKxYo3oqlevCdkjSzU2tfNRpP/rPrILRfpHbG10miORhqN9Zj+qrrm6Js+vPU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775665054; c=relaxed/simple; bh=4A0tIwDD9VHgCy7Bk1wUfoUS7YjldjWZiQz5d1R8gEk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=fdGDLNIgQG3J0QQV18bNOmilgRQTyc+sfJHG0nXPMnxrHESmY4clt/UEklMzHsKr3lLfJG4o58A34PX69wk7QOTib7kiqGlDT16LyIHToZXQ9PUvNr/+fpCTH8repFTyEDKNnv4q/6pL9LiOfR0WgNugWs4jtDL40X81zrkIJRs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=BIq1oqTf; arc=none smtp.client-ip=185.246.85.4 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="BIq1oqTf" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-03.galae.net (Postfix) with ESMTPS id 8ABEC4E42965; Wed, 8 Apr 2026 16:17:31 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 57C3C603CE; Wed, 8 Apr 2026 16:17:31 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 3EA6910450154; Wed, 8 Apr 2026 18:17:27 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1775665050; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:content-language:in-reply-to:references; bh=sW7PfS/oGOQ7K0BGI9Bt1TIPXOxXhcJbY+thwE8WW+g=; b=BIq1oqTfqfW6AV6UWeme3jl+n9hN744rsHzRQCGMeshPn+VoDrOOPblFhtOjxu5WgCDfr6 PKEGzY8QPUG/LmPsvKpnDPVI97jfnGYLmFrSlogdV3v0Suax/HJIUaoW9BWwQFS6GKAcOX 0qW8rycPgQGQTZE+6RsCbq2l8Sax/Xi70S7+xyjsorrfNfInSStzLrunwiwgkuBG9QSmob 1eOsMKn8bplGk20ZTo5+7AutuhBGL+wciUCPWckqeMndhNTmla0rVmjnFoHCHsemUQ0QHq 1Mz5tcUfE2UiKvD+VK/2qvWbnv660f0uq/VdqVyk+QWArwAmvZOp8CkHJRem7A== Message-ID: Date: Wed, 8 Apr 2026 18:18:07 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] drm/arcpgu: fix device node leak To: Luca Ceresoli , Simona Vetter , Alexey Brodkin , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter Cc: Hui Pu , Thomas Petazzoni , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Ian Ray , stable@vger.kernel.org References: <20260402-drm-arcgpu-fix-device-node-leak-v2-1-d773cf754ae5@bootlin.com> From: Louis Chauvet Content-Language: en-US In-Reply-To: <20260402-drm-arcgpu-fix-device-node-leak-v2-1-d773cf754ae5@bootlin.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Last-TLS-Session-Version: TLSv1.3 On 4/2/26 18:42, Luca Ceresoli wrote: > This function gets a device_node reference via > of_graph_get_remote_port_parent() and stores it in encoder_node, but never > puts that reference. Add it. > > There used to be a of_node_put(encoder_node) but it has been removed by > mistake during a rework in commit 3ea66a794fdc ("drm/arc: Inline > arcpgu_drm_hdmi_init"). > > Fixes: 3ea66a794fdc ("drm/arc: Inline arcpgu_drm_hdmi_init") > Cc: stable@vger.kernel.org > Signed-off-by: Luca Ceresoli Reviewed-by: Louis Chauvet > --- > Changes in v2: > - fix typos in commit message > --- > drivers/gpu/drm/tiny/arcpgu.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/tiny/arcpgu.c b/drivers/gpu/drm/tiny/arcpgu.c > index 505888497482..c93d61ac0bb7 100644 > --- a/drivers/gpu/drm/tiny/arcpgu.c > +++ b/drivers/gpu/drm/tiny/arcpgu.c > @@ -250,7 +250,8 @@ DEFINE_DRM_GEM_DMA_FOPS(arcpgu_drm_ops); > static int arcpgu_load(struct arcpgu_drm_private *arcpgu) > { > struct platform_device *pdev = to_platform_device(arcpgu->drm.dev); > - struct device_node *encoder_node = NULL, *endpoint_node = NULL; > + struct device_node *encoder_node __free(device_node) = NULL; > + struct device_node *endpoint_node = NULL; > struct drm_connector *connector = NULL; > struct drm_device *drm = &arcpgu->drm; > int ret; > > --- > base-commit: 4b9c36c83b34f710da9573291404f6a2246251c1 > change-id: 20251119-drm-arcgpu-fix-device-node-leak-f909bc1f7fbb > > Best regards, > -- > Luca Ceresoli >