From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07AD1C433ED for ; Tue, 20 Apr 2021 01:11:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C4D71613AB for ; Tue, 20 Apr 2021 01:11:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232912AbhDTBMF (ORCPT ); Mon, 19 Apr 2021 21:12:05 -0400 Received: from wout3-smtp.messagingengine.com ([64.147.123.19]:50401 "EHLO wout3-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229994AbhDTBME (ORCPT ); Mon, 19 Apr 2021 21:12:04 -0400 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id B779D33B5; Mon, 19 Apr 2021 21:11:33 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Mon, 19 Apr 2021 21:11:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=flygoat.com; h= subject:to:cc:references:from:message-id:date:mime-version :in-reply-to:content-type:content-transfer-encoding; s=fm2; bh=2 PZTex3av6DtVxv7nSM5bRbe2hR7e4Ewi7UMffg6+xs=; b=nhblEcEWTeS+NLG7W YfYdsSFnQx0UHRmnLbI/hHEsk8I7X/AMAhgwD3YbnUZcCl8v7t4Y062CyrChQ9jL 6yjBAZv1F/5sS5Qtq/Dn9OBuWacx4YQQh2pLjEnXiD8FrYO/wfxy8s06XXpNyD++ h6sugDvTiHdefjDP+C0/qE9HjSO0TPoZNM15Qd7nGCodzGI/FBvPAc4ghpQSbF2z O3lEQ5pCsAkxbGd1BIERd7N1lheyQp/8O3tBQACTNfgKPbe8HvE5B9M9SEN0KRqZ zZU+7dTTsQbOvjffSnrDDPNEG8Pv3Lnq6VDoW7YHmpuSI1cbTyMdndqX7j1jtCET q1yJA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=2PZTex3av6DtVxv7nSM5bRbe2hR7e4Ewi7UMffg6+ xs=; b=DB7mRFgPTttzJ2lt+ny2qbBt14ULHDVitD40RV6utjMhb5GAgteC9QwdU lt1Ls93IF3Mcw2YFw75PfdCUiOVKNK0WnGKVsuP9ktYZUmz5hYLOhogtKT1IB18C w/5BCeWOV65oRYM9Lv0GQBn/vUEaSk3/kBBOU86V4NW/7Vf2JCoCmtYXuroFbe3z qSxrQZOqNK/N2TlL0S5lQ98k1mKDzvNP93Pw5CiIPXG7t6yDC4MHbo7xXz/37y43 5iW7oZ6UtlL7rnlm+cb5R4gLBPWDyMr30/Y1Th2m+yHk2tQcI/CXhc6dlb0tkpiO sMGc40Qa7ZtNSMbAlNdz5NBYOduZg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrvddthedggeefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepuffvfhfhkffffgggjggtgfesthekredttdeftfenucfhrhhomheplfhirgig uhhnucgjrghnghcuoehjihgrgihunhdrhigrnhhgsehflhihghhorghtrdgtohhmqeenuc ggtffrrghtthgvrhhnpeefleduiedtvdekffeggfeukeejgeeffeetlefghfekffeuteei jeeghefhueffvdenucfkphepudduiedrvddvgedrvdegjedrgedunecuvehluhhsthgvrh fuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepjhhirgiguhhnrdihrghnghes fhhlhihgohgrthdrtghomh X-ME-Proxy: Received: from [10.20.195.140] (unknown [116.224.247.41]) by mail.messagingengine.com (Postfix) with ESMTPA id B3426240054; Mon, 19 Apr 2021 21:11:29 -0400 (EDT) Subject: Re: [PATCH] mips: kdump: Crash kernel should be able to see old memories To: Youling Tang , Thomas Bogendoerfer Cc: linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, Huacai Chen References: <1618829807-12522-1-git-send-email-tangyouling@loongson.cn> From: Jiaxun Yang Message-ID: Date: Tue, 20 Apr 2021 09:11:26 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.1 MIME-Version: 1.0 In-Reply-To: <1618829807-12522-1-git-send-email-tangyouling@loongson.cn> Content-Type: text/plain; charset=gbk; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org ÔÚ 2021/4/19 18:56, Youling Tang дµÀ: > From: Huacai Chen > > kexec-tools use mem=X@Y to pass usable memories to crash kernel, but in > commit a94e4f24ec836c8984f83959 ("MIPS: init: Drop boot_mem_map") all > BIOS passed memories are removed by early_parse_mem(). I think this is > reasonable for a normal kernel but not for a crash kernel, because a > crash kernel should be able to see all old memories, even though it is > not supposed to use them. > > Fixes: a94e4f24ec836c8984f83959 ("MIPS: init: Drop boot_mem_map") > Signed-off-by: Huacai Chen > Signed-off-by: Youling Tang > --- > arch/mips/kernel/setup.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/mips/kernel/setup.c b/arch/mips/kernel/setup.c > index b86e241..ac90d3b 100644 > --- a/arch/mips/kernel/setup.c > +++ b/arch/mips/kernel/setup.c > @@ -351,8 +351,10 @@ static int __init early_parse_mem(char *p) > */ > if (usermem == 0) { > usermem = 1; > +#ifndef CONFIG_CRASH_DUMP Why depend on a config instead of a runtime variable? Btw as you are fixing my commit please keep me CCed. Thanks. - Jiaxun