From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 33DB03A9D84 for ; Mon, 10 Aug 2026 09:37:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786354644; cv=none; b=hkpDvDCDpCSmSb5TgjEArJuDMFGFQIeHQYz9PYlG73wV8NPXIG0YkFkzWnvnNqLlIo3Zv6H/B5dhuxcjMWk1TbdBwBVeL2l7753aXzqo2LOd7rpM4CyekDzPHrC2xcfBfnX3ktsDBEgeD/XashwAZUi8AqkcP8kGEd1GtEgGNtw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786354644; c=relaxed/simple; bh=eiTiybaGSljMIosr/1jpdKcCiVMQjswADkPpQUGix+8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=UHdA9WqahQ8gsP0ZCPD90gSlB4jDjtck2XmB0MUgxQ5aBgXjE0teAHgKyyor11UXnXyxnkL4W8cbp/fApkZUNsuhBexjWdY8qhzpEBgr0OktpwK0/3pBBqmULdhg7PPOjnOeIPzYM+VT5oKExqQXSoBsQ3diMtrrmCQanW7NPWo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Fojhgnzf; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=DdUyZjSb; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Fojhgnzf"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="DdUyZjSb" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67A9SOlN1486567 for ; Mon, 10 Aug 2026 09:37:22 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Z5/9h6TwDFEnLhuVtmJol2cvjCYtLCULJ7w8r4LoK4M=; b=Fojhgnzfc2Cb7AbR NB0mRi6OjW4ePezuAGbnc4C0mv9B4p/dKHa6TdCRdplgSN13BjBn40bakQyH/Xr1 FycpwyV1BQbBNd+EUexLDQZjVzQ1ka35uomny6MF6IBZn2yNHyq4dZeSQsCr+n4V M+G3eZoVjtNWTQLU3x4U4ls3FXdM8hAfiInNjJiljxSIg8r57ETW077H5ettMKoc UaVD2j0Ekq6scA+Ne8Yhn7VWAVGKa0MG8O/p+X+ps0BR3qydCd6Vcr1bGqdHU38I tMF8ErBXNgTIMSnmQ3FxAZXxKeN49i4fpqa2q6kqwO1KCtI1b2izoExxCaKifORM GkR/6w== Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fy18xss3h-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 10 Aug 2026 09:37:21 +0000 (GMT) Received: by mail-pj1-f69.google.com with SMTP id 98e67ed59e1d1-38e8e864ef0so2695936a91.0 for ; Mon, 10 Aug 2026 02:37:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1786354641; x=1786959441; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to:content-type; bh=Z5/9h6TwDFEnLhuVtmJol2cvjCYtLCULJ7w8r4LoK4M=; b=DdUyZjSba0/gYUpOiTO5v2r5F/LNkVL6SsnRZBFcs7Rlc4iOlS27+ORyqIkVrAx0Wg MfXSrl54/uSmZBVowL5uFiQzW/vh4sSpE+QdsEAQVLV1qBUIVDkXhLIT/TKVTYQ12rYP FHArsv751Cq4Sy4trB6a0WRQhxIsLmuPE8rkufZhdLeA5xirLHOlv9WhpkYIh3YVrk0r mdCOoJQLZJ9vTBbOFpQKafrROywAkzzJLYD+abbC5SUnnhKr8Py+2689OFRkHpLiBHsP DCZcIkpA2EXYDIp4hnQt0BRlEyQrKuOFJiayjX7lsEbS0JKU7QndR4KqJXmcobDsyJJS rtiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786354641; x=1786959441; h=content-transfer-encoding:content-type:in-reply-to:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=Z5/9h6TwDFEnLhuVtmJol2cvjCYtLCULJ7w8r4LoK4M=; b=ZPgpJhQbr5XmfQe4RcIJDrVGjPWBAfBS4I+vUkygJf1hm0WsHqLk+cyjDHpWctu795 x/Tp6N+NCIBhoYbT6KcuuwUk8waEbBAHvR/g3RKnlhr/dZ9jUFe1uMr0d+QFC1k30sjb Hgr7aF2bqOWUdTHEGrwNPMHe2GesbKZkYXXirjzWaIszA8a72HUVkAT5WoXPjUNGSIzC UBxkF1OjKuVJcuSrzznLooW+dNDZMD2bA90eKblSlstVGF/68UnvB7jzk0+K4bIdOMkj 7Zb2rc+m8NUiE5GuOPoMMm+RlXRTCi+kep0pOVbFqmOlI842AdmKyf6W9Ys4oS85Avsh APaQ== X-Forwarded-Encrypted: i=1; AHgh+RoDpwepWoFJ5U64C2DzygiMTwTVfA5xqniHhf8Rr6KhFRW4OzkvmtXD44uacvnhc9YBPT7wPdJ+WFRJ9qU=@vger.kernel.org X-Gm-Message-State: AOJu0YzGwUSGYn718cIovP7cZhjwxnKP8PmIh2XKit5DP40KNBF4s1pc FuJgaiQOeTb/n8gwYifYj2/wbMkMhrktGpYAGLFPXwyIha/KtWlPtA93qxhRvfr5rGztoXzbPzr 2npUrS5PIljAqlRr/TNCN07IUgKuYNhqVAEO62O93VmTgujYVXHiJ00Ic2DSdW3MmnP8= X-Gm-Gg: AR+sD11XauPRWwxcSmU1JemOuYlHCZnvVppq6OoIecVqe5BxUpXABkNU+cxY0M6nXMK 6OFTqClcy0LER1rIb5lkQ1HGOAaytLccaSp/obpv5OJHLG+jKOU+o9TRBoxiyXBPuzfHrPiMX4w 8QuUeD4SjXsxWhWtTZh4IYUbZOQ0fgDRdpKsBcfceuiTzY76zd1Ntp7nIpruW3SqiwAYOwb8YfC vjH0tQa2h6/GVnCiWL895kyx1UYE49luZnL31mXrTba/4kW087jJbv/7zq+qlh5L7guhGimrmih RMRFQE4odoLyGDTLxNZQ8/HXbpJSIArYxTyZFg9ZNa/rzmT3/Z4YyoSEVI5m8iwCW+c8B5eahOM icel1ahwi22RyLdONBralv6HZ05mt9TfT8jQUSkJ3BDzNOPD8aZ2xsRaxpegm8D4V6PbclqR3 X-Received: by 2002:a17:90b:528c:b0:380:9f17:6df3 with SMTP id 98e67ed59e1d1-3903c5448dcmr43326186a91.4.1786354640877; Mon, 10 Aug 2026 02:37:20 -0700 (PDT) X-Received: by 2002:a17:90b:528c:b0:380:9f17:6df3 with SMTP id 98e67ed59e1d1-3903c5448dcmr43326144a91.4.1786354640404; Mon, 10 Aug 2026 02:37:20 -0700 (PDT) Received: from [10.133.33.20] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3925fc6dab4sm12066088a91.3.2026.08.10.02.37.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 10 Aug 2026 02:37:19 -0700 (PDT) Message-ID: Date: Mon, 10 Aug 2026 17:37:16 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] wifi: ath12k: fix channel list double-free on error paths To: Linkai Gong , Jeff Johnson Cc: Vasanthakumar Thiagarajan , Rameshkumar Sundaram , linux-wireless@vger.kernel.org, ath12k@lists.infradead.org, linux-kernel@vger.kernel.org References: <20260731093816.1771338-1-gonglinkai@kylinos.cn> From: Baochen Qiang Content-Language: en-US In-Reply-To: <20260731093816.1771338-1-gonglinkai@kylinos.cn> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Info: AW1haW4tMjYwODEwMDA4MyBTYWx0ZWRfX1uQSgXebrMuG z9Im3v+jo0oDYrYnjoFpyixzy6qj0sYJF31IU0MbGE5qEb4KqZBcU7Mq3DiWsKKdIFI/om1aHJw y5+L9+GR4za2dguCkgqW+zWBndEfzbk= X-Proofpoint-ORIG-GUID: 7heQxhMiBQXiQXWA10QDwmDpfXhlIuxp X-Proofpoint-GUID: 7heQxhMiBQXiQXWA10QDwmDpfXhlIuxp X-Authority-Analysis: v=2.4 cv=bfZbluPB c=1 sm=1 tr=0 ts=6a799bd1 cx=c_pps a=vVfyC5vLCtgYJKYeQD43oA==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=UmHtXT4VRqcp-Ls_mGYA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=rl5im9kqc5Lf4LNbBjHf:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODEwMDA4MyBTYWx0ZWRfX4R/NI3g1VGy0 Lo8PPqk5WRK1keuGBfOBo7gyzOjfGHnIIKHIWZkvGX9hNDpOCO7nMh5zK8otl9KUaaLeU9QY+S4 rZVNnJo3hmH5Xr4iuV4cAq5u7nD31WQhDKRBNkWW8M7/P6P8YZqEAVhqDQQpqxRaQO0LCiP47I2 hpLtqFY/g+WEbyrcGcRa0ICxniMLf/dWwx6HdReCtj1epz6sjgP0h9JijPqpUiy2J1SC57l1w2Z A7fd5O14fTxVhL+udZNQKA/csXBRALdnsc1tTgYmob3yh6C9ITwoGZ+OkiFyFn3E/puIdvz7wLT cSnygC01N+rXDql+/gL15IgoGaB5GfSbo7WKmxI5RBCe0HAbjNz5tcZtW3WhUF6JsB/I5pegB0D HbWm82598HBrWT0WB4BmR08uCOp4qQ6aM0zcL6fmfQsHsKbi91+sM/jL2MLisEDiIW827GggRBm sGz3eMy4eZnSCS7HABQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-10_02,2026-08-07_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 spamscore=0 lowpriorityscore=0 malwarescore=0 clxscore=1015 priorityscore=1501 phishscore=0 bulkscore=0 suspectscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608100083 On 7/31/2026 5:38 PM, Linkai Gong wrote: > ath12k_mac_setup_channels_rates() frees band channel arrays on failure > but either leaves the pointers non-NULL or clears the wrong band. Later > ath12k_mac_cleanup_unregister() frees the same pointers again. The radio that frees its sbands[].channels inside setup_channels_rates() is precisely the one excluded from cleanup_unregister() — the loop is for (j = 0; j < i; j++) and the failing radio is index i. The earlier radios (0..i-1) all fully succeeded, so their channel arrays are valid and freed exactly once. So this is actually a dangling pointer issue, not a reachable double-free — nothing frees the failing radio's pointers a second time. Please reword the message to something like "error paths leave dangling pointers + a copy-paste typo; harden by consistently nulling after kfree()." > > Clear the correct sbands[].channels pointers after kfree(), including > a copy-paste bug that nulled 2 GHz after freeing 6 GHz channels. > > Fixes: acc152f9be20 ("wifi: ath12k: combine channel list for split-phy devices in single-wiphy") > Signed-off-by: Linkai Gong > --- > drivers/net/wireless/ath/ath12k/mac.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/wireless/ath/ath12k/mac.c b/drivers/net/wireless/ath/ath12k/mac.c > index a0928890671a..5468a8d2d5d5 100644 > --- a/drivers/net/wireless/ath/ath12k/mac.c > +++ b/drivers/net/wireless/ath/ath12k/mac.c > @@ -14275,6 +14275,7 @@ static int ath12k_mac_setup_channels_rates(struct ath12k *ar, > sizeof(ath12k_6ghz_channels), GFP_KERNEL); > if (!channels) { > kfree(ar->mac.sbands[NL80211_BAND_2GHZ].channels); > + ar->mac.sbands[NL80211_BAND_2GHZ].channels = NULL; > return -ENOMEM; > } > > @@ -14325,7 +14326,9 @@ static int ath12k_mac_setup_channels_rates(struct ath12k *ar, > GFP_KERNEL); > if (!channels) { > kfree(ar->mac.sbands[NL80211_BAND_2GHZ].channels); > + ar->mac.sbands[NL80211_BAND_2GHZ].channels = NULL; > kfree(ar->mac.sbands[NL80211_BAND_6GHZ].channels); > + ar->mac.sbands[NL80211_BAND_6GHZ].channels = NULL; > return -ENOMEM; > } > > @@ -14365,7 +14368,7 @@ static int ath12k_mac_setup_channels_rates(struct ath12k *ar, > kfree(ar->mac.sbands[NL80211_BAND_2GHZ].channels); > ar->mac.sbands[NL80211_BAND_2GHZ].channels = NULL; > kfree(ar->mac.sbands[NL80211_BAND_6GHZ].channels); > - ar->mac.sbands[NL80211_BAND_2GHZ].channels = NULL; > + ar->mac.sbands[NL80211_BAND_6GHZ].channels = NULL; > kfree(channels); > band->channels = NULL; > return ret; actual code change looks good