From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 478792ECE91 for ; Mon, 18 May 2026 08:04:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779091498; cv=none; b=SFKqWerU8S2VMH3bUaTSfC17x2IDhk+ODdZt09007Eo1H6kO4YAhiE6mgH3YXuzSXW2Oa2bbXB37g9GqvcUVqjbDU9kL71VnXlBqegKzh0KMA2omdcOXpWp/tFskbTEEloXZUPUGCrRQ8IB1JkOI8JNK2YO/TW9ovhhtrWyGD7A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779091498; c=relaxed/simple; bh=gBipkm12xNP0wibk+GNikr81PqPfshJIl/JWFX4BfiA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=s9jcuFR8PB5R0xi9L6YQAjK2mmXskpuXV9DmYxTn/dlf+C18tqHYRK0YCjLOAXZJVMcvnYFcYc6e9xoZbt2QR9IpC1rVEFIrhBzqe7akH/vCazh/unnsYjpnhtD0lk8BeECBSuaisjOT4nYiG8e9D9knj95+TjUhsP1UmnJ1N1g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=an5bPjxh; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=fDnOkG5h; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="an5bPjxh"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="fDnOkG5h" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64I2o6fF2661891 for ; Mon, 18 May 2026 08:04:56 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= ZewacJ3i9lKnkmzTTca31dtk4aGbjL3egDzG8Fs6hJM=; b=an5bPjxh9W9uZAis qJ7AWW2Gyc+6/v8OPAslx0aP+c783pPpC52iegEeBmd4xOTu+E/f5VO8qjW/SND9 lCEKKRKK31oKDifc5fvYKN261vn12J1UVi9YP3t1AVd97jCAg6R7mFqyUrJBENin TAHUD1teG9wd08hC5BrUVd3bFWmmhhnWadk5s2YWxY99X17FPC5mfbky7AGWdLmz JeLqNOJw4v1tl1p+cpRf0QpAXqy51E6IBjwZ6w9R0T1K2/Qtr/Spj5TBLyghoEGj ykbySr798kLVC4mwS5fSsqMGMvzHNEfk8HF6NrTRv1Uc8RxKvvSsV3UEfOgX+4n4 +YsG3Q== Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e6h0qdd1r-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 18 May 2026 08:04:56 +0000 (GMT) Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-50de6db1eabso7432461cf.0 for ; Mon, 18 May 2026 01:04:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1779091496; x=1779696296; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ZewacJ3i9lKnkmzTTca31dtk4aGbjL3egDzG8Fs6hJM=; b=fDnOkG5hTbfMJCwsvsdujtSZWSVaFocHMIqsBplhPIFZO8oMuWw2pBEjL3c31Q81LO GoJXSGSfTEa0OmwEsKP/mqWBrLIq3h5lTw3fojDVVphJmY4utvDjg18zfk/CRLMx7tFe 8jzh+T/KQA1hbsIGbMyNvtvMZuyzkwVv9vR1ypbjbSpERIKogSaFyrkIsk49GqCBFaem CtjdRaD0mEjc49TXfNKX/jWWjL09h7VF4nIjvIDw66GnZ3U3z2nqc6bvcXdGmCIpWF7x SZspGMAuDluByBe0abGQQhi8nUmfulyk4wDW6lC4ONA8KTqOKNck1Uzm2qCJQFRxzTSq ExCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779091496; x=1779696296; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ZewacJ3i9lKnkmzTTca31dtk4aGbjL3egDzG8Fs6hJM=; b=qJn1u4xHMKj1JYjnAUsJPgD0e1+C9LmFuwIsU+QA4JYVeNenJYSgP1g9kBwn2kidka i2zG3X/if50w82EopRkI5eqHq+bF3vowU7uFuy+b7NmW7Wspk82eJjBlyrz+i04lWJtP rhDP2YUs2Fb2W6IanjgtL5ZeaQ99pTrnKSvEZDEobIA67/PMYVmAVUab4xGfmeDCpqtV 8o5IA8/tPZyAf4sr2thxLfhb6FxHfEPug45QZeZOmdaI4FVXNLYSSe19pbpQu3A70bkF tEdgrOWOoBqVutacTTkGi2eUjexWFie6foUSsQsAcq5VLcDRCAKU1qoU4my+rtUi/ZZk mmiA== X-Forwarded-Encrypted: i=1; AFNElJ+0nl5efJmlGSXyudP6AIk39MhhPao0QBnCCbpIjT+arZbjyMsuIibgbGkixEGKxkAfOeOl9ZAqroFmgQU=@vger.kernel.org X-Gm-Message-State: AOJu0Yx5Z2kUzaqLfWO/sbmJmqoelNwFlBKy39z/168Kn0YDsc4tpP/p 7PZGlRy0pvLaTgFziW2O6S/ub0J6j0K9wEuasXplJpJetWxGJpsM3wOq07jaOJINS2amdaHgzNd wpZc/sSYfH+7dPYt3sYvxHavP81rnBRaniw1CJQWU1lymfEyK6YOcu40a7gK+wMN3xik= X-Gm-Gg: Acq92OF7zifS4U9S6TfZ55+cjkykyKhjwRwi6OGZiHulh0K30HRkbhjZWy6bvXFaV1r aMApETEfccLY60nC1TN6RbmA9Fd9m4GlyxAgWw150iaju1knGbpdbTd5gAkReobWnOLdoWNuyG5 ewl97mu47ZI1Fd8frja4l+HbHJMH6VrDpy3/V5ZWbOi1QzcwS2WVLzyrHlVTJEZvAVQclOu9tRi DypbD/BcobUGsJShe4axBCoF8TP1n801L5/4bsEuFTjfGRN8FGG4LPmUb2jJ0r1bCEXFPVxasnl P/mQKrvXgkNe+K3dA0+wwzWcIcoKsnZz1UWW64QcdMEeyILE0oVpCuMaBD4o+5ZCWVMRGCUqDih EGmFN58DAAIYbq/0koWkck5lx01zZsbR4NqF2GNH4i8EDu+qa+V5nRob7PVAiaNzbq8xswIx0MR 6TG5ckJSL379wKWQ== X-Received: by 2002:a05:622a:11ce:b0:513:43ce:eaa3 with SMTP id d75a77b69052e-5165a202f87mr142817361cf.6.1779091495639; Mon, 18 May 2026 01:04:55 -0700 (PDT) X-Received: by 2002:a05:622a:11ce:b0:513:43ce:eaa3 with SMTP id d75a77b69052e-5165a202f87mr142817141cf.6.1779091495183; Mon, 18 May 2026 01:04:55 -0700 (PDT) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-bd4f4bd2f67sm531577166b.7.2026.05.18.01.04.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 18 May 2026 01:04:54 -0700 (PDT) Message-ID: Date: Mon, 18 May 2026 10:04:52 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/3] drm/msm/a6xx: Add HFI support for CLX feature To: Akhil P Oommen , Rob Clark , Sean Paul , Konrad Dybcio , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Marijn Suijten , David Airlie , Simona Vetter Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20260516-a8xx-clx-support-v1-0-62508bf651ac@oss.qualcomm.com> <20260516-a8xx-clx-support-v1-1-62508bf651ac@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260516-a8xx-clx-support-v1-1-62508bf651ac@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: EIw5T33G-z7-pF9XLM8N7eTEjJj-jueC X-Proofpoint-GUID: EIw5T33G-z7-pF9XLM8N7eTEjJj-jueC X-Authority-Analysis: v=2.4 cv=fIMJG5ae c=1 sm=1 tr=0 ts=6a0ac828 cx=c_pps a=JbAStetqSzwMeJznSMzCyw==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=EUspDBNiAAAA:8 a=ktFr412pgo1MGF5CTeQA:9 a=QEXdDO2ut3YA:10 a=uxP6HrT_eTzRwkO_Te1X:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTE4MDA3NiBTYWx0ZWRfXxB3VHXArLv7p 8btdOe3Gdp9hUtcpDl6+YXPH4qh30+AwBnBbgjifiYBy7VGkpbKplw7QqtkXhnJQD+STtzXzbuo wCR4Fn58ANHFYnBHrKSHA93/wA2vOUaAMCX2Br7Ok1IPDEtFa7m0QSaEsMZlY4qIjjSzgSNav8w F8P4dxsx+MhfoMac0SE5mS+MCMZLybkw1Zd9vBw5rqfnZftYghqFVNcqXWMsMU3QIm4pXzV4txg t+jJkm23wRd0fyo+ZcSQEb4M3mvZpsoVVQ9ccN84mtr/+zb1iIPXyxili41F8GyzTJnaoopkeCC S5xKJz5Rd7l6TMyTRg+UBmzJa3UvETZ0pd9RLduZKnmLF+UqZnU0Ns1yVAe+BUmJZ9UHkujRZSd BjwMnXAAZDGUADS8w9vLowpWe0ho1lvEEyt/cHzWRyxWvrvmmvrXAfFYTkitdCLIGlK5nJTag6t 3VHx94kP9zcSZawr3Mg== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-18_02,2026-05-15_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 impostorscore=0 spamscore=0 bulkscore=0 phishscore=0 priorityscore=1501 adultscore=0 suspectscore=0 lowpriorityscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605130000 definitions=main-2605180076 On 5/15/26 10:07 PM, Akhil P Oommen wrote: > Add support for Current Limit Extension (CLX) feature found on a few A8x > GPUs. This feature is required to limit the peak current consumption to > avoid HW spec violation on GX/MX rails. > > Add the necessary HFI interface support to pass the recommended CLX and > IFF/PCLX limits tables to the GMU. Per-GPU configuration is consumed > from the catalog entries. > > Signed-off-by: Akhil P Oommen > --- [...] > +static int a6xx_hfi_enable_clx(struct a6xx_gmu *gmu) > +{ > + struct a6xx_gpu *a6xx_gpu = container_of(gmu, struct a6xx_gpu, gmu); > + struct adreno_gpu *adreno_gpu = &a6xx_gpu->base; > + const struct a6xx_info *info = adreno_gpu->info->a6xx; > + struct a6xx_hfi_clx_table_v2_cmd cmd = { 0 }; > + int ret; > + > + if (!info->clx_tbl) > + return 0; > + > + ret = a6xx_hfi_feature_ctrl_msg(gmu, HFI_FEATURE_CLX, 1, 0); > + if (ret) { > + DRM_DEV_ERROR(gmu->dev, "Unable to enable CLX (%d)\n", ret); > + return ret; > + } > + > + memcpy(&cmd, info->clx_tbl, sizeof(cmd)); You're not adjusting anything (unlike the other function), so you can just pass info->clx_tbl below > + > + ret = a6xx_hfi_send_msg(gmu, HFI_H2F_MSG_CLX_TBL, &cmd, sizeof(cmd), NULL, 0); > + if (ret) { > + DRM_DEV_ERROR(gmu->dev, "Unable to send CLX table (%d)\n", ret); > + return ret; > + } Konrad