From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9458E139CFC; Tue, 18 Jun 2024 14:33:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=45.249.212.255 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718721190; cv=none; b=VRpi2edt+58oKeAdwe9E67GbsgrzcuTQ3JNToq8IjTA6X7YQvjzp3d/iZBpy7fbZ+30ua3FJO+yoE0bALWOHqecdGb6m6R0UU9HQt0c/XtgnCCVgJhXw4pmPqF26S0D6BHHmXFKSvEkQ2lOcvZHoth131GwhZFTZ7WRB6pRjB0c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718721190; c=relaxed/simple; bh=ZyOZ9J3QRzEiSMg23ILmpfCKotN1iY9F6+Jc3rY7gLg=; h=CC:Subject:To:References:From:Message-ID:Date:MIME-Version: In-Reply-To:Content-Type; b=gDBc2z/oe2FKu1P85VAHIf6mbvvMpYdaBGoAkerYAJX2Sr6BXdTx05KbPywz28DINUpTRdV4QQ+N2nRJoQ+Tmi+gAij0253bY9x9iZpH1GTJDWVIurRHGUIoeK+b9y3YP4lv1H9jWQy2jOW5WPGMAXFHZja3jOsT3Vhkep9tdSs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com; spf=pass smtp.mailfrom=huawei.com; arc=none smtp.client-ip=45.249.212.255 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Received: from mail.maildlp.com (unknown [172.19.163.174]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4W3Tdb28C2z1SCYt; Tue, 18 Jun 2024 22:28:51 +0800 (CST) Received: from kwepemd200014.china.huawei.com (unknown [7.221.188.8]) by mail.maildlp.com (Postfix) with ESMTPS id 12C98140258; Tue, 18 Jun 2024 22:33:05 +0800 (CST) Received: from [10.67.121.177] (10.67.121.177) by kwepemd200014.china.huawei.com (7.221.188.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1258.34; Tue, 18 Jun 2024 22:33:04 +0800 CC: , , , , Subject: Re: [PATCH] perf: add missing MODULE_DESCRIPTION() macros To: Jeff Johnson , Will Deacon , Mark Rutland , Jonathan Cameron , Frank Li , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Yicong Yang References: <20240611-md-drivers-perf-v1-1-c001bae6da5c@quicinc.com> From: Yicong Yang Message-ID: Date: Tue, 18 Jun 2024 22:33:03 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.5.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 In-Reply-To: <20240611-md-drivers-perf-v1-1-c001bae6da5c@quicinc.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To kwepemd200014.china.huawei.com (7.221.188.8) Hi Jeff, On 2024/6/12 2:31, Jeff Johnson wrote: > With ARCH=x86, make allmodconfig && make W=1 C=1 reports: > WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/perf/arm-ccn.o > WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/perf/fsl_imx8_ddr_perf.o > WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/perf/marvell_cn10k_ddr_pmu.o > WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/perf/arm_cspmu/arm_cspmu_module.o > WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/perf/arm_cspmu/nvidia_cspmu.o > WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/perf/arm_cspmu/ampere_cspmu.o > WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/perf/cxl_pmu.o > > Add the missing invocation of the MODULE_DESCRIPTION() macro to all > files which have a MODULE_LICENSE(). > > This includes drivers/perf/hisilicon/hisi_uncore_pmu.c which, although > it did not produce a warning with the x86 allmodconfig configuration, > may cause this warning with arm64 configurations. > Thanks for catching this. I can reproduce this by my config: ➜ hisilicon git:(master) make -C ../../../ M=$(pwd) W=1 make: Entering directory '/home/yangyicong/mainline_linux/linux' CC [M] /home/yangyicong/mainline_linux/linux/drivers/perf/hisilicon/hisi_uncore_pmu.o CC [M] /home/yangyicong/mainline_linux/linux/drivers/perf/hisilicon/hisi_uncore_l3c_pmu.o CC [M] /home/yangyicong/mainline_linux/linux/drivers/perf/hisilicon/hisi_uncore_hha_pmu.o CC [M] /home/yangyicong/mainline_linux/linux/drivers/perf/hisilicon/hisi_uncore_ddrc_pmu.o CC [M] /home/yangyicong/mainline_linux/linux/drivers/perf/hisilicon/hisi_uncore_sllc_pmu.o CC [M] /home/yangyicong/mainline_linux/linux/drivers/perf/hisilicon/hisi_uncore_pa_pmu.o CC [M] /home/yangyicong/mainline_linux/linux/drivers/perf/hisilicon/hisi_uncore_cpa_pmu.o CC [M] /home/yangyicong/mainline_linux/linux/drivers/perf/hisilicon/hisi_uncore_uc_pmu.o CC [M] /home/yangyicong/mainline_linux/linux/drivers/perf/hisilicon/hisi_pcie_pmu.o CC [M] /home/yangyicong/mainline_linux/linux/drivers/perf/hisilicon/hns3_pmu.o MODPOST /home/yangyicong/mainline_linux/linux/drivers/perf/hisilicon/Module.symvers WARNING: modpost: missing MODULE_DESCRIPTION() in /home/yangyicong/mainline_linux/linux/drivers/perf/hisilicon/hisi_uncore_pmu.o This warning is introduced by 1fffe7a34c89 ("script: modpost: emit a warning when the description is missing") from v6.5 so we didn't catch this. Once comment below. > Signed-off-by: Jeff Johnson > --- > drivers/perf/arm-ccn.c | 1 + > drivers/perf/arm_cspmu/ampere_cspmu.c | 1 + > drivers/perf/arm_cspmu/arm_cspmu.c | 1 + > drivers/perf/arm_cspmu/nvidia_cspmu.c | 1 + > drivers/perf/cxl_pmu.c | 1 + > drivers/perf/fsl_imx8_ddr_perf.c | 1 + > drivers/perf/hisilicon/hisi_uncore_pmu.c | 1 + > drivers/perf/marvell_cn10k_ddr_pmu.c | 1 + > 8 files changed, 8 insertions(+) > > diff --git a/drivers/perf/arm-ccn.c b/drivers/perf/arm-ccn.c > index 86ef31ac7503..65f4882531db 100644 > --- a/drivers/perf/arm-ccn.c > +++ b/drivers/perf/arm-ccn.c > @@ -1561,4 +1561,5 @@ module_init(arm_ccn_init); > module_exit(arm_ccn_exit); > > MODULE_AUTHOR("Pawel Moll "); > +MODULE_DESCRIPTION("ARM CCN (Cache Coherent Network) driver support"); > MODULE_LICENSE("GPL v2"); > diff --git a/drivers/perf/arm_cspmu/ampere_cspmu.c b/drivers/perf/arm_cspmu/ampere_cspmu.c > index f146a455e838..426b3cfcb52e 100644 > --- a/drivers/perf/arm_cspmu/ampere_cspmu.c > +++ b/drivers/perf/arm_cspmu/ampere_cspmu.c > @@ -269,4 +269,5 @@ static void __exit ampere_cspmu_exit(void) > module_init(ampere_cspmu_init); > module_exit(ampere_cspmu_exit); > > +MODULE_DESCRIPTION("Ampere SoC PMU (Performance Monitor Unit) driver"); > MODULE_LICENSE("GPL"); > diff --git a/drivers/perf/arm_cspmu/arm_cspmu.c b/drivers/perf/arm_cspmu/arm_cspmu.c > index c318dc909767..c21c564840d6 100644 > --- a/drivers/perf/arm_cspmu/arm_cspmu.c > +++ b/drivers/perf/arm_cspmu/arm_cspmu.c > @@ -1427,4 +1427,5 @@ EXPORT_SYMBOL_GPL(arm_cspmu_impl_unregister); > module_init(arm_cspmu_init); > module_exit(arm_cspmu_exit); > > +MODULE_DESCRIPTION("ARM CoreSight Architecture PMU driver"); > MODULE_LICENSE("GPL v2"); > diff --git a/drivers/perf/arm_cspmu/nvidia_cspmu.c b/drivers/perf/arm_cspmu/nvidia_cspmu.c > index 5b84b701ad62..0dea47e48ac5 100644 > --- a/drivers/perf/arm_cspmu/nvidia_cspmu.c > +++ b/drivers/perf/arm_cspmu/nvidia_cspmu.c > @@ -417,4 +417,5 @@ static void __exit nvidia_cspmu_exit(void) > module_init(nvidia_cspmu_init); > module_exit(nvidia_cspmu_exit); > > +MODULE_DESCRIPTION("NVIDIA Coresight Architecture PMU driver"); > MODULE_LICENSE("GPL v2"); > diff --git a/drivers/perf/cxl_pmu.c b/drivers/perf/cxl_pmu.c > index 1f93a66eff5b..8b6ce9ea5a55 100644 > --- a/drivers/perf/cxl_pmu.c > +++ b/drivers/perf/cxl_pmu.c > @@ -972,6 +972,7 @@ static __exit void cxl_pmu_exit(void) > cpuhp_remove_multi_state(cxl_pmu_cpuhp_state_num); > } > > +MODULE_DESCRIPTION("CXL Performance Monitoring Unit driver"); > MODULE_LICENSE("GPL"); > MODULE_IMPORT_NS(CXL); > module_init(cxl_pmu_init); > diff --git a/drivers/perf/fsl_imx8_ddr_perf.c b/drivers/perf/fsl_imx8_ddr_perf.c > index 1bbdb29743c4..a6683b38315c 100644 > --- a/drivers/perf/fsl_imx8_ddr_perf.c > +++ b/drivers/perf/fsl_imx8_ddr_perf.c > @@ -850,4 +850,5 @@ static struct platform_driver imx_ddr_pmu_driver = { > }; > > module_platform_driver(imx_ddr_pmu_driver); > +MODULE_DESCRIPTION("Freescale i.MX8 DDR PMU driver"); > MODULE_LICENSE("GPL v2"); > diff --git a/drivers/perf/hisilicon/hisi_uncore_pmu.c b/drivers/perf/hisilicon/hisi_uncore_pmu.c > index 6392cbedcd06..e1df9db498e9 100644 > --- a/drivers/perf/hisilicon/hisi_uncore_pmu.c > +++ b/drivers/perf/hisilicon/hisi_uncore_pmu.c > @@ -537,4 +537,5 @@ void hisi_pmu_init(struct hisi_pmu *hisi_pmu, struct module *module) > } > EXPORT_SYMBOL_GPL(hisi_pmu_init); > > +MODULE_DESCRIPTION("HiSilicon SoC PMU driver"); This module's not a driver but provides the framework for other HiSilicon uncore PMUs. Should be more proper to make this "HiSilicon SoC uncore PMU driver framework". Thanks. > MODULE_LICENSE("GPL v2"); > diff --git a/drivers/perf/marvell_cn10k_ddr_pmu.c b/drivers/perf/marvell_cn10k_ddr_pmu.c > index e2abca188dbe..94f1ebcd2a27 100644 > --- a/drivers/perf/marvell_cn10k_ddr_pmu.c > +++ b/drivers/perf/marvell_cn10k_ddr_pmu.c > @@ -763,4 +763,5 @@ module_init(cn10k_ddr_pmu_init); > module_exit(cn10k_ddr_pmu_exit); > > MODULE_AUTHOR("Bharat Bhushan "); > +MODULE_DESCRIPTION("Marvell CN10K DRAM Subsystem (DSS) Performance Monitor Driver"); > MODULE_LICENSE("GPL v2"); > > --- > base-commit: 83a7eefedc9b56fe7bfeff13b6c7356688ffa670 > change-id: 20240611-md-drivers-perf-5d834208964d > > . >