mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jeff Johnson <quic_jjohnson@quicinc.com>
To: Andrew Morton <akpm@linux-foundation.org>,
	Kees Cook <keescook@chromium.org>,
	Andy Shevchenko <andy@kernel.org>
Cc: <linux-hardening@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<kernel-janitors@vger.kernel.org>
Subject: Re: [PATCH] string: kunit: add missing MODULE_DESCRIPTION() macros
Date: Thu, 20 Jun 2024 09:45:01 -0700	[thread overview]
Message-ID: <bd6c0b05-fe43-4405-bce1-ad765ec6c4d3@quicinc.com> (raw)
In-Reply-To: <20240531-md-lib-string-v1-1-2738cf057d94@quicinc.com>

On 5/31/2024 4:07 PM, Jeff Johnson wrote:
> make allmodconfig && make W=1 C=1 reports:
> WARNING: modpost: missing MODULE_DESCRIPTION() in lib/string_kunit.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in lib/string_helpers_kunit.o
> 
> Add the missing invocation of the MODULE_DESCRIPTION() macro.
> 
> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
> ---
>  lib/string_helpers_kunit.c | 1 +
>  lib/string_kunit.c         | 1 +
>  2 files changed, 2 insertions(+)
> 
> diff --git a/lib/string_helpers_kunit.c b/lib/string_helpers_kunit.c
> index f88e39fd68d6..c853046183d2 100644
> --- a/lib/string_helpers_kunit.c
> +++ b/lib/string_helpers_kunit.c
> @@ -625,4 +625,5 @@ static struct kunit_suite string_helpers_test_suite = {
>  
>  kunit_test_suites(&string_helpers_test_suite);
>  
> +MODULE_DESCRIPTION("Test cases for string helpers module");
>  MODULE_LICENSE("Dual BSD/GPL");
> diff --git a/lib/string_kunit.c b/lib/string_kunit.c
> index 2a812decf14b..c919e3293da6 100644
> --- a/lib/string_kunit.c
> +++ b/lib/string_kunit.c
> @@ -633,4 +633,5 @@ static struct kunit_suite string_test_suite = {
>  
>  kunit_test_suites(&string_test_suite);
>  
> +MODULE_DESCRIPTION("Test cases for string functions");
>  MODULE_LICENSE("GPL v2");
> 
> ---
> base-commit: b050496579632f86ee1ef7e7501906db579f3457
> change-id: 20240531-md-lib-string-d987d813b344
> 

I don't see this in linux-next yet so following up to see if anything else is
needed to get this merged.

  reply	other threads:[~2024-06-20 16:45 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-31 23:07 Jeff Johnson
2024-06-20 16:45 ` Jeff Johnson [this message]
2024-06-20 18:57 ` Kees Cook

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bd6c0b05-fe43-4405-bce1-ad765ec6c4d3@quicinc.com \
    --to=quic_jjohnson@quicinc.com \
    --cc=akpm@linux-foundation.org \
    --cc=andy@kernel.org \
    --cc=keescook@chromium.org \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-hardening@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®