Re: [PATCH] ASoC: SDCA: Replace use of system_wq with system_percpu_wq

[Richard Fitzgerald <rf@opensource.cirrus.com>]

On 24/12/25 16:26, Marco Crivellari wrote:
> This patch continues the effort to refactor workqueue APIs, which has begun
> with the changes introducing new workqueues and a new alloc_workqueue flag:
> 
>     commit 128ea9f6ccfb ("workqueue: Add system_percpu_wq and system_dfl_wq")
>     commit 930c2ea566af ("workqueue: Add new WQ_PERCPU flag")
> 
> The point of the refactoring is to eventually alter the default behavior of
> workqueues to become unbound by default so that their workload placement is
> optimized by the scheduler.
> 
> Before that to happen after a careful review and conversion of each individual
> case

... so the commit message should say why this review decided that for
this individual case the best alternative queue was system_percpu_wq.

, workqueue users must be converted to the better named new workqueues with
> no intended behaviour changes:
> 
>     system_wq -> system_percpu_wq
>     system_unbound_wq -> system_dfl_wq
>

This seems to contradict the statement above that "after a careful
review .. of each individual case". This looks more like every system_wq
is converted to system_percpu_wq.