From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CAE83386C08 for ; Mon, 8 Jun 2026 06:23:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780899807; cv=none; b=JDjPfC8k7wNlH3+34OBXQ2QHpdSWlF09N93jB38gRrkvPi+Adypbck5ecIsL3Cf+7dK5LWdI9hMziV+22zO7eK4g0lGBfq+c0JVuZQBSLkABTFTNoJcThnoRflgJ9O3sRfNPox37HD/YqihAuqrNxqikmqKq5zwtvhzRBIvLda8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780899807; c=relaxed/simple; bh=EZU5exzjs1+KqqtsEsGmX7mSPtLYm4GnJZeGD4kCY74=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=eFTT7YGaPumc16X/cvt5byB+yH/H5im5eM0p9kUF6F4qYH0j5nimjPcRrtyqPFkTyXqw7yEqeO2V1VRDy2QLJggOCR2KKXP7dQJp/FUTH648j8QF4S+gtZtixRCpRzlkp+gHkrHr2UVL0/NntQQpPEiW57BrziKFoKStdMaexBM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=OH1cg95S; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=AGnagfDE; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="OH1cg95S"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="AGnagfDE" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6580FKAS2023281 for ; Mon, 8 Jun 2026 06:23:26 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= xWO6l5rw6b1v7RcDXzC5IAuXWS2yZutJYOH1CAdjkLc=; b=OH1cg95SQyR/Ez5A Ql/t1NpRF89WH31m1zd9ZV3v4e3WEtwQWeEJlBL8a5BZy6Iu5gjkkgKto4/V+/1v Kx2nJ605qaAVr8dZxUf/epnH5lYl98w+ukHZgjVnvp9j8m3qlW5ST8683wa2kG0a ChMFIzlSpFXwlmmmVQFb33b0rrQU6XdKls4oC8oKVnNrpowjjQSbPybBNsDr/tEj BjT11onybOqCk5Eu/mBdKwi9U3FyRkYKLAqjCY5jFRsiFUnCCRVyKGNZsFy9Rgou gV8D12xF497osrZsa/ZK3k7jHlNYsunNJJ10oBGLltoOwHqDnKuYAHteuOrCkAZ8 ZR7pLQ== Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4embmre9un-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 08 Jun 2026 06:23:25 +0000 (GMT) Received: by mail-pl1-f198.google.com with SMTP id d9443c01a7336-2c0c32faa62so73844015ad.2 for ; Sun, 07 Jun 2026 23:23:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1780899805; x=1781504605; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=xWO6l5rw6b1v7RcDXzC5IAuXWS2yZutJYOH1CAdjkLc=; b=AGnagfDEL35Pmy5CIOlMbIKfApmlgrfsr2wyCZ1XfI6t11s4FzGcRft4eVwFUt94rm 2OVivXczQUuoO5GGkK7INgMcMFNPTHfudXrG6abkxg9mM7SoiAOl0XbpgkYIDppGLfxM 1mpDWpp4Bpnogi2gP+cJDPyKDGqGLUBElqdmlLUx6sgoQG68IJRRoDf9LYzqF6/w3M4X iN7FEc57nUvRvcTU1jMMTy/kO4v9YtXnJcBc8ainfW5BguzS/3+CRP8ocYp6RncSHczR B+JBxD0IRyP6WKFM38GIcyWGcL54nITgZyjQROcxSyZ49E0aXdtwWcAvwbqgRNkjT8vf K9OQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780899805; x=1781504605; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=xWO6l5rw6b1v7RcDXzC5IAuXWS2yZutJYOH1CAdjkLc=; b=aLKHORtVHILbQCThyW+u7eOMwdiCJelDvgKZ+yId6O07LwVRZ8VG7eAglH6bRDqAxj 4oDpUL8lllgY7XywDUElKW3dsfugXlYESCaoTq8IzsVKYgiYSaKgmSW3PEy3DSAwOJis FscKWbY6XiXGeqC8H6h1PJNOsqc5oENK8amDY28ICygkeEtepwP1KLTUclHhKa7qjfCB R5cHkylfYeok9YKiyUBBk8RHAy1PDKOvpalKV/fz0O7ioTQxmx428TZ64mCPLGQyRk/1 JB99iXjDaMRKTkeaet0kHkHloOdxdJku+TcZxfRtoyxU/9Y6Hd1VYxrcBSqp0QOrOXQY 09bw== X-Forwarded-Encrypted: i=1; AFNElJ8wTRU75JxQMQ/z8oIuW78n57TcR56MxR8/nCVTEOD6ZkmoKjBLG5DV8BAeczwnXRFeQl9PEJAgPiW/RSQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yy3RJEpC3GeA6oo1bopmAEWEyfBknct/QCx00/1BAPzle+RKt78 GuA1hig25UTiuPyN8Rb4arjZjzPxoTVZWBBYX1l1eVjGUHBSoQRuAPYE51z46hVf90rZ5RoxZG0 BE/rk8GSPnI2p9/bowu1kJ3+UzrkWu4H7daU/apcXvfizXPyyKl3nZkZP9C/9zC6jlWF9xwQBmQ c= X-Gm-Gg: Acq92OGAUGM5/PSDgu2Y3cuZE8FKAXjvEc3Hmc9MqUY7G8rxTFLeSNNCnqjwJb2J8AI 5kJTG07WEhYUeaHWkkMpD2Fr4AblajySMRa4WgdHmar0yBBcMLaAoBe6n5tSY2k3pvHkIIq35Kh pjFsaqIZWI8FyPjPkkT7HR5WsdLVdDNo089qMZDyohegyk03EVKt9sI+G+MteCINBdG2BiBHnIx bsNVMYO5bnmyfdEr15GFZ5wDmexXYts8IP/yC3bxOmt5AAayPxlxzxdVWSgPj02lJAzygEEBpQp 576zca1yGysE1Hd6HSu2UsMxeez4GaObemKb+rwZZeq1VsKk2PT5OM9cOLJqYHC2+21kN9S5Xj9 90cSlWuyINKUKZhiOeG91Ai3t5ZBkXveWH486CXtHYV9KxLz2WthzqyGxvKBXuSt9 X-Received: by 2002:a17:903:2348:b0:2c2:33a4:aaa2 with SMTP id d9443c01a7336-2c233a4adcemr88782145ad.35.1780899804678; Sun, 07 Jun 2026 23:23:24 -0700 (PDT) X-Received: by 2002:a17:903:2348:b0:2c2:33a4:aaa2 with SMTP id d9443c01a7336-2c233a4adcemr88781865ad.35.1780899804120; Sun, 07 Jun 2026 23:23:24 -0700 (PDT) Received: from [10.206.105.200] ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2c166495203sm161321325ad.70.2026.06.07.23.23.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 07 Jun 2026 23:23:23 -0700 (PDT) Message-ID: Date: Mon, 8 Jun 2026 11:53:19 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH] media: qcom: iris: cancel sys error work on driver removal Content-Language: en-US To: Hungyu Lin , vikash.garodia@oss.qualcomm.com, bod@kernel.org, mchehab@kernel.org Cc: abhinav.kumar@linux.dev, stefan.schmidt@linaro.org, hverkuil@kernel.org, linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260604054708.42426-1-dennylin0707@gmail.com> From: Vishnu Reddy In-Reply-To: <20260604054708.42426-1-dennylin0707@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjA4MDA1NiBTYWx0ZWRfX/x6Oi04XrEzP SPpRJ5lL7T5o+cDBxBmsG6G2G7tgSmwVr+gbriiujAnNIJh+8519EucZ+DIq9csI3ELMkmdeQa8 6paLLcfcREJij6OsSwsdAJGaNHGjzMLxqRyiqCGd7nz7EU7+FPdWbnfXTjwM9AZxDSPg4vENOKg sS46RdOnpXMSq6RofEsU32OfB6IAgx7WMhhBb1FlmSScHGazVjFVh9/cGSVzJ4qZD1w5vlMK9i/ DiaW9/PvIYtc9MHoTw1JuEObUseA7K7lBxYRDf6v9lrY5yYEGjgHQW7v2YRfzlJptnVzbfpbTBp Wwq9c8M0RBHlYp9IWSMxUtRxNXBpz0jVWQzh8ylXE5unGfXlsaAbIAYIdKVSE1odOPyQ2M9fSYj 8GI8OAOQOu7vnyEErTfumbICkYNd/fTLAGLXqtSnddPR0Wy6mNganvTC+KE4I3I9Z+CpFmkoncx 6o9n4Jpsf2KtFjzrxVw== X-Authority-Analysis: v=2.4 cv=B5eJFutM c=1 sm=1 tr=0 ts=6a265fdd cx=c_pps a=MTSHoo12Qbhz2p7MsH1ifg==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=pGLkceISAAAA:8 a=EUspDBNiAAAA:8 a=5JE-SqTOD2pdjX8B6gUA:9 a=QEXdDO2ut3YA:10 a=GvdueXVYPmCkWapjIL-Q:22 X-Proofpoint-GUID: QklOTRaDnVQ09GZYX4wfRHSEoiMZQ2aT X-Proofpoint-ORIG-GUID: QklOTRaDnVQ09GZYX4wfRHSEoiMZQ2aT X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-08_01,2026-06-05_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 priorityscore=1501 spamscore=0 malwarescore=0 phishscore=0 bulkscore=0 clxscore=1015 adultscore=0 lowpriorityscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605210000 definitions=main-2606080056 On 6/4/2026 11:17 AM, Hungyu Lin wrote: > Cancel sys_error_handler before tearing down the driver. > > The delayed work may still be pending when iris_remove() > runs. Since iris_core is allocated with devm_kzalloc(), > allowing the work to execute after driver removal could > result in accessing freed memory. > > Fixes: fb583a214337 ("media: iris: introduce host firmware interface with necessary hooks") > Signed-off-by: Hungyu Lin > --- > drivers/media/platform/qcom/iris/iris_probe.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/media/platform/qcom/iris/iris_probe.c b/drivers/media/platform/qcom/iris/iris_probe.c > index ddaacda523ec..1a740542bc81 100644 > --- a/drivers/media/platform/qcom/iris/iris_probe.c > +++ b/drivers/media/platform/qcom/iris/iris_probe.c > @@ -192,6 +192,8 @@ static void iris_remove(struct platform_device *pdev) > if (!core) > return; > > + cancel_delayed_work_sync(&core->sys_error_handler); > + > iris_core_deinit(core); > > video_unregister_device(core->vdev_dec); Reviewed-by: Vishnu Reddy