From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mta0.migadu.com (out-154.mta0.migadu.com [91.218.175.154]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 96BF53D525B for ; Wed, 19 Aug 2026 07:10:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.154 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787123444; cv=none; b=egYPKURe1lonEpW44b25ZG/UbChZm9nbpx6mpGDEDSSyUKuISdokfkE4qjV0XbFSPIcypCfJIvXApLQXqCufEp39TydMrbw+pIWm6K+mmks/BXJY4B3gSqzQqaAyUhNBbwOMx6Hu/F/NyOd0SbPHucYyIv57jLg9UY+iFiErHNs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787123444; c=relaxed/simple; bh=yRsnCz6Z1zTV3fHisgw+D/7XSu7IUkTnZoqP0dDh6r8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ca2ZYFWbu8oaPlCgg94bM4Z2+ymK5YxjeUulAymYBYePKWceETY4qTpFKXa2+W1jlOfq8o54KWE+/ysPrmBTYP5mKWiFzW0XvJN1RIPr/Xdtdd22LW7SiaaAPd18n7YVcsu4EedCSxxWX76S8YIDC7KsR6EIlQULSgzbhLbWaps= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=AVl68HIS; arc=none smtp.client-ip=91.218.175.154 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="AVl68HIS" X-Envelope-To: linux-kernel@vger.kernel.org DKIM-Signature: a=rsa-sha256; bh=yRsnCz6Z1zTV3fHisgw+D/7XSu7IUkTnZoqP0dDh6r8=; c=simple/simple; d=linux.dev; h=from:to:subject:date:message-id:mime-version:content-type; s=key1; t=1787123437; v=1; x=1787728237; b=AVl68HISm9ZbmJif8Ch4ACmMvvytNKkryX5GE62KenOW8VS8D7NpRTeQK27TKXAmFiHkWpCg dKSvLOt+8Cg+guYh/xI532hRLcZomTbYF/I3gBMKRkFdhvO8Wp/nVFI0W6oPfLCJ2eOcU06Cb7x 7CI6hWLCQkaeYwyF2d/S1dYY= X-Envelope-To: linux-kernel@vger.kernel.org Received: from [198.18.0.1] (116.128.244.171) by smtp.migadu.com with ESMTPS id 0996cf46c951f138; Wed, 19 Aug 2026 07:10:37 +0000 X-Migadu-Flow: FLOW_OUT Message-ID: Date: Wed, 19 Aug 2026 15:10:32 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net] net: macb: Move macb_{alloc,free}_tieoff() out of CONFIG_OF block To: Nathan Chancellor Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, =?UTF-8?Q?Th=C3=A9o_Lebrun?= , Conor Dooley , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Nicolai Buchwitz References: <20260818-macb-fix-no-of-build-v1-1-f2a009616384@kernel.org> From: luoxuanqiang In-Reply-To: <20260818-macb-fix-no-of-build-v1-1-f2a009616384@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit 在 2026/8/19 09:14, Nathan Chancellor 写道: > Commit 5262eab9462a ("net: macb: allocate tieoff descriptor once across > device lifetime") moved macb_alloc_tieoff() and macb_free_tieoff() into > a CONFIG_OF block, breaking the build when it is disabled: > > drivers/net/ethernet/cadence/macb_main.c: In function 'macb_probe': > drivers/net/ethernet/cadence/macb_main.c:5951:15: error: implicit declaration of function 'macb_alloc_tieoff' [-Wimplicit-function-declaration] > 5951 | err = macb_alloc_tieoff(bp); > | ^~~~~~~~~~~~~~~~~ > drivers/net/ethernet/cadence/macb_main.c:5973:9: error: implicit declaration of function 'macb_free_tieoff' [-Wimplicit-function-declaration] > 5973 | macb_free_tieoff(bp); > | ^~~~~~~~~~~~~~~~ > > Moving macb_alloc_tieoff() from its original positive does not appear to nit: s/from its original positive/from its original position/ > be necessary, so move it and macb_free_tieoff() back out of the > CONFIG_OF block to clear up the error. > > Fixes: 5262eab9462a ("net: macb: allocate tieoff descriptor once across device lifetime") > Signed-off-by: Nathan Chancellor Tested-by: Xuanqiang Luo Thanks, Xuanqiang