From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f52.google.com (mail-lf1-f52.google.com [209.85.167.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0FC833AD517 for ; Thu, 25 Jun 2026 11:07:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782385649; cv=none; b=rV1zzmjjO6iGRDNJ9l/WmFIjnOdSGgMxZ5BWHjdVJWzdX63EvbLxpqzjPK1BYnxz2KKOkLb2aFPEWSmI7/oxu0NtAa7DAhfAsiAtmmKT7q2KhLv0xFJr0xJvJqoPM1+q+CENYa8mm5ibFy4NCKGEwhrSb9S7m8JmReV/6qUemHY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782385649; c=relaxed/simple; bh=OKiJirBUH7iURKZcOXps9KVluu4PRaSUvtf5vVbZa+4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=kXuR33XjjdS9d4FivWb1UnG9crAPVjMkzuBMzMyXuelpX/2y0ujgVG8tUY8zRwGlCbUVMvplcdpW4sZr3Sy7dYW+Daz7U0s5RP8Y3XcRDwvDq8qa/YfMh7PiWXPPYDNQKrqr2qPeI0a+i42IZaWk/6WTrdcJrG8ZR0u37YAf0jM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=n6e5b6T3; arc=none smtp.client-ip=209.85.167.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="n6e5b6T3" Received: by mail-lf1-f52.google.com with SMTP id 2adb3069b0e04-5ad4d1fff66so229565e87.2 for ; Thu, 25 Jun 2026 04:07:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1782385645; x=1782990445; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from:references :cc:to:subject:user-agent:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to:content-type; bh=tkOZ1h3ApBi8l6jNjaETl2uI7tOXqY5UpxR2VkYETGc=; b=n6e5b6T3W/PeU6+El58ifHJtoGE3+3nE2CDey1kfyGhQ1psDqyvplu43U+Md/iPuom bPhyiSpxrbTAt66s9m4O+ER1uhW8iiqoumUySboM4m3kyeorBBmPTjVJJNiceS+Rt9ku A3x06MiHa3cuvGDKFtlfeHu9A/e9zfFGnCdEww21dNgrUtJ2BiUGIN/aQ8AJvk4965Tt LAcqm+QtUft3cmKmXzv0pljyfVXAJRkxWGa6tVqJD5GvI3/xmlunYWvY5r4rBouvJHTm 26PsAGny26oyqk/b0VNhrojj0QsDMd89jwDU4MenhTQXD+C+OFZtsuyFHPR3wOu/4nqR ma/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782385645; x=1782990445; h=content-transfer-encoding:content-type:in-reply-to:from:references :cc:to:subject:user-agent:mime-version:date:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=tkOZ1h3ApBi8l6jNjaETl2uI7tOXqY5UpxR2VkYETGc=; b=lO5OKZ6+/q4hdw7DzBP0b71pBOT9IlyNvSuozcihyeHOACBzc2uMu9J9DtwuoW5Lh/ CNrxLv/RdJjAaI7t5zQsZt18Nt+aVRT9wI1g5OZMuaye0U5XzyMv7dJSNkeg69h0Hw81 oCD2W77ZV4NXCpj0j9QRlHvP0kTOScF+dV1U+IZ0KApHYuWa4Un7x6tOF6X4FX6BZe76 HsxyX1zinl5Kkq3kdfX+gAhbMwsJ+V/0HioW2ffY1h2ReUD+XmsLu/c6l2pIRswIlfqD 3dKo5rP3gMVFgpdIarVWdQkS8TctFEpBtqa0eFDqQqRC/2BdV83A50013oKDDxE+rn9c dQUg== X-Forwarded-Encrypted: i=1; AHgh+RoJRuuoIrz/GPfR8q/Qw+OE7PKSKnbKq4+PxVdApY6uQGtfpOp5cNfVF0VwFfbE+0pmrV2qzh3NvAGeUPk=@vger.kernel.org X-Gm-Message-State: AOJu0YwIQ7SL45hSjRx/CFwVeC+/4oRRaIEIM4uNmI/lvECJwekrDvJf 5B2xw1sguOFM7mCosiFZN37RMgfoZ9kBzhC662FgJ04xPRwAFUutdh/jDcMbSKqmupk= X-Gm-Gg: AfdE7ckBCBshWiQOHJHZv6K9zr2NtBTlxlN7YYu+iI5Rg/zEeGjzZwWN/1s46qn9Xcp tfogq+oKOvYd/IqnBr+5c4lOIhmSkQ9XIcuE1DzcruIVS5eqIMaWoyH5IKmYJ6QV33Gm17fhcPK onXS79qsR7CfDhXxAUHeqCy8XYfB4p7MMIwTsenr04d7BI6FXHAlsXJEjHPFhX6cy1ONGKNPsLb wmjaNK6+LJeoCGHabJY0G86m+kgtETedDwOCU147+1fvwcXuICqetluyZ1Eag+pYekwWBUYZ+w4 3o2HUkABVKKICpFHCWlEiegGvD+/qpxatlnbqx9WawXLFqpQvJAQ9oHX/aED76diFTx1qOfcSfo BvMGHkwjXS82Y+ayi4pNfozOmCFdTmQSTHeTlWVbQggGKvdoC9L8nrRDELNzIQY0FE1axArkWwf 64Vq/L6755Xa83LA0rrUk1t85+XUDguvdDgcnWmMZ6U09deZhDpHvVkcgg38/flPGM7mw= X-Received: by 2002:a05:6512:3f0f:b0:5ad:4c0f:644a with SMTP id 2adb3069b0e04-5aea237b169mr336418e87.8.1782385645209; Thu, 25 Jun 2026 04:07:25 -0700 (PDT) Received: from [192.168.1.100] (91-159-24-186.elisa-laajakaista.fi. [91.159.24.186]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5ad69423d6asm2542956e87.0.2026.06.25.04.07.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 25 Jun 2026 04:07:24 -0700 (PDT) Message-ID: Date: Thu, 25 Jun 2026 14:07:23 +0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] i2c: qcom-cci: drop custom suspend/resume and rely on runtime PM helpers To: Wenmeng Liu , Loic Poulain , Robert Foss , Andi Shyti , Bjorn Andersson , Wolfram Sang , Todor Tomov , Vinod Koul Cc: linux-i2c@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org References: <20260625-cci-v1-1-a100cda673ce@oss.qualcomm.com> From: Vladimir Zapolskiy In-Reply-To: <20260625-cci-v1-1-a100cda673ce@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 6/25/26 12:42, Wenmeng Liu wrote: > cci_resume() unconditionally calls cci_resume_runtime() regardless of > the runtime PM state. > > If the device is already runtime-suspended before system suspend, > the clock is re-enabled while runtime_status remains RPM_SUSPENDED. > As a result, pm_request_autosuspend() does not arm the timer, > leaving the clock permanently enabled. > > Fixes: e517526195de ("i2c: Add Qualcomm CCI I2C driver") > Cc: stable@vger.kernel.org > Signed-off-by: Wenmeng Liu > --- > drivers/i2c/busses/i2c-qcom-cci.c | 18 +----------------- > 1 file changed, 1 insertion(+), 17 deletions(-) > > diff --git a/drivers/i2c/busses/i2c-qcom-cci.c b/drivers/i2c/busses/i2c-qcom-cci.c > index 4d64895a9e9e4e0bd5e0ccb5c3cc04b282b1e4d5..bdeda3979c4814b5cdb463734b8361da7fffa879 100644 > --- a/drivers/i2c/busses/i2c-qcom-cci.c > +++ b/drivers/i2c/busses/i2c-qcom-cci.c > @@ -492,24 +492,8 @@ static int __maybe_unused cci_resume_runtime(struct device *dev) > return 0; > } > > -static int __maybe_unused cci_suspend(struct device *dev) > -{ > - if (!pm_runtime_suspended(dev)) > - return cci_suspend_runtime(dev); > - > - return 0; > -} > - > -static int __maybe_unused cci_resume(struct device *dev) > -{ > - cci_resume_runtime(dev); > - pm_request_autosuspend(dev); > - > - return 0; > -} > - > static const struct dev_pm_ops qcom_cci_pm = { > - SET_SYSTEM_SLEEP_PM_OPS(cci_suspend, cci_resume) > + SET_SYSTEM_SLEEP_PM_OPS(pm_runtime_force_suspend, pm_runtime_force_resume) > SET_RUNTIME_PM_OPS(cci_suspend_runtime, cci_resume_runtime, NULL) > }; > Reviewed-by: Vladimir Zapolskiy -- Best wishes, Vladimir