From: Hao Jia <jiahao.os@bytedance.com>
To: Phil Auld <pauld@redhat.com>
Cc: mingo@redhat.com, peterz@infradead.org, mingo@kernel.org,
juri.lelli@redhat.com, vincent.guittot@linaro.org,
dietmar.eggemann@arm.com, rostedt@goodmis.org,
bsegall@google.com, mgorman@suse.de, bristot@redhat.com,
vschneid@redhat.com, linux-kernel@vger.kernel.org
Subject: Re: [External] Re: [PATCH 0/2] Fix nohz_full vs rt bandwidth
Date: Fri, 8 Sep 2023 10:57:26 +0800 [thread overview]
Message-ID: <bd786914-4718-7a35-fcc1-9cdee58d2f06@bytedance.com> (raw)
In-Reply-To: <20230907141703.GA441901@lorien.usersys.redhat.com>
On 2023/9/7 Phil Auld wrote:
> Hi Hao,
>
> On Wed, Sep 06, 2023 at 02:45:39PM +0800 Hao Jia wrote:
>>
>> Friendly ping...
>>
>> On 2023/8/21 Hao Jia wrote:
>>> Since the commit 88c56cfeaec4 ("sched/fair: Block nohz tick_stop
>>> when cfs bandwidth in use") was merged, it handles conflicts between
>>> NOHZ full and cfs_bandwidth well, and the scheduler feature HZ_BW
>>> allows us to choose which one to prefer.
>>>
>>> This conflict also exists between NOHZ full and rt_bandwidth,
>>> these two patches try to handle it in a similar way.
>>>
>
> Are you actually hitting this in the real world?
>
> We, for example, no longer enable RT_GROUP_SCHED so this is a non-issue
> for our use cases. I'd recommend considering that. (Does it even
> work with cgroup2?)
>
Yes, it has always been there. Regardless of whether RT_GROUP_SCHED is
enabled or not, rt bandwidth is always enabled. If RT_GROUP_SCHED is not
enabled, all rt tasks in the system are a group, and rt_runtime is
950000, and rt_period is 1000000.So rt bandwidth is always enabled by
default.
Thanks,
Hao
> In some ways what you have is a simplification of code, but it also
> obfuscates the stop_tick conditions by hiding them all in the class
> specific functions. It was easier to see why the tick didn't stop
> looking at the original code.
>
> It would be better to do this only if it is really needed, in my opinion.
>
>
> Cheers,
> Phil
>
>>> patch1: Extracts a can_stop_tick() callback function for each
>>> sched_class from sched_can_stop_tick(), it will make things clearer
>>> and also convenient to handle the conflict between NOHZ full
>>> and rt_bandwidth.
>>>
>>> patch2: If the HZ_BW scheduler feature is enabled, and the RT task
>>> to be run is constrained by rt_bandwidth runtime. Then it will
>>> prevent NO_HZ full from stopping tick.
>>>
>>> Hao Jia (2):
>>> sched/core: Introduce sched_class::can_stop_tick()
>>> sched/rt: Block nohz tick_stop when rt bandwidth in use
>>>
>>> kernel/sched/core.c | 67 +++++--------------------------
>>> kernel/sched/deadline.c | 16 ++++++++
>>> kernel/sched/fair.c | 56 +++++++++++++++++++++++---
>>> kernel/sched/rt.c | 89 ++++++++++++++++++++++++++++++++++++++++-
>>> kernel/sched/sched.h | 5 ++-
>>> 5 files changed, 168 insertions(+), 65 deletions(-)
>>>
>>
>
next prev parent reply other threads:[~2023-09-08 2:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-21 9:49 Hao Jia
2023-08-21 9:49 ` [PATCH 1/2] sched/core: Introduce sched_class::can_stop_tick() Hao Jia
2023-08-24 7:43 ` kernel test robot
2023-08-21 9:49 ` [PATCH 2/2] sched/rt: Block nohz tick_stop when rt bandwidth in use Hao Jia
2023-09-06 6:45 ` [PATCH 0/2] Fix nohz_full vs rt bandwidth Hao Jia
2023-09-07 14:17 ` Phil Auld
2023-09-08 2:57 ` Hao Jia [this message]
2023-09-08 12:45 ` [External] " Phil Auld
2023-09-11 3:39 ` Hao Jia
2023-09-11 13:25 ` Phil Auld
2023-09-12 2:35 ` Hao Jia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bd786914-4718-7a35-fcc1-9cdee58d2f06@bytedance.com \
--to=jiahao.os@bytedance.com \
--cc=bristot@redhat.com \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@kernel.org \
--cc=mingo@redhat.com \
--cc=pauld@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=vincent.guittot@linaro.org \
--cc=vschneid@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®