Re: linux-next: build failure after merge of the i2c-host tree

[Qianfeng Rong <rongqianfeng@vivo.com>]

在 2025/7/4 10:02, Stephen Rothwell 写道:
> Hi all,
>
> After merging the i2c-host tree, today's linux-next build (arm
> multi_v7_defconfig) failed like this:
>
> In file included from <command-line>:
> drivers/i2c/busses/i2c-st.c: In function 'st_i2c_rd_fill_tx_fifo':
> include/linux/compiler_types.h:568:45: error: call to '__compiletime_assert_369' declared with attribute error: min(max, 0x8 - tx_fstat) signedness error
>    568 |         _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
>        |                                             ^
> include/linux/compiler_types.h:549:25: note: in definition of macro '__compiletime_assert'
>    549 |                         prefix ## suffix();                             \
>        |                         ^~~~~~
> include/linux/compiler_types.h:568:9: note: in expansion of macro '_compiletime_assert'
>    568 |         _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
>        |         ^~~~~~~~~~~~~~~~~~~
> include/linux/build_bug.h:39:37: note: in expansion of macro 'compiletime_assert'
>     39 | #define BUILD_BUG_ON_MSG(cond, msg) compiletime_assert(!(cond), msg)
>        |                                     ^~~~~~~~~~~~~~~~~~
> include/linux/minmax.h:93:9: note: in expansion of macro 'BUILD_BUG_ON_MSG'
>     93 |         BUILD_BUG_ON_MSG(!__types_ok(ux, uy),           \
>        |         ^~~~~~~~~~~~~~~~
> include/linux/minmax.h:98:9: note: in expansion of macro '__careful_cmp_once'
>     98 |         __careful_cmp_once(op, x, y, __UNIQUE_ID(x_), __UNIQUE_ID(y_))
>        |         ^~~~~~~~~~~~~~~~~~
> include/linux/minmax.h:105:25: note: in expansion of macro '__careful_cmp'
>    105 | #define min(x, y)       __careful_cmp(min, x, y)
>        |                         ^~~~~~~~~~~~~
> drivers/i2c/busses/i2c-st.c:453:13: note: in expansion of macro 'min'
>    453 |         i = min(max, SSC_TXFIFO_SIZE - tx_fstat);
>        |             ^~~
>
> Caused by commit
>
>    cbae4d3dd2f7 ("i2c: busses: Use min() to improve code")
>
> I have used the i2c-host tree from next-20250703 for today.

Hi all,

I'm sorry, I made a mistake,  can anyone help to roll back this patch?
But I want to ask if it's because I didn't compile with W=1 and didn't 
find this compilation error locally？
Anyway, I will learn from this lesson and be more careful in subsequent 
submissions.

Best regards,
Qianfeng
>