From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 15CB42F99BE for ; Thu, 27 Nov 2025 18:04:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764266688; cv=none; b=D2T45EDZnOdsbkLdsVTclUcy6WcntLxDCsB5eax9kZ7sXcumRsZDVqgj6B1NjGxF5cDQ4BS4yi/0vKQnT9f4TTvNUlM9oS27Nh3E7x+i1yEBlpS5cNYrZhI7oIpyyuTOuIFZRWEyFjvLjLmJqBuyXB1z2kPgvYmWgVxOMfkCatI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764266688; c=relaxed/simple; bh=Q5m9Rg7X+gTa1EqvJjkLkG0J4LPmpAD2f3XFaMHnOJw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=LEZYz/QFnI5RtwkJcbpAZWf37Bc6uwvy6c1+R75r9u6AJZiETmATaYEfvEeYfZCLTDX17dBY//OymhruelR0Vqi6j7CrSddXflJscS2YWRXlt33lkfh3qA4v9m7lVg5gHN9eXKWAEokzobNYQ0vozHqm4v8Ro7Qka4s1ocZX4B8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=vXbVKTlC; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=xvq9ax3j; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=mY6fs0zl; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=Xb7ggsTG; arc=none smtp.client-ip=195.135.223.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="vXbVKTlC"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="xvq9ax3j"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="mY6fs0zl"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="Xb7ggsTG" Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 3B1B05BCD1; Thu, 27 Nov 2025 18:04:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1764266684; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SrVsWQvex/RQgwIgu4ehjepQn/x496uMZqhNRNqpUPo=; b=vXbVKTlCacXhBu7F2ytOj/2lBybiCANUMgsDD0HROYFHHenFyYS5JTuZxueIIcMqADo8Ex p8AVjaBLNKZ6+JFrHgrBcLWBVIM7s9dYldMKEgTo1Gjw+U9e/F+Xc97JBhx8IXYRAiqRJq LL4Tpc+//HCFiaHhJv5gqYrD0VRfVrc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1764266684; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SrVsWQvex/RQgwIgu4ehjepQn/x496uMZqhNRNqpUPo=; b=xvq9ax3jNpISVzlywrjDbV9MJv4PDcQvvyYogvnnTzRYouAqDXwQSPgrwQRwHWcGyQY4LK P5K6mZjePP/aGUDw== Authentication-Results: smtp-out2.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=mY6fs0zl; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=Xb7ggsTG DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1764266683; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SrVsWQvex/RQgwIgu4ehjepQn/x496uMZqhNRNqpUPo=; b=mY6fs0zlXPu0wSk/NrVdihuBZYQ9EZvkrjI0RrUFg1o/3QBONYlJUCjb1BeIY2rwQtwZeT nZTsvbvpaxNBIVs4I4K2EQE6j4mJwSpr5uGZdlq9sw1QIobABqUzDL4wQNzKxoih6Qrgve WkdjndsS7cZEOZ3NKxlAP8txQ9j6aCA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1764266683; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SrVsWQvex/RQgwIgu4ehjepQn/x496uMZqhNRNqpUPo=; b=Xb7ggsTG0oaDn75vqt8RM2xc1q+B8ahv/LO3G8opieTezUFRBQxFGmO05cRQGOQrSYolOh V1eyW/tDfUrkuiAQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id C3AC83EA63; Thu, 27 Nov 2025 18:04:42 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id VjnFLbqSKGmfXwAAD6G6ig (envelope-from ); Thu, 27 Nov 2025 18:04:42 +0000 Message-ID: Date: Thu, 27 Nov 2025 19:04:42 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/4] nvme: reject invalid pr_read_keys() num_keys values To: Stefan Hajnoczi , linux-block@vger.kernel.org Cc: Keith Busch , "Martin K. Petersen" , linux-kernel@vger.kernel.org, "James E.J. Bottomley" , Christoph Hellwig , Mike Christie , linux-nvme@lists.infradead.org, Jens Axboe , linux-scsi@vger.kernel.org, Sagi Grimberg References: <20251127155424.617569-1-stefanha@redhat.com> <20251127155424.617569-3-stefanha@redhat.com> Content-Language: en-US From: Hannes Reinecke In-Reply-To: <20251127155424.617569-3-stefanha@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spamd-Result: default: False [-4.51 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; RCVD_VIA_SMTP_AUTH(0.00)[]; MIME_TRACE(0.00)[0:+]; ARC_NA(0.00)[]; RCPT_COUNT_TWELVE(0.00)[12]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_TLS_ALL(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo,imap1.dmz-prg2.suse.org:rdns,suse.de:mid,suse.de:email,suse.de:dkim]; DNSWL_BLOCKED(0.00)[2a07:de40:b281:106:10:150:64:167:received]; DKIM_TRACE(0.00)[suse.de:+] X-Rspamd-Action: no action X-Spam-Flag: NO X-Spam-Score: -4.51 X-Spam-Level: X-Rspamd-Server: rspamd1.dmz-prg2.suse.org X-Rspamd-Queue-Id: 3B1B05BCD1 On 11/27/25 16:54, Stefan Hajnoczi wrote: > The pr_read_keys() interface has a u32 num_keys parameter. The NVMe > Reservation Report command has a u32 maximum length. Reject num_keys > values that are too large to fit. > > This will become important when pr_read_keys() is exposed to untrusted > userspace via an ioctl. > > Signed-off-by: Stefan Hajnoczi > --- > drivers/nvme/host/pr.c | 4 ++++ > 1 file changed, 4 insertions(+) > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke Kernel Storage Architect hare@suse.de +49 911 74053 688 SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich