From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f178.google.com (mail-pf1-f178.google.com [209.85.210.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 725AB477E4B for ; Wed, 17 Jun 2026 10:37:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781692665; cv=none; b=Mvw9RZpDndZ5l2AjDzbiZhJ6O6s8Tes+2+akmSWbHEJbc6ZvJ1rfacEb6j/fPV4AmEAWbqEEQgNoMAR7vLdbcuatkiFKaUHzn/HsDF8PjOL538msXchAuikq3yYoE4J99bpDHklCNMe+ImZn4rMTczI53j88fj3pKls+PmlWCvY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781692665; c=relaxed/simple; bh=vALBa141v9+4vjbm0tDzeCmo10QrWJe8iyZLknBjxgQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=lO7QOfTtctmmKl2U6mR+QfSV98y7urappzbOfmZFUroZ8h5huBQCDT6j/UD9ZL8dSFUY6P7vI5SY+ip51biv4t6alENG9V6Fa00zgob+pufC8YkTwATpBqo5LxtD7H+bmazdhkUJGfpI203ZjHxQodTgxvfaEZU7BXNwZUS587g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=E1YmmjYD; arc=none smtp.client-ip=209.85.210.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="E1YmmjYD" Received: by mail-pf1-f178.google.com with SMTP id d2e1a72fcca58-8453427d3f4so17485b3a.3 for ; Wed, 17 Jun 2026 03:37:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781692657; x=1782297457; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=AhUWEjlecPu7hlJvyuwWPRxl2TYmG2bGNVOKZVs0d90=; b=E1YmmjYDjCUx9OJ3ntJZw/6fpoMkUtMDaBpQkhkwZsHP8jc4Q4qCqd51Dz9g5oLhFT DKEcwsg28cmEhDTRqov5vllPZZOeUDXLb3Vvyv/um6sKdzpRdybDlvDLzDIRxuKJgHaS YVOB7ewjj9yZ+fSMWUVfX1ntJxShCLCCVO3AOVx506Z/mhQ3pZjcGOoaDVUlej2VclYW XhCnQURpfN+32uSxJovqD60JWiotlpf+S2Tp1ZVopyIeeQ1yBYG035FrADRVIY7o/4gV 0rtp7CC1pCpBaPNDCbdSs5qsENh+ygCl2GEXD37UuJW4q5jfV3eh6ooupMMjfdhzYt+A NDjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781692657; x=1782297457; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=AhUWEjlecPu7hlJvyuwWPRxl2TYmG2bGNVOKZVs0d90=; b=Z2QHpxaylVaw92X/WqjgOk9NUZItS4+jIV+u+v4fh+AhBUOOM+2zHQb+il9G4L/iWg rEIqLWkM+Jzk2o9WKek7Smy8C5Q3pQ4T7EKD8tjScqe+oiQ1xuhz8T4ueVqMd5PUvWil 6o9PAvLmy/SHaGLhHm/CAhFby1EoZ9lPaoJfSYKxhKfLdS3yfuBtFcjS3DblQNKNF9zY oKj+3+FBG+HiUTuCAHgWCFkEVp0MPDRNCq3FRnckhhWKqipTZ9rUTgMGgSXh7LBtcDff A80b0n4mRKJtEJCjhnk3SPltC+UIuvrSMtTwNLvEsZ6zNa7L0qwlcqlImfoGyXAk7O6u 0g2Q== X-Forwarded-Encrypted: i=1; AFNElJ8dY+1468kZ1YsCjybvH2HAVmi0jW4cUvq/7AcbLqrlIXMRSK4ZP6FFswQ0ciXxqwYEkkSM1Gd3+Pqdyjg=@vger.kernel.org X-Gm-Message-State: AOJu0YxgAaRMJHpo/0C1XupzycWwa96u2LON5zTVbLtOWV1/73puDZlY EsXRDUA4RRVaW2nOCrA1QWWkOdAqA93U3QUT0oiC0jJVD9FJcesDcMJo X-Gm-Gg: Acq92OE0krcGhHiIFGi/y04+pzRBZsew1Yg4euEwJAYb7F5abdJmpnbv19icicNC8pQ 7DLus3pm69TVW90ZddN0QLG+SUhYedvfjHO4eR0YqblXDcJvJQwpBjcqjWNbvhiRyeODPeGEC4j 6jZ5e7JKlpPJixFOlg1QpdBQNL0aAXzo8Ai2TSrT8WOgYuKpg2Y+MQZfk6crM3gS2FHPFiETDLD 1T4BkYeUfDdFZ9IWxWWmgdyKfyn54MxLTRBuMISSQLvPSu2Hn0KSc+mrcAcNv2lHkQf3dXN7t8H PA2rRCKoDL7AJL1qt3gKNqRANNtyZeC9n0rMaklyhKr4VEt6OM9wxDGSFqjTrllbT7JCFf2ZOeC ySV2adFhEa53iVVpsEb0JRH6/dClHA4OVWQWGB+rLe9Zvaos+vPOf4jh40LDpIAdecTByqw/PYk x9k8y5rslipjf4e2UHRAz0fBRMENqNRR0sjhNctnYO6AaRVKiKHFZJBgxE2/mxRhI4QYskFCW2g znN X-Received: by 2002:a05:6a00:10d5:b0:842:4a39:6047 with SMTP id d2e1a72fcca58-84524550f44mr3301789b3a.29.1781692657527; Wed, 17 Jun 2026 03:37:37 -0700 (PDT) Received: from [192.168.0.100] (60-250-196-139.hinet-ip.hinet.net. [60.250.196.139]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-8434ad03fdcsm15269159b3a.24.2026.06.17.03.37.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 17 Jun 2026 03:37:37 -0700 (PDT) Message-ID: Date: Wed, 17 Jun 2026 18:37:33 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 5/6] drm/verisilicon: add DCUltraLite chip identity to HWDB To: Icenowy Zheng , maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org Cc: ychuang3@nuvoton.com, schung@nuvoton.com, yclu4@nuvoton.com, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20260615065003.76661-1-a0987203069@gmail.com> <20260615065003.76661-6-a0987203069@gmail.com> <62c0b8ab9b6d9f994daa8bb60b3b626688af7d5e.camel@iscas.ac.cn> Content-Language: en-US From: Joey Lu In-Reply-To: <62c0b8ab9b6d9f994daa8bb60b3b626688af7d5e.camel@iscas.ac.cn> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 6/15/2026 4:57 PM, Icenowy Zheng wrote: > 在 2026-06-15一的 14:50 +0800，Joey Lu写道： >> Register the Nuvoton MA35D1 DCUltraLite chip identity in >> vs_chip_identities[]: >>   model       = 0x0   (DCUltraLite; Verisilicon uses 0 for this IP) >>   revision    = 0x5560 >>   customer_id = 0x305 >>   generation  = VSDC_GEN_DC8000 >>   display_count = 1 >>   max_cursor_size = 32 > I suggest make this more human-readable instead of replicating the > machine-readable data of HWDB. > > My proposal here: > > ``` > The Nuvoton MA35D1 chip contains a DCUltraLite display controller with > model number 0x0 (sic, the model name contains no number either), > revision 0x5560 and customer ID 0x305. It has a similar register map > with DC8000, only one display output and only 32x32 cursor supported. > ``` Thanks. I will use your proposed wording for the commit message in v5 >> Placing this entry last makes it the gate that enables MA35D1 >> hardware >> recognition only after all the supporting ops and DT binding changes >> are >> in place. > It's a little ambiguous that "last" here means whether the last in the > patchset or the last in the HWDB array, although I think it's not so > needed to explain the reason of the place in the patchset. > > I propose just say `Adding it to the HWDB to enable it to be usable > with the verisilicon driver.` . I will simplify the placement sentence to "Adding it to the HWDB to enable it to be usable with the verisilicon driver." in v5. >> Signed-off-by: Joey Lu >> --- >>  drivers/gpu/drm/verisilicon/vs_hwdb.c | 10 ++++++++++ >>  1 file changed, 10 insertions(+) >> >> diff --git a/drivers/gpu/drm/verisilicon/vs_hwdb.c >> b/drivers/gpu/drm/verisilicon/vs_hwdb.c >> index 91524d16f778..7d630a667a3f 100644 >> --- a/drivers/gpu/drm/verisilicon/vs_hwdb.c >> +++ b/drivers/gpu/drm/verisilicon/vs_hwdb.c >> @@ -129,6 +129,16 @@ static struct vs_chip_identity >> vs_chip_identities[] = { >>   .max_cursor_size = 64, >>   .formats = &vs_formats_no_yuv444, >>   }, >> + { >> + .model = 0x0, /* DCUltraLite */ >> + .revision = 0x5560, >> + .customer_id = 0x305, >> + >> + .generation = VSDC_GEN_DC8000, >> + .display_count = 1, >> + .max_cursor_size = 32, >> + .formats = &vs_formats_no_yuv444, >> + }, >>  }; >> >>  int vs_fill_chip_identity(struct regmap *regs,