From: Damien Le Moal <dlemoal@kernel.org>
To: Colin Ian King <colin.i.king@gmail.com>,
Niklas Cassel <cassel@kernel.org>,
linux-ide@vger.kernel.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH][next] ata: pata_pdc2027x: Remove space before newline
Date: Thu, 31 Jul 2025 13:13:14 +0900 [thread overview]
Message-ID: <bd906cd8-a278-4b07-a6b8-947865c6267a@kernel.org> (raw)
In-Reply-To: <20250730110813.2059223-1-colin.i.king@gmail.com>
On 7/30/25 8:08 PM, Colin Ian King wrote:
> There is a extraneous space before a newline in handful of ata_port_dbg
> messages. Remove the spaces.
While at it, please capitalize pio, udma and mdma in these messages. These are
abreviations and capital letters make that clear.
>
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
> ---
> drivers/ata/pata_pdc2027x.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/ata/pata_pdc2027x.c b/drivers/ata/pata_pdc2027x.c
> index d792ce6d97bf..021b38ed794d 100644
> --- a/drivers/ata/pata_pdc2027x.c
> +++ b/drivers/ata/pata_pdc2027x.c
> @@ -295,7 +295,7 @@ static void pdc2027x_set_piomode(struct ata_port *ap, struct ata_device *adev)
> }
>
> /* Set the PIO timing registers using value table for 133MHz */
> - ata_port_dbg(ap, "Set pio regs... \n");
> + ata_port_dbg(ap, "Set pio regs...\n");
>
> ctcr0 = ioread32(dev_mmio(ap, adev, PDC_CTCR0));
> ctcr0 &= 0xffff0000;
> @@ -308,7 +308,7 @@ static void pdc2027x_set_piomode(struct ata_port *ap, struct ata_device *adev)
> ctcr1 |= (pdc2027x_pio_timing_tbl[pio].value2 << 24);
> iowrite32(ctcr1, dev_mmio(ap, adev, PDC_CTCR1));
>
> - ata_port_dbg(ap, "Set to pio mode[%u] \n", pio);
> + ata_port_dbg(ap, "Set to pio mode[%u]\n", pio);
> }
>
> /**
> @@ -341,7 +341,7 @@ static void pdc2027x_set_dmamode(struct ata_port *ap, struct ata_device *adev)
> iowrite32(ctcr1 & ~(1 << 7), dev_mmio(ap, adev, PDC_CTCR1));
> }
>
> - ata_port_dbg(ap, "Set udma regs... \n");
> + ata_port_dbg(ap, "Set udma regs...\n");
>
> ctcr1 = ioread32(dev_mmio(ap, adev, PDC_CTCR1));
> ctcr1 &= 0xff000000;
> @@ -350,14 +350,14 @@ static void pdc2027x_set_dmamode(struct ata_port *ap, struct ata_device *adev)
> (pdc2027x_udma_timing_tbl[udma_mode].value2 << 16);
> iowrite32(ctcr1, dev_mmio(ap, adev, PDC_CTCR1));
>
> - ata_port_dbg(ap, "Set to udma mode[%u] \n", udma_mode);
> + ata_port_dbg(ap, "Set to udma mode[%u]\n", udma_mode);
>
> } else if ((dma_mode >= XFER_MW_DMA_0) &&
> (dma_mode <= XFER_MW_DMA_2)) {
> /* Set the MDMA timing registers with value table for 133MHz */
> unsigned int mdma_mode = dma_mode & 0x07;
>
> - ata_port_dbg(ap, "Set mdma regs... \n");
> + ata_port_dbg(ap, "Set mdma regs...\n");
> ctcr0 = ioread32(dev_mmio(ap, adev, PDC_CTCR0));
>
> ctcr0 &= 0x0000ffff;
> @@ -366,7 +366,7 @@ static void pdc2027x_set_dmamode(struct ata_port *ap, struct ata_device *adev)
>
> iowrite32(ctcr0, dev_mmio(ap, adev, PDC_CTCR0));
>
> - ata_port_dbg(ap, "Set to mdma mode[%u] \n", mdma_mode);
> + ata_port_dbg(ap, "Set to mdma mode[%u]\n", mdma_mode);
> } else {
> ata_port_err(ap, "Unknown dma mode [%u] ignored\n", dma_mode);
> }
--
Damien Le Moal
Western Digital Research
prev parent reply other threads:[~2025-07-31 4:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-30 11:08 Colin Ian King
2025-07-31 4:13 ` Damien Le Moal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bd906cd8-a278-4b07-a6b8-947865c6267a@kernel.org \
--to=dlemoal@kernel.org \
--cc=cassel@kernel.org \
--cc=colin.i.king@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®