From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751432AbdJWMLZ (ORCPT ); Mon, 23 Oct 2017 08:11:25 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:40586 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751116AbdJWMLY (ORCPT ); Mon, 23 Oct 2017 08:11:24 -0400 Subject: Re: [PATCH 0/3] s390 refcount conversions To: Elena Reshetova , linux-s390@vger.kernel.org Cc: linux-kernel@vger.kernel.org, schwidefsky@de.ibm.com, heiko.carstens@de.ibm.com, ubraun@linux.vnet.ibm.com, peterz@infradead.org, keescook@chromium.org References: <1508485670-24070-1-git-send-email-elena.reshetova@intel.com> From: Julian Wiedmann Date: Mon, 23 Oct 2017 14:11:13 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <1508485670-24070-1-git-send-email-elena.reshetova@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 x-cbid: 17102312-0008-0000-0000-000004A2EDB0 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17102312-0009-0000-0000-00001E355327 Message-Id: X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-10-23_03:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=2 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000 definitions=main-1710230175 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/20/2017 09:47 AM, Elena Reshetova wrote: > This series, for S390, replaces atomic_t reference > counters with the new refcount_t type and API (see include/linux/refcount.h). > By doing this we prevent intentional or accidental > underflows or overflows that can led to use-after-free vulnerabilities. > > The patches are fully independent and can be cherry-picked separately. > Patches are based on top of linux-next as of yesterday. > If there are no objections to the patches, please merge them via respective trees > > Elena Reshetova (3): > [S390] vmur: convert urdev.ref_count from atomic_t to refcount_t > [S390] net: convert lcs_reply.refcnt from atomic_t to refcount_t > [S390] qeth: convert qeth_reply.refcnt from atomic_t to refcount_t > > drivers/s390/char/vmur.c | 8 ++++---- > drivers/s390/char/vmur.h | 4 +++- > drivers/s390/net/lcs.c | 10 +++++----- > drivers/s390/net/lcs.h | 3 ++- > drivers/s390/net/qeth_core.h | 3 ++- > drivers/s390/net/qeth_core_main.c | 10 +++++----- > 6 files changed, 21 insertions(+), 17 deletions(-) > Thanks Elena, I picked up the two network patches. Also removed the WARN_ONs while applying, those who care may use CONFIG_REFCOUNT_FULL.