From: Daniel Wagner <dwagner@suse.de>
To: Christoph Hellwig <hch@lst.de>
Cc: Daniel Wagner <wagi@kernel.org>, Keith Busch <kbusch@kernel.org>,
John Meneghini <jmeneghi@redhat.com>,
Bryan Gurney <bgurney@redhat.com>,
linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] nvme: drop bogus nid quirk for multipath devices which passed id test
Date: Wed, 29 Oct 2025 10:45:57 +0100 [thread overview]
Message-ID: <bd91a6c1-cefc-43e2-8dd8-48b7ea241ded@flourine.local> (raw)
In-Reply-To: <20251029074403.GA30412@lst.de>
On Wed, Oct 29, 2025 at 08:44:03AM +0100, Christoph Hellwig wrote:
> But more imporantly dropping the quirk for multipath devices is
> fundamentally the wrong thing to do, as we really need proper IDs for
> multipathing. So just add another entry for the Dell device using
> the dell subvendor/subdevice id that does not have the quirk.
The problem it is not possible to distinguish between the two devices
based on subvendor/subdevice ids. I've tried to find some way to keep
those two devices apart, serial numbers but I don't think there is
something usable. Thus the idea to rely our own sanity checks and
enable the feature if these pass.
next prev parent reply other threads:[~2025-10-29 9:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-28 12:54 Daniel Wagner
2025-10-29 7:44 ` Christoph Hellwig
2025-10-29 9:45 ` Daniel Wagner [this message]
2025-10-29 9:59 ` Christoph Hellwig
2025-10-29 10:14 ` Daniel Wagner
2025-10-29 13:38 ` Christoph Hellwig
2025-11-05 7:33 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bd91a6c1-cefc-43e2-8dd8-48b7ea241ded@flourine.local \
--to=dwagner@suse.de \
--cc=bgurney@redhat.com \
--cc=hch@lst.de \
--cc=jmeneghi@redhat.com \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=wagi@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®