mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: KY Srinivasan <kys@microsoft.com>
To: Jason Wang <jasowang@redhat.com>,
	"tglx@linutronix.de" <tglx@linutronix.de>,
	"mingo@redhat.com" <mingo@redhat.com>,
	"hpa@zytor.com" <hpa@zytor.com>,
	"x86@kernel.org" <x86@kernel.org>,
	"gleb@redhat.com" <gleb@redhat.com>,
	"pbonzini@redhat.com" <pbonzini@redhat.com>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH 4/4] x86: properly handle kvm emulation of hyperv
Date: Tue, 23 Jul 2013 13:55:17 +0000	[thread overview]
Message-ID: <bd93bc49300a4d99996cc4f57c19a008@SN2PR03MB061.namprd03.prod.outlook.com> (raw)
In-Reply-To: <1374572465-15278-4-git-send-email-jasowang@redhat.com>



> -----Original Message-----
> From: Jason Wang [mailto:jasowang@redhat.com]
> Sent: Tuesday, July 23, 2013 5:41 AM
> To: tglx@linutronix.de; mingo@redhat.com; hpa@zytor.com; x86@kernel.org;
> gleb@redhat.com; pbonzini@redhat.com; kvm@vger.kernel.org; linux-
> kernel@vger.kernel.org
> Cc: Jason Wang; KY Srinivasan
> Subject: [PATCH 4/4] x86: properly handle kvm emulation of hyperv
> 
> Recent kvm has some basic support of hyperv, this will cause the guest to
> identify itself as running on top of hyperv instead of kvm which will disable
> kvm pv functionality. This is because we try to detect hyperv before kvm. Solve
> this by simply checking kvm in detect_hypervisor() first.
> 

This strategy of hypervisor detection based on some detection order IMHO is not
a robust detection strategy. The current scheme works since the only hypervisor emulated
(by other hypervisors happens to be Hyper-V). What if this were to change.

Regards,

K. Y




  parent reply	other threads:[~2013-07-23 13:56 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-23  9:41 [PATCH 1/4] x86: introduce hypervisor_cpuid_base() Jason Wang
2013-07-23  9:41 ` [PATCH 2/4] xen: switch to use hypervisor_cpuid_base() Jason Wang
2013-07-23 11:16   ` Paolo Bonzini
2013-07-23 15:55   ` Konrad Rzeszutek Wilk
2013-07-23  9:41 ` [PATCH 3/4] kvm: " Jason Wang
2013-07-23 11:16   ` Paolo Bonzini
2013-07-23  9:41 ` [PATCH 4/4] x86: properly handle kvm emulation of hyperv Jason Wang
2013-07-23 11:17   ` Paolo Bonzini
2013-07-23 13:55   ` KY Srinivasan [this message]
2013-07-23 14:48     ` H. Peter Anvin
2013-07-23 17:45       ` KY Srinivasan
2013-07-23 18:45         ` H. Peter Anvin
2013-07-23 22:42           ` KY Srinivasan
2013-07-24  4:37       ` Jason Wang
2013-07-24  4:48         ` H. Peter Anvin
2013-07-24  6:54           ` Jason Wang
2013-07-24  7:06             ` Paolo Bonzini
2013-07-24 14:01               ` KY Srinivasan
2013-07-24 15:14                 ` H. Peter Anvin
2013-07-24 19:05                   ` KY Srinivasan
2013-07-24 21:37                     ` H. Peter Anvin
2013-07-25  7:59                       ` Paolo Bonzini
2013-07-25  8:12                         ` Jason Wang
2013-07-23 10:04 ` [PATCH 1/4] x86: introduce hypervisor_cpuid_base() H. Peter Anvin
2013-07-23 11:16   ` Paolo Bonzini
2013-07-23 16:03     ` H. Peter Anvin
2013-07-24  4:44       ` Jason Wang
2013-07-24  4:47         ` H. Peter Anvin
2013-07-23 13:48 ` Gleb Natapov
2013-07-24  4:34   ` Jason Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bd93bc49300a4d99996cc4f57c19a008@SN2PR03MB061.namprd03.prod.outlook.com \
    --to=kys@microsoft.com \
    --cc=gleb@redhat.com \
    --cc=hpa@zytor.com \
    --cc=jasowang@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®