From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f174.google.com (mail-lj1-f174.google.com [209.85.208.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C16F41CAA78 for ; Thu, 25 Jun 2026 07:05:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782371145; cv=none; b=efg86sCPIFxnNOxTb9f3NPqPXa/qFCp+0DENTsL0B0FxN1ZNouwMDTGL9ggyx4kxeGlFPdevlFtcBMXfTqaa4LfXkWelOcPSZ5cOwOp8OCPN28ZcwD7It3xFj5zaNdJgdJzLruVSWMt9vDWL+eq5bLf1gc/tONe/WCreWVg7GFg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782371145; c=relaxed/simple; bh=hMwm8OC6yMV7o6k5gEjXCIGVhLhyVKJEh/qwAVYMJDs=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=GlXnj+oq8GjTeEh0Q5WrSehZXPyQRWSpV9xu6mDjAuIwCUKEmrSFFGoZwBKZGvgz9AefqEjAEy5o15DT8ctMG5AYSM7Q+P2SPVlkWaVK2YYmBomeH9NndmK5bt2koujK09RpcR553tci2FPmlGvPeO8IvCP1wUXPKpl4/Z0WAHs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=kjGa/KDT; arc=none smtp.client-ip=209.85.208.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="kjGa/KDT" Received: by mail-lj1-f174.google.com with SMTP id 38308e7fff4ca-39975111d57so11872811fa.2 for ; Thu, 25 Jun 2026 00:05:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782371141; x=1782975941; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=lpu3IC4RSA2zDkdsuH0CS1/1RfLLmW5/oNEdfMnmxUI=; b=kjGa/KDTab7ZHSnmJiwCEfT9thordCzwXAsK6WjDJ6nO8gQJtu7E3aMtdgw9grXakZ bqHhoAQs9BKoAdFB9bdnnQ0rFphHeXshPfRmZx07hBXT3dw1tVRoHYfw5fDAYrJytNNb K965hKhwDQzh2G9bHsbTfIA9sDDU+2/qEAfR3dVSRmsFQ/mfRDBrayq46jQFhRV7VIXI 6rXt4hqMbsxY6altS3ptbYrKqZoMvIPFY5SxNjyiLU4RI4pfc86alkqSsmdyF4KlZRA3 t1+F+8B91m42b6s5zg0FE0eZAGvlxMpWk4ij3bMOCPCn67AJm2mYFyCabNjcpkdDGRuX vwrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782371141; x=1782975941; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=lpu3IC4RSA2zDkdsuH0CS1/1RfLLmW5/oNEdfMnmxUI=; b=TJi+OL3Nr+8NfS4q2PQK7N96p/UDsMJ0H5G6B2gZLZQgmTi29CyGV5ZkgECzS0qdkS N1nNyVqwtnM1Q2yQFfw0LyWukFuWvh2CNWK9WPDB7P77fKGytgel9aQHG08tvBcIiRyf oj+CLkPVM+LkOnYACSgQBm9+75Z1B1z1rZO+AQs1bRnWWqtzzPyGAL81S/EVSBSJHikq psOLu58F48uJkE7tFc5nJ7xRd7R+W3+UhbdhWA+sz5HWKe4JJSbz+yMz5D3uZZGku6Fe rR2iPr5D/4FYDOZSI+uc1yR9YErUFB6ERFl/fLCVpK49edhx12AfpyCA1KrRJx2KEDNt 39Qg== X-Forwarded-Encrypted: i=1; AHgh+RqwjhjFtxafh1YC+Sd9NEUWVcBmupCLH2o1IM2a+taCVO9ZZ2fOB3PcPCWIDe46xXTMxcO7fTJB4E7Ur+8=@vger.kernel.org X-Gm-Message-State: AOJu0YzEoLSaAJQ6gDbRSCtImh74CDuc11lp6K2vrlCf8X9tkuUCoQDD Sv8FRejfFbVqYk8onFusWvRpavqGcc71ABveBbLLrgNaMLkWBfW5zA5e X-Gm-Gg: AfdE7ckqEtcfqnCKN7qqbHKpkD13HEZdc47509YDtZQHwO1wone9Lj786D9T1Oylm0p Rqf1NHRz0mOB1zxeY1R2pWi/S6RQxZSCUKU2LBsllA6nJH0pR6X1F7Feu8iNRB8Feh+cYUKWzfe lOFtXNz5zftPCUx8ZKy98mx/x/eBPwHegAiseb0G6LEK0ntGpII3Tmy8Z8+R5tcjAaZUfOo4IsH RqCxWqtF6asOcGRB+3tNAehmYZJqA+ZJIHyTB7RvZbw5bIetVVJLsvq55OlEfgr+Hm7+mUNmwjj Q41E2jYHJFAeUEtdu8YBZnwfTgm4p8NTb8PVNqeUo/ncLZquFSPhDMkwZsvqLqnsMPK9cllwLwc 3NxdO/s+f0Ulc/zhaxEzaT2DkfloYdEfEscAddo8gVDxwaMnhb7uoUYekpGNea8MgfK5/f/EWqs p3KEB82Vtr2fMnXdIrgCe0BQ== X-Received: by 2002:a05:6512:4405:b0:5aa:7779:803b with SMTP id 2adb3069b0e04-5aea1f2a590mr336006e87.5.1782371139184; Thu, 25 Jun 2026 00:05:39 -0700 (PDT) Received: from [10.38.18.54] ([213.255.186.37]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5ad6954a538sm2433685e87.7.2026.06.25.00.05.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 25 Jun 2026 00:05:36 -0700 (PDT) Message-ID: Date: Thu, 25 Jun 2026 10:05:35 +0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/7] dt-bindings: adm1275: ROHM BD12780 hot-swap controller To: Krzysztof Kozlowski Cc: Matti Vaittinen , Matti Vaittinen , Guenter Roeck , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jonathan Corbet , Shuah Khan , Wensheng Wang , Ashish Yadav , Kim Seer Paller , Cedric Encarnacion , Chris Packham , Yuxi Wang , Charles Hsu , ChiShih Tsai , linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org References: <20260617-uptight-sexy-hippo-f4bc62@quoll> Content-Language: en-US, en-AU, en-GB, en-BW From: Matti Vaittinen In-Reply-To: <20260617-uptight-sexy-hippo-f4bc62@quoll> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit I think I (almost) missed this review... Sorry for the belated reply. On 17/06/2026 13:28, Krzysztof Kozlowski wrote: > On Tue, Jun 16, 2026 at 09:35:35AM +0300, Matti Vaittinen wrote: > + >> + Datasheets: >> + https://fscdn.rohm.com/en/products/databook/datasheet/ic/power/power_switch/bd12780muv-lb-e.pdf >> + https://fscdn.rohm.com/en/products/databook/datasheet/ic/power/power_switch/bd12780amuv-lb-e.pdf >> + >> properties: >> compatible: >> - enum: >> - - adi,adm1075 >> - - adi,adm1272 >> - - adi,adm1273 >> - - adi,adm1275 >> - - adi,adm1276 >> - - adi,adm1278 >> - - adi,adm1281 >> - - adi,adm1293 >> - - adi,adm1294 >> - - silergy,mc09c >> + oneOf: >> + - items: >> + enum: > > > s/items/enum/, so: > > oneOf: > - enum: > .... Thanks Krzysztof. I am always so lost with these bindings. Giving the concrete suggestion(s) helps a lot! > >> + - adi,adm1075 >> + - adi,adm1272 >> + - adi,adm1273 >> + - adi,adm1275 >> + - adi,adm1276 >> + - adi,adm1278 >> + - adi,adm1281 >> + - adi,adm1293 >> + - adi,adm1294 >> + - rohm,bd12780 >> + - silergy,mc09c >> + >> +# Require BD12780 as a fall-back for BD12780A. > > No need for the comment, schema is quite explicit. Eh... I know it is explicit for one who fluently reads yaml. Not all of us do that :| (See my reply to the previous comment...) I am not sure the comment hurts - while I am sure it helps occasional binding reader like me. Can you please reconsider keeping the comment? Although, I am not sure if Guenter suggested me to drop the compatible for the bd12780a and only use the bd12780 - or if his comment only applied to the i2c IDs. https://lore.kernel.org/all/751cd5eb-104f-4445-a6d2-8119ad5d5660@roeck-us.net/ Well, I will keep the bd12780a compatible and drop the I2C ID unless something else is suggested. Again, the BD12780 and BD12780A do have different hardware properties (at least in I2C slave address selection pins), and while it doesn't really matter for the Linux drivers, the DT bindings should ideally be generic and not Linux specific. Yours, -- Matti. -- Matti Vaittinen Linux kernel developer at ROHM Semiconductors Oulu Finland ~~ When things go utterly wrong vim users can always type :help! ~~