From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933402AbdBHNTI (ORCPT ); Wed, 8 Feb 2017 08:19:08 -0500 Received: from mx07-00178001.pphosted.com ([62.209.51.94]:17515 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933127AbdBHNTC (ORCPT ); Wed, 8 Feb 2017 08:19:02 -0500 Subject: Re: [PATCH v2 13/16] net: stmmac: print phy information To: Corentin Labbe , , References: <20170208083121.27949-1-clabbe.montjoie@gmail.com> <20170208083121.27949-14-clabbe.montjoie@gmail.com> CC: From: Giuseppe CAVALLARO Message-ID: Date: Wed, 8 Feb 2017 14:18:52 +0100 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.1.0 MIME-Version: 1.0 In-Reply-To: <20170208083121.27949-14-clabbe.montjoie@gmail.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.75.127.51] X-ClientProxiedBy: SFHDAG8NODE1.st.com (10.75.127.22) To SFHDAG4NODE1.st.com (10.75.127.10) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-02-08_08:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/8/2017 9:31 AM, Corentin Labbe wrote: > When a PHY is found, printing which one was found (and which type/model) is > a good information to know. > > Signed-off-by: Corentin Labbe Acked-by: Giuseppe Cavallaro > --- > drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c > index cc88bdb..9805aa8 100644 > --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c > +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c > @@ -870,9 +870,7 @@ static int stmmac_init_phy(struct net_device *dev) > if (phydev->is_pseudo_fixed_link) > phydev->irq = PHY_POLL; > > - netdev_dbg(priv->dev, "%s: attached to PHY (UID 0x%x) Link = %d\n", > - __func__, phydev->phy_id, phydev->link); > - > + phy_attached_info(phydev); > return 0; > } > >