From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2AE9718DB35 for ; Tue, 24 Feb 2026 04:38:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771907906; cv=none; b=uFORG4IoDHagRONf6IGWMbTG7j4dICPjKDTNDSKYFbriDTdpIOZ1wQuK9uLwKXCe9lctHZmKpJM4rPZ9OE72zsY1SKVp4rV+CcRgYZwP7NzLtWb9qYqoyOLXAAggsykxIZ/OGfyJLg1jJ3ie2S5sjTx7Zz71RpptjBjf2GQxR20= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771907906; c=relaxed/simple; bh=L+V9FaRVwI0ogLsec6A/+K3J1bPQW8ZR/XZNdEmSxIo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=SxvNX+eygBEAAUyA6214nZSuODHaH9rJrcvljocc5EumBPD8HxcS+P7onLLK7u+T450vMzJGIL0s0KPVQBXZhXDCpz2UOxRFAAqLag0HMGiDMP+RNeBwaj3QL/EJQ4VG8z/gE0niENUQqhZvRCd62H6q20deySyCu1XoF5LQAl0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=QaF6czDj; arc=none smtp.client-ip=209.85.214.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="QaF6czDj" Received: by mail-pl1-f179.google.com with SMTP id d9443c01a7336-2ad9f2ee29aso2166465ad.1 for ; Mon, 23 Feb 2026 20:38:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771907904; x=1772512704; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=IaRG35L9+sKa70owQkokTSS20AIgRWvhgTDtPyL30l4=; b=QaF6czDj4Vszr+pzzffrxHXEgqJd+YCSsWUYYiQFEcmki/Hj1TxVnqO3Ku9D9RE6Kp qDI5KtdQ9GS+MkwVgSCtglQIoUnGdfAhPIohegSr3ydWOqShf6Hjkid9minp+MoeIhKE EVTigL8Yi50RtOfb9306kbX1Kyk56xGBF6C9WiR+gQ+VgNvCMFKbUj4fFtsNpk+t6zee qKXPhcA+TjeFZ3iK5NyU2Txg/1e91dePoo3HdfPC8C8A3S0JT/52g4d4jHihb8TtBAPs czXWNvHrBvVheJ01aL8K+RMqK+1TDFmDF58wXE58tdMdWtVbcqNstVIIRSc3LIrvSeXe M4Jw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771907904; x=1772512704; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=IaRG35L9+sKa70owQkokTSS20AIgRWvhgTDtPyL30l4=; b=cSeqyXm8NV7IHs/4oatEg3SOzrh+AzH8cXbVU2uPZE4t2rdyKmba7Om9SIAlfCm5a/ 5R4YL1rqyBuIvlYjpI8P1LwjsEhfVnzwnm2e8hyalxxH6DvsmVA0OqAVQXJ1XuREBP9g vMi0Ke2J9L5CF6uKZrQI3WvoFmbJdFl8TPHGLRKsYmGhZYJ+AQyWtLDgWxqzgikWY3Fi ABEg+SSDd7swQ8KvJYZ/FkKvuMxUPy+91fk7eWE/y+muIB1+kHzgoeRTv81XdJ4qspzX 8j1bxYZU6f0eENI25/kpyjcA30cLJZG4ye0Y7CqS1ywmotOtICHB3w7MZwjh4KCexkHc pRJQ== X-Forwarded-Encrypted: i=1; AJvYcCVUoICx5HOAf/7RLE2kBsBB+u1vMfarty196gTgnz5hyPeS3pJlGqDhFAoMTrmaiZXsJvHERoV1EHJOPuk=@vger.kernel.org X-Gm-Message-State: AOJu0Yw4CRbAvnc13FJAoK7aJmGUjPLem5Auh01Rasnk1Sg77u4fElb0 TgiNONROsPv65cQIjDNwJzUbfWa94RQ12c8+vU5Y3BbCEz92m+g7FwP7 X-Gm-Gg: ATEYQzyuRYl/znVWAcFEA2+/GHN6M2bbvwGv5KqytPq9gB5WEKw0KKlHk95qzbvnwyr xbM/Xqb3mtqTXFAyuhVdH45TC9KMU9p1rIxuqYvIT5VY6g5y1Z7/QsEu+FocJM+AKz80TAgrg/L JevMrQnIb4lQKbMvGDtVR+mpInc6FNRDkl+503DwhWkciNAH6DMxJ4ukWVOKPYvG59QtORZdQhx 16Uv8xuN0IicjpAsnRQys0/GXgpYTXZzb5KHKSK/jgx6zhxQqqwIQoimHx6UWRVIar82htMrAyZ 2lrZsiJ4TDu17CFV56GH2+8st55qtEtyj+whELLEHyxs6SsttFTj5UUegZGob33IZF7zJfrNGTa G+3vKrQwfgWauSlJHx9aE6dWEcQDfNF+rd4+DCzIMWM/8qGcO7Ckq32fqmBCPGUy+HrGjUfnXFm 3HRlIJZLvuDYv+sBx/zpCa2Ba9UQUK0ybzREvsU5o+bgJrvi/6pExMJ1eb/7vlgzS92RCmOmoRd GUi0c/7tYIAlZPXRiFHquO5NZPCojeRvJQDa/BULmUfuQw+VJjDUMWVm2MtBkSHlO5aWp0aRLyT aiObljKnylgq X-Received: by 2002:a17:902:d504:b0:2ad:ad0f:bbbe with SMTP id d9443c01a7336-2adad0fbdf7mr2732295ad.29.1771907904441; Mon, 23 Feb 2026 20:38:24 -0800 (PST) Received: from ?IPV6:2601:1c0:5780:9200:dc23:55cf:823b:5fde? ([2601:1c0:5780:9200:dc23:55cf:823b:5fde]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2ad7503d406sm85286315ad.75.2026.02.23.20.38.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 23 Feb 2026 20:38:24 -0800 (PST) Message-ID: Date: Mon, 23 Feb 2026 20:38:23 -0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] drm/panel: novatek-nt36672a: Convert to mipi_dsi_*_multi() helpers To: Doug Anderson Cc: sumit.semwal@linaro.org, neil.armstrong@linaro.org, jesszhan0024@gmail.com, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20260223043441.5295-1-chintanlike@gmail.com> Content-Language: en-US From: Chintan Patel In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit > > I won't insist since it's a matter of opinion, but IMO get rid of the > `err` local variable and consistently use `dsi_ctx.accum_err` to store > the error code in this function. Yeah, it's a bit awkward, but having > the separate `err` variable just makes it too easy to mess up and use > it. As one example of where that happened, see commit 61ce50fd8196 > ("drm/panel: jdi-lpm102a188a: Fix error code in jdi_panel_prepare()"). > > Also: instead of returning right away, I think you want to make sure > that the GPIO gets set to 0 like the old code did, don't you? I'd be a > little hesitant changing this unless we can truly prove that the GPIO > set is not needed or unless we're certain that the GPIO set was > incorrect (in which case we should fix it in a separate patch). > > ...nicely, if you use `dsi_ctx.accum_err` you don't even need a > "goto". You can just let the "_multi" functions all run and be > no-ops... > > -Doug Thank you Doug! Those were good points! Will work on v2.