From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1763272AbdAKJbh (ORCPT ); Wed, 11 Jan 2017 04:31:37 -0500 Received: from youngberry.canonical.com ([91.189.89.112]:46561 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1763229AbdAKJbf (ORCPT ); Wed, 11 Jan 2017 04:31:35 -0500 Subject: Re: [PATCH v1] scsi: ufs: fix arguments order some trace calls To: Subhash Jadavani , vinholikatti@gmail.com, jejb@linux.vnet.ibm.com, martin.petersen@oracle.com References: <1484095705-3962-1-git-send-email-subhashj@codeaurora.org> Cc: linux-scsi@vger.kernel.org, open list From: Colin Ian King Message-ID: Date: Wed, 11 Jan 2017 09:30:35 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <1484095705-3962-1-git-send-email-subhashj@codeaurora.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/01/17 00:48, Subhash Jadavani wrote: > Colin Ian King reported that with > commit 7ff5ab473633 ("scsi: ufs: add tracing support") static analysis > is reporting that we may have swapped arguments on calls to: > trace_ufshcd_runtime_resume, > trace_ufshcd_runtime_suspend, > trace_ufshcd_system_suspend, > trace_ufshcd_system_resume, > and trace_ufshcd_init > > Where: > hba->uic_link_state is passed to dev_state > hba->curr_dev_pwr_mode is passed to link_state > > This wasn't intentional so it's a bug. This change fixed this bug. > > Reported-by: Colin Ian King > Signed-off-by: Subhash Jadavani > --- > drivers/scsi/ufs/ufshcd.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c > index be6322e..6b56eb0 100644 > --- a/drivers/scsi/ufs/ufshcd.c > +++ b/drivers/scsi/ufs/ufshcd.c > @@ -5805,7 +5805,7 @@ static int ufshcd_probe_hba(struct ufs_hba *hba) > > trace_ufshcd_init(dev_name(hba->dev), ret, > ktime_to_us(ktime_sub(ktime_get(), start)), > - hba->uic_link_state, hba->curr_dev_pwr_mode); > + hba->curr_dev_pwr_mode, hba->uic_link_state); > return ret; > } > > @@ -6819,7 +6819,7 @@ int ufshcd_system_suspend(struct ufs_hba *hba) > out: > trace_ufshcd_system_suspend(dev_name(hba->dev), ret, > ktime_to_us(ktime_sub(ktime_get(), start)), > - hba->uic_link_state, hba->curr_dev_pwr_mode); > + hba->curr_dev_pwr_mode, hba->uic_link_state); > if (!ret) > hba->is_sys_suspended = true; > return ret; > @@ -6852,7 +6852,7 @@ int ufshcd_system_resume(struct ufs_hba *hba) > out: > trace_ufshcd_system_resume(dev_name(hba->dev), ret, > ktime_to_us(ktime_sub(ktime_get(), start)), > - hba->uic_link_state, hba->curr_dev_pwr_mode); > + hba->curr_dev_pwr_mode, hba->uic_link_state); > return ret; > } > EXPORT_SYMBOL(ufshcd_system_resume); > @@ -6880,7 +6880,7 @@ int ufshcd_runtime_suspend(struct ufs_hba *hba) > out: > trace_ufshcd_runtime_suspend(dev_name(hba->dev), ret, > ktime_to_us(ktime_sub(ktime_get(), start)), > - hba->uic_link_state, hba->curr_dev_pwr_mode); > + hba->curr_dev_pwr_mode, hba->uic_link_state); > return ret; > } > EXPORT_SYMBOL(ufshcd_runtime_suspend); > @@ -6921,7 +6921,7 @@ int ufshcd_runtime_resume(struct ufs_hba *hba) > out: > trace_ufshcd_runtime_resume(dev_name(hba->dev), ret, > ktime_to_us(ktime_sub(ktime_get(), start)), > - hba->uic_link_state, hba->curr_dev_pwr_mode); > + hba->curr_dev_pwr_mode, hba->uic_link_state); > return ret; > } > EXPORT_SYMBOL(ufshcd_runtime_resume); > Thanks, looks good to me. Acked-by: Colin Ian King