From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DC0F433E7 for ; Thu, 23 Apr 2026 13:50:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776952219; cv=none; b=P+Vq9p7yUShPCyeZSIFfGQMeaAwf7fxXYTW5KpB4ydjhC+VXEb7wuucZqIkx0ruOpOkyKF/PWF26WmKPGxNQdjXylrJcCtwB9Ar2aTh1gWPCDNryflrJFHEZ8Mq26Ygr0/vlNlD+3I6LNwHeWDgZjIO4cr0H3i/BZhZqqFnONlI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776952219; c=relaxed/simple; bh=THUk/U4jSih5RI8wrow5DiqotOM2IDJ3SJpzIkAxXVQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=PYEWvgAD0JaW9jppGOahr9/bgS5BCT1dtLmK23WruvUeCyvqwksLicziGBeeKnKaENs9XgfMjvO0CcHLXc9zYuaMIVyddVdbCTGtnlFjxxinmeZMfgJYjmsZwyI5EQPavX59RUS6auJRMkJXq9w9cbK9ftigVTnIcuvgoPA5h+s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=K/wX429c; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=SMKi9qdu; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="K/wX429c"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="SMKi9qdu" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 63N8uMkV987902 for ; Thu, 23 Apr 2026 13:50:17 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= ynFtzosuzZSx1mxtdb7if31d5T0yw7m1wUQVLpmJjWw=; b=K/wX429c0cO3qPlq NAX3USpAhddN3loKcdY+mTcqyNOHrz+zgdgFdr+yxwv+hcQuaZ73A7+T3knp+7qo EboqV0l7xX6mrUzBXv65bGuPxcaM9p6DvbViFruho6Kaot6ijjBPZvjs8lPaR/6X dx7GYniFmtab5wbvxg5KeeGfxCoLR7hmqogNujbI3F8obcWSKXpILkrDj0Bsmfyu H7vOoXsl3KJ/BcR+67RmX+aY8oPL0IASK8oVhoPCgAUc1bz5RUoQnmS8bOsVEKSx WdN5+vVJfhKghmddyAAaMIQcLi8bMQymFtyts85iQhAJkrOvKFbMG+kQ8bSe3JCT 50MZpQ== Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dq16q47tp-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 23 Apr 2026 13:50:16 +0000 (GMT) Received: by mail-pj1-f69.google.com with SMTP id 98e67ed59e1d1-3595485abbbso8301980a91.2 for ; Thu, 23 Apr 2026 06:50:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1776952216; x=1777557016; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ynFtzosuzZSx1mxtdb7if31d5T0yw7m1wUQVLpmJjWw=; b=SMKi9qdutE/vhSC7Dm4xP2BaFtQ9pEZr1LUu0TDDTdSuHhEOVBf9MFBTU4LFfkuaV7 P16WMIua47bAB9ecEycpwfI3/66L12rZpE+5OcMvTKD7dJK6h1lsZ5fg026INwx9ndWg Laxc7dVLpo+5JRcDhJzGUIdTV8jbtXICRM+i6+RAkfxlF9YiKIR1ExB3G2jl1Sc1mjEo wpBFkjKc0eBMDElzUC2kjP2L2GZuYI60Yx3zUinSN2uZLSVeUb5yQOHAoc3ZuUeLo/Ko IrzXEEoPq1xQ7qeBGuPTPtywKZQVkFW9P11iVtckSSbQuQ+FgGvpI7fF6AUk9TA9edE7 9p/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776952216; x=1777557016; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ynFtzosuzZSx1mxtdb7if31d5T0yw7m1wUQVLpmJjWw=; b=jw5K78yRpz0Kr9yQN31/YrKjp2m99R5xQRCvy8cmKmsmq5axwu5ywFzp9vKfr9E8W6 /3tHjpCuyf2zMq7wUebh/L71ymEEkC0T/7DH/EsMkribPZgQqYcmv+NI1y5A0KI2M3qw enoMB85+xnXtB8p9e+Aeu7UakiUeYv4GyYVDCWpzvxOP57jk1l7/OgdszkYwaxbmSJJD Rq6Ebk5gmqZ8CEUCyP1LsGDuRgP8FEyVUZNS+TGqB4BhWwhNl0NGeLaSyNHTqpFuxiKU 9VOMwEQ76E1WWDiC0zgV1h8SVPIFy0UIJPaTVCSqOBroMTewJfVpJIBrlj9VB2+EcAMc o8pg== X-Forwarded-Encrypted: i=1; AFNElJ+x7sm+DEegZ3dWWWDnLER3sYG5HsI01Xeok7GQ24IHb6lFTIJ24q31UKbFdmEhjm1DynUG8nj24kGrzW0=@vger.kernel.org X-Gm-Message-State: AOJu0YyHvsV+bLb+NYXHlPbD9UvGgTzExhyCUkalbhQLqbhiNM7P8MFh 7VWFKzY6BgcZwrzKz6pzkCIxLHvZNhsTw9tc+9S8ldxqA8T0CKeyKjG1LPWCvf+0GO3W9bIYkyZ i6q0m61d2mT+08uXCk6NHACrKLbXpGePtQQdsN9VSNEhb9Nwe9AP/CV2nFPl+JSDGhU8= X-Gm-Gg: AeBDiet3ChH92UgviQ8rd4K2xNKaXD4Tz0WH/Ud30Bfzg43bGIoCCpqtRJMbynlsHvG 6PTRDW91EwgN1C4x6MLF0X6PYoTZ4mxsYFATKEIpkynCcqbmDzK/MWDHZ9gqHn1+bcaDLBcgVpV JgaWOiHUZQALII5H8Fa0O2rAYiFmkIWS4D6NWRjJpw6+sLSh25MxuoOp/UKqXZOXAjwlX5s3QqX ku+aNlOB8ZtEENKKr5pkaPH7BvF6m0H60ouGTFKPjFRlOHdBnBsqksESsVFfIWTHPqRM2tlUpgw OxM3wpkQwNzaMPXdHs7XeKo3f4LNXrt1vVygAjNWWJVSlLgwQL40AsXXlFQZ/aRzQfHl8DHZq5V sJQU5RFlUUEckTQ2vBbDx0QpjN3jmFkun6PpiFjI0IPJeAYNFvv5qBXj2cUISwK4J+EIUPnAdF/ 38FQdAEGOywCPrEI7rkOeZ X-Received: by 2002:a17:90b:4cc2:b0:35d:a843:6b1f with SMTP id 98e67ed59e1d1-361403f4fcdmr29528289a91.11.1776952215921; Thu, 23 Apr 2026 06:50:15 -0700 (PDT) X-Received: by 2002:a17:90b:4cc2:b0:35d:a843:6b1f with SMTP id 98e67ed59e1d1-361403f4fcdmr29528247a91.11.1776952215452; Thu, 23 Apr 2026 06:50:15 -0700 (PDT) Received: from [10.133.33.37] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3614195a92asm19946750a91.10.2026.04.23.06.50.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 23 Apr 2026 06:50:15 -0700 (PDT) Message-ID: Date: Thu, 23 Apr 2026 21:50:10 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] scsi: ufs: core: Add support to retrieve and store TX Equalization settings To: Bart Van Assche , avri.altman@wdc.com, beanhuo@micron.com, peter.wang@mediatek.com, martin.petersen@oracle.com, mani@kernel.org Cc: linux-scsi@vger.kernel.org, Alim Akhtar , "James E.J. Bottomley" , vamshi gajjela , "Rafael J. Wysocki" , Adrian Hunter , open list References: <20260419135229.1036926-1-can.guo@oss.qualcomm.com> <20260419135229.1036926-3-can.guo@oss.qualcomm.com> <7daff6c5-a0b6-4d52-a115-98cbb1d9abd9@acm.org> Content-Language: en-US From: Can Guo In-Reply-To: <7daff6c5-a0b6-4d52-a115-98cbb1d9abd9@acm.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Authority-Analysis: v=2.4 cv=KPNqylFo c=1 sm=1 tr=0 ts=69ea2398 cx=c_pps a=vVfyC5vLCtgYJKYeQD43oA==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=Zr3j5_gTT_g7vWEu1ZYA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=rl5im9kqc5Lf4LNbBjHf:22 X-Proofpoint-GUID: glPwFHMTXqys4mBFPnPwGcPXmrG0Are2 X-Proofpoint-ORIG-GUID: glPwFHMTXqys4mBFPnPwGcPXmrG0Are2 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDIzMDEzNyBTYWx0ZWRfX+rjJ6O2ZjM2F OA4LfsOPgJ5un7EWsYj2J1a/JQY+0GE3otVRanuGpxEAzjLv+Q6MMcqF8CLDQUJ5iErjCCkYFTo j/eJwKOFykihC1g4r5l4TcKTg3whrvcGoved09HdwvbBV2e28qwAh7A/Kv7OnxMe4DzP+ZjhjsJ l8nqpffhOqevC2RP/Br7qCCFo5C/DyJSGKDNOulRg0Gr6vgnoq1OdTqv1L/ivxtUoKO/jOgXyc8 5cov5aG00AEUzjo2tFU2q9tgemeLk4zINOH0N4giudnIUUQ0qK/Ae5rlDjNGym/4m+QGjaOGSWM UpzgwGi40AoIEgZVskU9fA8yXgwu8JUGWtB2jKyZsj+pYNZQXFBL9888VQdwFu4rVKumXPh/Ww4 Qhx08NauKsrvOcvOhuq3as2Fq5F4hY+5vqzlmftF2lk7ZWAztcsgCnvtMRFagO2RQzZ3OxGHpOz nNeOmtotGWvoAClz7Jw== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-23_03,2026-04-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 clxscore=1015 malwarescore=0 bulkscore=0 priorityscore=1501 suspectscore=0 spamscore=0 adultscore=0 phishscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2604230137 On 4/21/2026 1:01 AM, Bart Van Assche wrote: > On 4/19/26 6:52 AM, Can Guo wrote: >> +#define TX_EQ_DEVICE_PRESHOOT_DECODE(eq, lane) \ >> +    (((eq) >> ((lane) * TX_HS_PRESHOOT_SHIFT)) & TX_EQ_SETTING_MASK) >> +#define TX_EQ_DEVICE_DEEMPHASIS_DECODE(eq, lane) \ >> +    (((eq) >> ((lane) * TX_HS_DEEMPHASIS_SHIFT + 16)) & >> TX_EQ_SETTING_MASK) > > Please convert these two macros and also all the other new macros in > this patch that accept arguments into inline functions. Will do. Thanks, Can Guo. > > Thanks, > > Bart.