From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DD2C13C81BE for ; Wed, 24 Jun 2026 14:30:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782311430; cv=none; b=ldqgn0O+cSN5ZOYJD1sFYE9JbnZ7HcwOZuz5Od4yYvi2+bGGBUN3xOvvAG65J5kmZZ3LGkSWnWFf07TyxX9EEQN5dpN6MhqbDadRrHi5Qg5q3dsDLDSyKY0RiqFvcph3dbenLOfr0+yfngnhJl5wHC6Y4/Z8ZW42HcQZPZhCwAI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782311430; c=relaxed/simple; bh=jXv0pTSEmNFbM8ekGb88NGF9lNs5tNx/gJo+58GQa3E=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ERDTqbFaXaELhVJYUiAui+tIIji52Okb1H58zzirtIeFv1d96EIwm230STYMGxKfftBO7J/X7XX3FCtDJePwBxaZ8gxwyWpRd8+pX5nO7ZnPFJ7fCBNc9cuLQgvfMMEd3JGNzmV0VQ9XhIq3cr+TZ1jSLXLgNOGupLaRpwfQy0Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Lul7uDuJ; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=jENzmWib; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Lul7uDuJ"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="jENzmWib" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65OANVis3167321 for ; Wed, 24 Jun 2026 14:30:27 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= bJXOcydpNHnaGs81rbyZLCVSzov2xbjvTQOme0ii2Ko=; b=Lul7uDuJrI4R08lA oajLQeA/bJR6WsC6oxAKUB7JpeLy1eDw0DyNwgYYW5eUxIIlBlwv1RISjv/esQcr jgIPWWkPXtKoTCjdaT6ab2Om4fg2BBog9iOoMgqnLuMnoEvcMe5TA5AunnVtR25j +tn9oozY3ejp4d+vyx9oOsCpflx6oag7Xbf8JjXzR05+OuaeonsOj2/ccPs+0oSI OYO5Og2nphOI1vOMHJGd2xALzKfKirIbZhGLHs0ur81YwdKT/NVKDG0w/Z77ctQf HzqBw8LMY/Ij85/wi5nPi+JkysY4hE6RHmxO776TR5jUqM7v55WJM0lRgPWuG1/G 47njjg== Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f0996j0ut-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 24 Jun 2026 14:30:27 +0000 (GMT) Received: by mail-pj1-f69.google.com with SMTP id 98e67ed59e1d1-37d4f23eb37so1519023a91.0 for ; Wed, 24 Jun 2026 07:30:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1782311426; x=1782916226; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=bJXOcydpNHnaGs81rbyZLCVSzov2xbjvTQOme0ii2Ko=; b=jENzmWibQYcc6bqVPLmegLPAhwK58RTtgALAPZJlHBcDIzwmxZtPPm+6y20aPOd7St oN1+OtDvJceV16olwBDumfllSOW9KvtJE0dRsk4Xj4F2svTkdLPAOkXTQTLZGhjRiKaV XJUa8ETVWsmV8q3QnTQLnS5pLLXSghJ7HJiIgTL+S/c4VWrkaY6fwjMpqbQ8C3/bKRcw DP2EM2ACZW5480l4ugM+cFlGkyRIPVqgGwBRxWRt9sfAviovf/v0aaYvsQiwiseEWyyD CGy39IwFKheEflcnlO1sGOflt50kknKFUgohrSeo5jO6mSuO99//M6mAP0kTjhpGNsFV 8nrw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782311426; x=1782916226; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=bJXOcydpNHnaGs81rbyZLCVSzov2xbjvTQOme0ii2Ko=; b=TARGFo8DuWCccU31jVqpqpR/96T3dxrtZspCl0hw0pJBS5ij+mS1I+YQJOhDVV3+6G i64p6s2mNq/YX5c0W9ggliKjrKmHcrJsc61apzC2CCcmnGphY51wL0F1/FNhycsKHhzt 0h3x4pJW7/JkkLtfe/3QoqSDMVfuPKY55kCDlinooOWzjX+v2n2LQNwmBxfc58zFMadN G5+tFCs6wK9QVg2a/mQX3NlHjPGNJgKo8LZOsEYfDz5uDbbgrU5Smh7Px91C+31CnJc4 +Oh/8RLuhExr7MTOyI2V9TzXmkYjeY7QpxEqKxRtsdXoXDOxwobfxUrhMLC2U7Wf1XlM rm5Q== X-Forwarded-Encrypted: i=1; AHgh+RpUZo3itMc6agIOqYr4uxQNCD/YYNaFsk2C76ctIAvBCleOmrs+gqrqsA8ySOv5+CoTR4jYcYtBleYYt3A=@vger.kernel.org X-Gm-Message-State: AOJu0YybLITo2n8e9ARf4A1+Fd7TfneK/w3IOxAPW7E55BPAKqZlFr6a QGA26zrJ36M66yXJwVPjsrFit5BpObiQga1lRo7c+1Wo6271YxCbZo8/+iqQzzcLJ2vvABu0p2y zeRU0RWG8s2vA3gbU1ZeFRT+7EafJUmRxDZ6q+9AUD2q5Fs0t/lpOIhqpq5ExObPF+0Q= X-Gm-Gg: AfdE7ckOjCNLPadhB7ePCmvI4ax0x6XMH3X+gmSAfHAEGtVRC9xG1CoKTGHTW2ReLXo 7yyM7jwAc91e9TAvuxAWw1CnqKrhlM+OA3bZeJGHT+F3bekYl8Y3xMP6d67VF+GyzIJQa56hzHO AHF2ros6WItLoAJ2Gcwd57n+k1bx2PkBezuioH2aMfrR3pET7ejSVR6IU8j425tZMV1X5rwHdmj GjZVd37lg+XoJ3BAOvhv/6FTvr5rhcpIZzzCjKJ3TMiMlcpLmv79ntDNZgPX0eMTTK73hsvRW+U ve577SlXBPWGg8o0tPZc+m6eJkNmvpySujijxX+csaOyF0dViN8aw4EYfH01i3UEs1sAflvp7fi gfvZCFFMfCpQ30d6dOauCduvl3MtdqNTdc4ZXPZwwni/T X-Received: by 2002:a17:90b:1805:b0:36d:ae6a:22f0 with SMTP id 98e67ed59e1d1-37dd0db4070mr7924147a91.14.1782311425603; Wed, 24 Jun 2026 07:30:25 -0700 (PDT) X-Received: by 2002:a17:90b:1805:b0:36d:ae6a:22f0 with SMTP id 98e67ed59e1d1-37dd0db4070mr7924022a91.14.1782311424721; Wed, 24 Jun 2026 07:30:24 -0700 (PDT) Received: from [10.204.101.214] ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-37de3ce55dfsm3162887a91.10.2026.06.24.07.30.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 24 Jun 2026 07:30:24 -0700 (PDT) Message-ID: Date: Wed, 24 Jun 2026 20:00:18 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 12/16] media: iris: implement support for the Agatti platform To: Dmitry Baryshkov , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Vishnu Reddy Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Dikshita Agarwal References: <20260616-iris-ar50lt-v5-0-583b42770b6a@oss.qualcomm.com> <20260616-iris-ar50lt-v5-12-583b42770b6a@oss.qualcomm.com> Content-Language: en-US From: Vikash Garodia In-Reply-To: <20260616-iris-ar50lt-v5-12-583b42770b6a@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: FQDS5Ma-GKgI9ccdODD8UVddZ5QaoOPE X-Proofpoint-ORIG-GUID: FQDS5Ma-GKgI9ccdODD8UVddZ5QaoOPE X-Proofpoint-Spam-Info: AW1haW4tMjYwNjI0MDEyMCBTYWx0ZWRfX4a1ERs+wIXGw B7FvjwSnwz4yMonebYmKJZKTg3fEC1bg12E2x863nvBuO8S/NoHTUIJgp9MNgM6R4gGrpXge+wY rn1SzbYy3XNDszw+nyESDk3ytQrEV1g= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjI0MDEyMCBTYWx0ZWRfX6AgndJRgPOqd gI6RiAkv/Sb0IxianDY3nIE1xHQmkOEzGXNxNJ4fR2hKMRNSnfuRsclGpoaywLBoGa9M7lxwGac gTD3nATwrY3WM+iZGcIR2iT04bEetqiS2evoDJwEIZCatknq+3BuiXmM7J0OEiC+KI6xaf5/nox rK4L1cUYPCzBY+Npn2DGuz96MDdgjIpUEpuUd5c6srtx6l13JeLh4kR98zsAsi5ZaQV/cgm29Zs 5oveoNbh2b9axKcB0E0ty+QYo3Z3S482XhxG+lIfuOGwAye1Rp5+FqSRLw3K2c7Brl4rzCP0oWS m6shZMoKMX4z+yTfq4fNIRZnlspMp2+kjd+UNlsqklkqtP7I8M1KTHy1hPc30uFsMlc1yyB0LrY CgJAJd8gVkEtSUY5r0y/TzDz3CDcUWLpmV8E3oiZy0nLfkDOdv8PzeRELMmcjlufYJK9pFZE4Ri ffLlf4wzuz9uREAZxkg== X-Authority-Analysis: v=2.4 cv=Tv/WQjXh c=1 sm=1 tr=0 ts=6a3bea03 cx=c_pps a=vVfyC5vLCtgYJKYeQD43oA==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=EUspDBNiAAAA:8 a=S-oV5pMvw9Cc1cVx9MoA:9 a=QEXdDO2ut3YA:10 a=rl5im9kqc5Lf4LNbBjHf:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-24_03,2026-06-23_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 suspectscore=0 clxscore=1015 bulkscore=0 adultscore=0 lowpriorityscore=0 impostorscore=0 spamscore=0 malwarescore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2606240120 On 6/16/2026 5:34 AM, Dmitry Baryshkov wrote: > Port support for the AR50Lt video codec core (present for example on the > Agatti platform) to the Iris driver. Unlike more recent cores this > generation doesn't have the PIPE property (as it always has only one > pipe). Also, unlike newer platforms, buffer sizes are requested from the > firmware instead of being calculated by the driver. > > Co-developed-by: Dikshita Agarwal > Signed-off-by: Dikshita Agarwal > Signed-off-by: Dmitry Baryshkov > --- > drivers/media/platform/qcom/iris/Makefile | 1 + > drivers/media/platform/qcom/iris/iris_hfi_gen1.c | 227 +++++++++++++++++++++ > .../platform/qcom/iris/iris_platform_common.h | 6 + > .../platform/qcom/iris/iris_platform_vpu_ar50lt.c | 110 ++++++++++ > drivers/media/platform/qcom/iris/iris_probe.c | 4 + > drivers/media/platform/qcom/iris/iris_vpu_buffer.c | 13 ++ > drivers/media/platform/qcom/iris/iris_vpu_buffer.h | 1 + > 7 files changed, 362 insertions(+) > > diff --git a/drivers/media/platform/qcom/iris/Makefile b/drivers/media/platform/qcom/iris/Makefile > index f1b204b95694..bbd1f724963e 100644 > --- a/drivers/media/platform/qcom/iris/Makefile > +++ b/drivers/media/platform/qcom/iris/Makefile > @@ -14,6 +14,7 @@ qcom-iris-objs += iris_buffer.o \ > iris_hfi_queue.o \ > iris_platform_vpu2.o \ > iris_platform_vpu3x.o \ > + iris_platform_vpu_ar50lt.o \ > iris_power.o \ > iris_probe.o \ > iris_resources.o \ > diff --git a/drivers/media/platform/qcom/iris/iris_hfi_gen1.c b/drivers/media/platform/qcom/iris/iris_hfi_gen1.c > index ca1545d28b53..f57af31dbd9f 100644 > --- a/drivers/media/platform/qcom/iris/iris_hfi_gen1.c > +++ b/drivers/media/platform/qcom/iris/iris_hfi_gen1.c > @@ -443,3 +443,230 @@ const struct iris_firmware_data iris_hfi_gen1_data = { > .enc_ip_int_buf_tbl = sm8250_enc_ip_int_buf_tbl, > .enc_ip_int_buf_tbl_size = ARRAY_SIZE(sm8250_enc_ip_int_buf_tbl), > }; > + > +static const struct platform_inst_fw_cap iris_inst_fw_cap_gen1_ar50lt_dec[] = { > + { > + .cap_id = STAGE, > + .min = STAGE_1, > + .max = STAGE_2, > + .step_or_mask = 1, > + .value = STAGE_2, > + .hfi_id = HFI_PROPERTY_PARAM_WORK_MODE, > + .set = iris_set_stage, > + }, > +}; > + > + > +static const u32 iris_hfi_gen2_ar50lt_dec_ip_int_buf_tbl[] = { gen1... > + BUF_BIN, > + BUF_SCRATCH_1, > +}; > + > +const struct iris_firmware_data iris_hfi_gen1_ar50lt_data = { > + .init_hfi_ops = &iris_hfi_gen1_sys_ops_init, > + > + .inst_fw_caps_dec = iris_inst_fw_cap_gen1_ar50lt_dec, > + .inst_fw_caps_dec_size = ARRAY_SIZE(iris_inst_fw_cap_gen1_ar50lt_dec), > + .inst_fw_caps_enc = inst_fw_cap_gen1_ar50lt_enc, > + .inst_fw_caps_enc_size = ARRAY_SIZE(inst_fw_cap_gen1_ar50lt_enc), > + > + .dec_input_config_params_default = > + sm8250_vdec_input_config_param_default, > + .dec_input_config_params_default_size = > + ARRAY_SIZE(sm8250_vdec_input_config_param_default), > + .enc_input_config_params = sm8250_venc_input_config_param, > + .enc_input_config_params_size = > + ARRAY_SIZE(sm8250_venc_input_config_param), > + > + .dec_ip_int_buf_tbl = iris_hfi_gen2_ar50lt_dec_ip_int_buf_tbl, > + .dec_ip_int_buf_tbl_size = ARRAY_SIZE(iris_hfi_gen2_ar50lt_dec_ip_int_buf_tbl), same here > + .dec_op_int_buf_tbl = sm8250_dec_op_int_buf_tbl, > + .dec_op_int_buf_tbl_size = ARRAY_SIZE(sm8250_dec_op_int_buf_tbl), > + Regards, Vikash