From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755420AbdKCKOy (ORCPT ); Fri, 3 Nov 2017 06:14:54 -0400 Received: from szxga05-in.huawei.com ([45.249.212.191]:10008 "EHLO szxga05-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750883AbdKCKOw (ORCPT ); Fri, 3 Nov 2017 06:14:52 -0400 From: John Garry Subject: Re: [PATCH] scsi: hisi_sas: select CONFIG_RAS To: Arnd Bergmann , "James E.J. Bottomley" , "Martin K. Petersen" References: <20171102165059.213216-1-arnd@arndb.de> CC: Xiang Chen , , , Linuxarm , Shiju Jose Message-ID: Date: Fri, 3 Nov 2017 10:14:16 +0000 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <20171102165059.213216-1-arnd@arndb.de> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.202.227.238] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A0B0208.59FC418F.00B7,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2014-11-16 11:51:01, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: db9650efdebbda198f09755e2995d319 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org + Shiju, who authored the original patch Hi Arnd, Thanks for this. On 02/11/2017 16:50, Arnd Bergmann wrote: > The driver now uses the RAS infrastructure, and fails to link if that > is disabled: > > drivers/scsi/hisi_sas/hisi_sas_v2_hw.o: In function `fatal_ecc_int_v2_hw': > hisi_sas_v2_hw.c:(.text+0xb08): undefined reference to `__tracepoint_non_standard_event' > drivers/scsi/hisi_sas/hisi_sas_v2_hw.o: In function `fatal_axi_int_v2_hw': > hisi_sas_v2_hw.c:(.text+0x1b34): undefined reference to `__tracepoint_non_standard_event' > > This adds an explicit Kconfig 'select RAS' statement. I don't know if > the driver uses the interface correctly, as no other driver seems to do > it like this, but the change fixes the link error. > > Fixes: dfeb5021f001 ("scsi: hisi_sas: report ECC and AXI errors in v2 hw to userspace") > Signed-off-by: Arnd Bergmann > --- > drivers/scsi/hisi_sas/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/scsi/hisi_sas/Kconfig b/drivers/scsi/hisi_sas/Kconfig > index d42f29a5eb65..6ad8a6251d21 100644 > --- a/drivers/scsi/hisi_sas/Kconfig > +++ b/drivers/scsi/hisi_sas/Kconfig > @@ -4,6 +4,7 @@ config SCSI_HISI_SAS > depends on ARM64 || COMPILE_TEST > select SCSI_SAS_LIBSAS > select BLK_DEV_INTEGRITY > + select RAS My impression is that we don't want this. Correction: shouldn't want this. Do you have the .config for the broken build? I couldn't recreate this by turning off CONFIG_RAS. John > depends on ATA > help > This driver supports HiSilicon's SAS HBA, including support based >