From: Andrew Lunn <andrew@lunn.ch>
To: MD Danish Anwar <danishanwar@ti.com>
Cc: Vignesh Raghavendra <vigneshr@ti.com>, Nishanth Menon <nm@ti.com>,
afd@ti.com, Conor Dooley <conor+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Rob Herring <robh+dt@kernel.org>, Tero Kristo <kristo@kernel.org>,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, srk@ti.com,
r-gunasekaran@ti.com
Subject: Re: [PATCH v2 2/4] arm64: dts: ti: k3-am654-base-board: add ICSSG2 Ethernet support
Date: Thu, 21 Sep 2023 18:10:02 +0200 [thread overview]
Message-ID: <bdb60c9f-467e-4960-b516-9d79f43544ed@lunn.ch> (raw)
In-Reply-To: <20230921060913.721336-3-danishanwar@ti.com>
> + /* Dual Ethernet application node on PRU-ICSSG2 */
How relevant is "Dual Ethernet" here? You are talking of adding
switchdev support, and runtime swapping the application. All these
properties should be valid for the switch application as well?
In fact, you are describing hardware here, so the application should
not actually matter.
So maybe this comment should be:
Ethernet node on PRU-ICSSG2
Andrew
next prev parent reply other threads:[~2023-09-21 22:16 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-21 6:09 [PATCH v2 0/4] Add AM65x ICSSG " MD Danish Anwar
2023-09-21 6:09 ` [PATCH v2 1/4] arm64: dts: ti: k3-am65-main: Add ICSSG IEP nodes MD Danish Anwar
2023-09-21 6:09 ` [PATCH v2 2/4] arm64: dts: ti: k3-am654-base-board: add ICSSG2 Ethernet support MD Danish Anwar
2023-09-21 16:10 ` Andrew Lunn [this message]
2023-09-22 4:28 ` MD Danish Anwar
2023-09-21 17:27 ` Andrew Davis
2023-09-22 4:22 ` MD Danish Anwar
2023-09-25 8:21 ` MD Danish Anwar
2023-09-25 13:45 ` Andrew Davis
2023-09-26 4:10 ` Anwar, Md Danish
2023-09-21 6:09 ` [PATCH v2 3/4] arm64: dts: ti: k3-am654-idk: Add ICSSG Ethernet ports MD Danish Anwar
2023-09-21 16:14 ` Andrew Lunn
2023-09-22 4:33 ` MD Danish Anwar
2023-09-21 17:33 ` Andrew Davis
2023-09-22 4:24 ` MD Danish Anwar
2023-09-21 6:09 ` [PATCH v2 4/4] arm64: defconfig: Enable TI_ICSSG_PRUETH MD Danish Anwar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bdb60c9f-467e-4960-b516-9d79f43544ed@lunn.ch \
--to=andrew@lunn.ch \
--cc=afd@ti.com \
--cc=conor+dt@kernel.org \
--cc=danishanwar@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=kristo@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nm@ti.com \
--cc=r-gunasekaran@ti.com \
--cc=robh+dt@kernel.org \
--cc=srk@ti.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®