From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1836E1D9A5F for ; Sun, 2 Aug 2026 14:30:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785681059; cv=none; b=XjzJ9FWRbsFxcUK0Wi3mAiWR381NH53+dUP5EdK7NsGYPHhNritI5axDMlLT/1nGBwKc5xg8rm6ZzaBo9rfg8VbJ/zB+Vx89Skve+0sjkgE3naaoMnp00ZgC9BXyEj9ecSJfdAreZm84XwNh6X4YJgJqOyPY60QvqRPwkrwK6oI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785681059; c=relaxed/simple; bh=4Cw5hHEtwE4SsTUeNi0GjrPqFYX5d9lInGn6AgWbfuQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=R6EjcCVUd5h/LVLgm9/dyz0arDTbTtn0dVmrq6yavxxkGEBOuDEaeGG7Dj7DisF1ccoKqYxKtYQefzUAJcBIBHgTsVR/StfET/Pw0KHT++6tdLnRkZ8vFb77w8q3uP9kRs+AH+VxL2xDAtrg1JxNcZd2Z2BAqftL4FuPqUDxLis= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Q7KExOPD; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=JKby09y0; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Q7KExOPD"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="JKby09y0" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 672B6aIO1352234 for ; Sun, 2 Aug 2026 14:30:57 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 2wLRb9QYeLt7rsVJiN7hvsyaizC8vPUiUfINQ6ZucSQ=; b=Q7KExOPD9xdKlaiR aHN5+/9FPnOhdkYRb54QhiHeJJ+JF6g2m/nrGHslEFdXpta7P3skcFQgcVWppdxQ grVsxUJz+rRWcglAnpKBVdNcUpGO9kCEjw6uEnSGhgdJETMSNlllIMxvKcQNrfIC EclpJ5WAF2KYeYN9rmzVUW53rptyB02YUKTUpkdwK+4/LxVZc6uY4WQIFHuSZLVo vVlgDjATtOwwdYcGUIinMg+9cLOG4oUTzRHGuOK/pejMZR8ZGHO/5Z4m5grmFTie 44Ke/jjusXT65rp1h+j97rnJWdzTSGzDy++Rxvli0aG0IgPtHRi2NrzMTaBNbw+L U8haew== Received: from mail-pg1-f197.google.com (mail-pg1-f197.google.com [209.85.215.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fs9jfttyx-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sun, 02 Aug 2026 14:30:57 +0000 (GMT) Received: by mail-pg1-f197.google.com with SMTP id 41be03b00d2f7-caf5fa127d4so4710646a12.0 for ; Sun, 02 Aug 2026 07:30:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1785681056; x=1786285856; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to:content-type; bh=2wLRb9QYeLt7rsVJiN7hvsyaizC8vPUiUfINQ6ZucSQ=; b=JKby09y0wDxr8WUAGnj214enHIypTcq9V7oIm4NB6+f5BdYX9qlwvtbrt0ijsEs0rv wfJW7GsitssmRLgdQ9KEVrJZE3SdTeq0N3wQiw7JeZMFSiTIkMCX8ipJ+8PPDNaN5a0B +pRDjGGfffDqkK5ypcoCr4sbSkNLSLm95HwPCaBIjSoe99WLFWrlNC0ITJuuFGu+b4fB BiyYB0JRrXsvoHsrvdSJkEZaYWFyw407I/ij6VIAJ7MUae+iq4tMMn80l7RwFSA9AjyZ hXdGRO0yHdXN0ylwPEPa2rOMxuIrdRG2nXFvDZY1iNrVscf6xoe7JubJo2mSIGh2l2pf e84A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785681056; x=1786285856; h=content-transfer-encoding:content-type:in-reply-to:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=2wLRb9QYeLt7rsVJiN7hvsyaizC8vPUiUfINQ6ZucSQ=; b=kG+HK/oD0Z2gLFjrLq0TKPFAQSuEqaBHp9PNGwrmaLeA1GkBQE8mjtDgr/Hak8m67j QZpk1+fyoiBdadKt0RqFWX6D4PwnM9oUbyQR+Yco4SQZzIBL2z5jlBmkDa3k7C3jeON1 k4+n47OwPGoAijmshYSddeP7MGMXg3KEaEaUdXniXZkXCGyunx/asZsr2Y0KO2ITgzeg NsR/WL/KEvBfqjvxp4K8nBJvBTIoHgNhUSPwpo8LuzFn7+0nTq7zoPhov/opEY12PVBW bAfwuz67XN0BKb2lxxp4fpXAIVefK7M3Ji2X+dkFcXVXDSPk8IBUNqyr6W5mYvhxFBRl i9pQ== X-Forwarded-Encrypted: i=1; AHgh+Rrq0ecoVgOckBlJMPxGiPkz7OB20TbPtFQ8Vw+UhCQ+nqQvhaZbzE0UwwM8CFaS2V/KllMezyVNIfjJ2kA=@vger.kernel.org X-Gm-Message-State: AOJu0Yw9CxYUIT3tPJ8ZidLW0W0EYKXIiHcWQBaHXUGuqsUz9ECTjcio Y5bm2kbeIXefEBxepVj40PhgFp69YUsauBHN1zWGKdJbv+16VSf1Dk+ndhk6v/oxrKBQCkC2TNY WvfqP7P55Izm9OoLIXSdwEDZDtQWAywGQKahbsaflag9cbpQrq0jSo0Amo+e/AhrdWJULVyoGiU Y= X-Gm-Gg: AR+sD12UpHvQ68SS/XOyizBK1URG2fhynz6YX/eA0UL9zdusaaeSvD0oU9GSdROU8JN nESnTiOuYX7/nJ8Qe6ogjWuCqw51jIy+MpRh/AOsKapq8Y8ZN2tm9m9GR5eNR1NpLWi8JYlvfrM iziXKtb4NU4DjSHxRuu0REUuAugJauFuq5URfNTl2z4/NPg9hQIfsiJT1MCYlztTRVjfiGZGkgf l73Gk5ju0sRd12mRpeo9MJfXsGicpKlJ4G+zlDG9WIsbJyJ70XOB4GUWp0GvHcRxyCmrotbzAP5 hqR+30xyNkEXCrzUU4oD3vYS08QbUiLXxVNHNvnAaK60UNDIg4NWBHrPemXKAgWq6hrTUnSoKXz KsGKKgKxTvpdZMWOSf9VA+jQAbiF8ECGiDnjIwyu2MrjAk7jGbVh/3VswIsc= X-Received: by 2002:a05:6a21:a04:b0:3c0:e6c3:224a with SMTP id adf61e73a8af0-3c92a85cbe3mr6691731637.37.1785681056457; Sun, 02 Aug 2026 07:30:56 -0700 (PDT) X-Received: by 2002:a05:6a21:a04:b0:3c0:e6c3:224a with SMTP id adf61e73a8af0-3c92a85cbe3mr6691704637.37.1785681056010; Sun, 02 Aug 2026 07:30:56 -0700 (PDT) Received: from [192.168.1.9] (103.sub-97-215-187.myvzw.com. [97.215.187.103]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3153dd4e666sm40316903eec.4.2026.08.02.07.30.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 02 Aug 2026 07:30:55 -0700 (PDT) Message-ID: Date: Sun, 2 Aug 2026 07:30:53 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] wifi: rsi: Fix types to appease CFI To: Stefan Hansson , linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, phone-devel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht Cc: Stefan Hansson References: <20260802-rsi-cfi-fix-v1-1-5821d2cb54ee@postmarketos.org> From: Jeff Johnson Content-Language: en-US In-Reply-To: <20260802-rsi-cfi-fix-v1-1-5821d2cb54ee@postmarketos.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: Vj6X5g3UJNK6tHZpI-AplhmS1LOKRAXC X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODAyMDEyOSBTYWx0ZWRfX1pRqyAMFawXG GcIs2veOUC8zEKY8/5h/+hp9siTqbudlp2XqsohpDHv41XGvQUGDDyiBBZ6Z4TeisiON7S1sZ26 gfMVOhFPoTF3EQxWDoABeOhMZ6rq6WVTOe4VKqJ6/sv2oiiP/iWuyE4DwnBX8WfmtGSY2zMq/ZA zyYBng8rtgXEgv2UQ+BUlWnZcmQRnLqSsH0QzNM4ayQzY9t+XTapifaD9eFDMkuaoMSh2Nxgsgc qx0BRTG86FNDUR+v3HjZzxHBp9ZxJ7MpIaOFvSYBYsY8ZI0uWDFccnZejVPKqcBqkz739yeAD8q EmZ3a3jH+BuIYfazppJqclYA4GSHZXBukuc2kE+NZsb5mKL7BKhIpoWfIXqUJbeVAsp8gYRS/l7 veHBhvq/4jthmL5OSjKvaFQETrSicpZVeYp+C/wniu+gADMWBypiJVuRzwWKfLuR5PvAHtSoDTa 2Ot/IhlllznlVMMTeJQ== X-Authority-Analysis: v=2.4 cv=TYSmcxQh c=1 sm=1 tr=0 ts=6a6f54a1 cx=c_pps a=rz3CxIlbcmazkYymdCej/Q==:117 a=UaEkX0D7FlC0tWE/LoNF7Q==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=Gbw9aFdXAAAA:8 a=pGLkceISAAAA:8 a=90mh4GC2pPR358r5yh0A:9 a=QEXdDO2ut3YA:10 a=bFCP_H2QrGi7Okbo017w:22 a=9vIz8raoGPyDa4jBFAYH:22 X-Proofpoint-ORIG-GUID: Vj6X5g3UJNK6tHZpI-AplhmS1LOKRAXC X-Proofpoint-Spam-Info: AW1haW4tMjYwODAyMDEyOSBTYWx0ZWRfXx6MvJKUxUEF4 bn15eviEqpTaEzJWlQwORJDLwCzU5snuJTh3FOQYPyEKFCJ5tWdGWo+7LhcbuQyKhs1leqCyygM Cf8zaHm3pVAmtDJ8LpxB8Velger1s2c= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-02_04,2026-07-30_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 spamscore=0 lowpriorityscore=0 malwarescore=0 phishscore=0 suspectscore=0 priorityscore=1501 bulkscore=0 clxscore=1015 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608020129 On 8/2/2026 5:22 AM, Stefan Hansson wrote: > Avoids errors like: > > CFI failure at kthread+0x124/0x1cc (target: rsi_coex_scheduler_thread+0x0/0x1b4 [redpine_91x]; expected type: 0x89fb613d) > > As seen in the aforementioned error this was tested using the downstream > redpine_91x driver found in the Librem 5's downstream source tree. > However, it appears that this driver is a modified version of the rsi > driver found in mainline Linux and as such I decided to port the changes > here too. > > Signed-off-by: Stefan Hansson Having fixed a ton of these issues in the Qualcomm Android downstream driver I was going to give my R-B, but I ran this through my ath.git patch acceptance process and it flagged some issues, starting with: WARNING:FROM_SIGN_OFF_MISMATCH: From:/Signed-off-by: email address mismatch: 'From: Stefan Hansson ' != 'Signed-off-by: Stefan Hansson ' There are also kernel-doc issues noted below > @@ -246,12 +246,13 @@ EXPORT_SYMBOL_GPL(rsi_read_pkt); > /** > * rsi_tx_scheduler_thread() - This function is a kernel thread to send the > * packets to the device. > - * @common: Pointer to the driver private structure. > + * @data: Pointer to the driver private structure. > * > * Return: None. Return: 0 > */ > -static void rsi_tx_scheduler_thread(struct rsi_common *common) > +static int rsi_tx_scheduler_thread(void *data) > { > + struct rsi_common *common = data; > struct rsi_hw *adapter = common->priv; > u32 timeout = EVENT_WAIT_FOREVER; > ... > diff --git a/drivers/net/wireless/rsi/rsi_91x_usb_ops.c b/drivers/net/wireless/rsi/rsi_91x_usb_ops.c > index 25c2b232394a..513d2fdfb510 100644 > --- a/drivers/net/wireless/rsi/rsi_91x_usb_ops.c > +++ b/drivers/net/wireless/rsi/rsi_91x_usb_ops.c > @@ -25,8 +25,9 @@ above here update the documentation: s/common/data/ Warning: drivers/net/wireless/rsi/rsi_91x_usb_ops.c:28 function parameter 'data' not described in 'rsi_usb_rx_thread' Warning: drivers/net/wireless/rsi/rsi_91x_usb_ops.c:28 Excess function parameter 'common' description in 'rsi_usb_rx_thread' > * > * Return: None. Return: 0 > */ > -void rsi_usb_rx_thread(struct rsi_common *common) > +int rsi_usb_rx_thread(void *data) > { > + struct rsi_common *common = data; > struct rsi_hw *adapter = common->priv; > struct rsi_91x_usbdev *dev = adapter->rsi_dev; > int status;