mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Marek Szyprowski <m.szyprowski@samsung.com>
To: Roger Quadros <rogerq@ti.com>,
	Jochen Sprickerhof <jochen@sprickerhof.de>
Cc: Felipe Balbi <balbi@kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
	Kishon Vijay Abraham I <kishon@ti.com>
Subject: Re: [PATCH] usb: dwc3: Enable GBit Ethernet on Odroid XU4
Date: Fri, 8 Feb 2019 13:36:40 +0100	[thread overview]
Message-ID: <bdbce410-7f48-17a5-b58b-3ebd65ca6913@samsung.com> (raw)
In-Reply-To: <5C5AB41C.9080402@ti.com>

Hi Roger,

On 2019-02-06 11:17, Roger Quadros wrote:
> +Marek
>
> As Vivek's and Andrzej's Samsung IDs bounced back.
>
> On 06/02/19 11:38, Jochen Sprickerhof wrote:
>> * Roger Quadros <rogerq@ti.com> [2019-02-06 10:41]:
>>> Hi,
>>>
>>> On 21/01/19 16:02, Jochen Sprickerhof wrote:
>> [..]
>>>> I'm not sure why this it only works with the driver compiled into the
>>>> kernel nor why it needs a hard reset or why it was the line was dropped
>>>> when the patch was accepted. Would be great to get some feedback of the
>>>> authors.
>>> When XHCI driver is compiled into the kernel are the relevant PHY drivers
>>> compiled in as well?
>> Only CONFIG_USB_PHY=y (I took the config from the linux-image-4.19.0-1-armmp_4.19.13-1_armhf.deb Debian package as a basis where this is the default).

I confirm that on Odroid XU4 USB 3.0 works only when all related drivers
(dwc3, xhci and exynos5 drd phy) are compiled into the kernel. If they
are compiled as modules, USB 3.0 calibration doesn't work. The mentioned
patch doesn't fix anything.

Best regards
-- 
Marek Szyprowski, PhD
Samsung R&D Institute Poland


  reply	other threads:[~2019-02-08 12:36 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-21 14:02 Jochen Sprickerhof
2019-02-06  6:49 ` Felipe Balbi
2019-02-06  8:41 ` Roger Quadros
2019-02-06  9:38   ` Jochen Sprickerhof
2019-02-06 10:17     ` Roger Quadros
2019-02-08 12:36       ` Marek Szyprowski [this message]
2019-02-08 12:52         ` Felipe Balbi
2019-02-08 19:35         ` Jochen Sprickerhof
2019-03-11 11:11           ` Marek Szyprowski
2019-03-20 18:12             ` Jochen Sprickerhof

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bdbce410-7f48-17a5-b58b-3ebd65ca6913@samsung.com \
    --to=m.szyprowski@samsung.com \
    --cc=balbi@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jochen@sprickerhof.de \
    --cc=kishon@ti.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=rogerq@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®