From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3421FC433EF for ; Tue, 21 Sep 2021 17:59:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1C67361211 for ; Tue, 21 Sep 2021 17:59:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232105AbhIUSAx (ORCPT ); Tue, 21 Sep 2021 14:00:53 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:20346 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232045AbhIUSAu (ORCPT ); Tue, 21 Sep 2021 14:00:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1632247161; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zJEAcSEIgId9AwYVRC0qQ3ajHWBc7r/Wum0Va5Cj43g=; b=e3/QXpBSnbSxpapmMgpxQZrr8NkPHN3drLIbMfvpDGZbX8AxTI8O6zxmYIa6/dqkx7Vrii iDeXyjAnL5tR8/Y1X0qI9ycQSwC1Uj2UEAE2ICRqtvdnfJ1cELI4VQXVpxS32agHjxPDD2 0vQFm2aCS58msQk2TRjvd/fdJgbCj3I= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-39-Byq_dsI0MWShpcfAVqzwKQ-1; Tue, 21 Sep 2021 13:59:19 -0400 X-MC-Unique: Byq_dsI0MWShpcfAVqzwKQ-1 Received: by mail-wr1-f69.google.com with SMTP id r9-20020a5d4989000000b0015d0fbb8823so9490366wrq.18 for ; Tue, 21 Sep 2021 10:59:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=zJEAcSEIgId9AwYVRC0qQ3ajHWBc7r/Wum0Va5Cj43g=; b=Eoh9CirguVPElMTp/g/y9KIe9XWvCUMAFzTvtOX/Qj10Ake1yzLJDSKiHZXSdFfLFS egLMrXKcficoctkTibeo2Pb+bB33SSGXPXnPY3YCJIMuJC2+3BRiGEGDsHtB2rSta4ki jwIpQGByvoSrDF38Q6/IRqyjHsMvHPj/Xxf5k+VaFRDXnQRRlKfGf9eHJD/zaZz9vmeA j1mL4XyN0RkvcartLJFMlZHjJ8NQMqrsUW8fbKkcnXh9XWS11C8ua/PFE1hCV0otNid4 aa4vlXYX/z5BahYr0n5yZgG/ZOoX86/NIutw2jVbPJH2iv1PHpkKqERYorgWJQo6ahGn murQ== X-Gm-Message-State: AOAM532FdnscOmixrL4v+dUWErVJ2aF5QUYUjSTHyPwmQ6ZZJVCvxphJ AsiovDcN5Qdm16/WW1OWADm1vjSZbiZWzbiHt2hUZsC9vqOTCI0i/3lbuyULSxWupdLeViaqPoy lrICc1P4m0kenvVQr+lAi8xWa X-Received: by 2002:a7b:c112:: with SMTP id w18mr6169889wmi.86.1632247158799; Tue, 21 Sep 2021 10:59:18 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzE58/MDukCj9/T6TCsmIk/mI3Qr4J4pYFiogRVuZatAFTjuNxHA7WL3p8No1sKEner6nUpvw== X-Received: by 2002:a7b:c112:: with SMTP id w18mr6169872wmi.86.1632247158573; Tue, 21 Sep 2021 10:59:18 -0700 (PDT) Received: from ?IPv6:2001:b07:6468:f312:c8dd:75d4:99ab:290a? ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.gmail.com with ESMTPSA id f19sm3626219wmf.11.2021.09.21.10.59.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 21 Sep 2021 10:59:17 -0700 (PDT) Subject: Re: [PATCH 1/2] KVM: SEV: Pin guest memory for write for RECEIVE_UPDATE_DATA To: Sean Christopherson Cc: Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Peter Gonda , Marc Orr , Tom Lendacky , Brijesh Singh , Masahiro Kozuka References: <20210914210951.2994260-1-seanjc@google.com> <20210914210951.2994260-2-seanjc@google.com> From: Paolo Bonzini Message-ID: Date: Tue, 21 Sep 2021 19:59:16 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210914210951.2994260-2-seanjc@google.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 14/09/21 23:09, Sean Christopherson wrote: > Require the target guest page to be writable when pinning memory for > RECEIVE_UPDATE_DATA. Per the SEV API, the PSP writes to guest memory: > > The result is then encrypted with GCTX.VEK and written to the memory > pointed to by GUEST_PADDR field. > > Fixes: 15fb7de1a7f5 ("KVM: SVM: Add KVM_SEV_RECEIVE_UPDATE_DATA command") > Cc: stable@vger.kernel.org > Cc: Peter Gonda > Cc: Marc Orr > Cc: Tom Lendacky > Cc: Brijesh Singh > Signed-off-by: Sean Christopherson > --- > arch/x86/kvm/svm/sev.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/x86/kvm/svm/sev.c b/arch/x86/kvm/svm/sev.c > index 75e0b21ad07c..95228ba3cd8f 100644 > --- a/arch/x86/kvm/svm/sev.c > +++ b/arch/x86/kvm/svm/sev.c > @@ -1464,7 +1464,7 @@ static int sev_receive_update_data(struct kvm *kvm, struct kvm_sev_cmd *argp) > > /* Pin guest memory */ > guest_page = sev_pin_memory(kvm, params.guest_uaddr & PAGE_MASK, > - PAGE_SIZE, &n, 0); > + PAGE_SIZE, &n, 1); > if (IS_ERR(guest_page)) { > ret = PTR_ERR(guest_page); > goto e_free_trans; > Queued both, thanks. Paolo