From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755103AbdEIQxE (ORCPT ); Tue, 9 May 2017 12:53:04 -0400 Received: from mail-pf0-f194.google.com ([209.85.192.194]:36803 "EHLO mail-pf0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754685AbdEIQxD (ORCPT ); Tue, 9 May 2017 12:53:03 -0400 Subject: Re: [PATCH V2] ARM: dts: bcm283x: Reserve first page for firmware To: Eric Anholt , Phil Elwell , Rob Herring , Mark Rutland , Russell King , bcm-kernel-feedback-list@broadcom.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-rpi-kernel@lists.infradead.org References: <8737cenfhc.fsf@eliezer.anholt.net> From: Florian Fainelli Message-ID: Date: Tue, 9 May 2017 09:52:53 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <8737cenfhc.fsf@eliezer.anholt.net> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/09/2017 09:48 AM, Eric Anholt wrote: > Phil Elwell writes: > >> The Raspberry Pi startup stub files for multi-core BCM27XX processors >> make the secondary CPUs spin until the corresponding mailbox is >> written. These stubs are loaded at physical address 0x00000xxx (as seen >> by the ARMs), but this page will be reused by the kernel unless it is >> explicitly reserved, causing the waiting cores to execute random code. >> >> Use the /memreserve/ Device Tree directive to mark the first page as >> off-limits to the kernel. >> >> See: https://github.com/raspberrypi/linux/issues/1989 >> >> Signed-off-by: Phil Elwell > > This looks great. We're currently in the merge window, so I can't > generate a new bcm2835-dt-next yet, but I'll pick this patch up when I > do. > > Thanks for submitting upstream! Considering that this is a fix, we could actually squeeze it in the devicetree/fixes branch and we could submit those as soon as v4.12-rc1 is tagged, your call. -- Florian