From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 16076381EB8 for ; Thu, 13 Aug 2026 04:57:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786597038; cv=none; b=lqfob+BTNaVsJciME2lM0ZHrqbVy7FVSDFYqz4NPeuk98FgHdwS7zlSA4T6CU398esM/tpvbvmPP0lw3zqyEzRm+9jw9U/jIfBePrA209mnNgRod3TP4oiz2AS0K/0L7yV1UVglDTtCgEIgcCKH0dXDgSg64LeCIkPEoI4v8hcY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786597038; c=relaxed/simple; bh=9+ULFWVEbitvZ6X+/yUPHpOAJDJ7U8TgkFMrJeNMk/g=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=NUUrrbv0T2rWKrJJcGdPcP0MuVuA7LwDdjGAofL42kJZweQzZRxWhjHcriSaEKm8c4ubyZrSSGaKEknGroBIAbrlSRjti7h/c/DiEIVfAevP5q08QPY5+/FAfEDfBMmyotNkNG97GN5i1G9NPp7tdouJr6eIE+PWYbJmzA1nv88= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=AUyV3Mf3; arc=none smtp.client-ip=209.85.214.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="AUyV3Mf3" Received: by mail-pl1-f182.google.com with SMTP id d9443c01a7336-2cacf197759so32718475ad.2 for ; Wed, 12 Aug 2026 21:57:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786597036; x=1787201836; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:sender:from:to:cc :subject:date:message-id:reply-to:content-type; bh=WBtU8YVaq1yMUZRCZWu+8sP/s98ztgfVffYxabqxGEE=; b=AUyV3Mf3GPCSO7ud3xXo0H9+iBdkCQ9nuJqP+FUctCHjDf/poEOgsfRsJpT7U8v4EM smKOhkeRs3IZbGSpo/4OSr0ntL+u5N0hwL221wehyCRbcqwzD7kT6CHu4nWXuJcRZrzQ AWXEdCNHBpzQlXXkZJF39UqulQLoHnMtVowtB84tWB+I8uQjaKAgGVms0AX/ey41oRie F1l55WaDkjVJOxB1SM9y9v1nJ/O0ertuLTD4lHwjpPKZ4w5snpVBFilTau1+sW5kwAQp R0KXY7TLzkZxdSaz1BQ/Y/HXwl8r0tOXXFwkdPohMDW9ALkCONDBrlTaa432BdQy1SRT K4LA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786597036; x=1787201836; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:sender:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=WBtU8YVaq1yMUZRCZWu+8sP/s98ztgfVffYxabqxGEE=; b=IhwUNZdSymRCFw1zCh/zVLxcyrzJrXjuaHAitpjQY+/1zwz1fK6itJBMT869FJ3Vfn alGnGWeZjSf0jQLwuqkajX9TMxlx3mTR9Gvig2XiDVFEhBuyYi14uW/TraBpuPqNtdIb 282E+tWs26niTQfSoHAg0kk80G+kfTB1DA6TU2G8bfRPVfwNN0WN76gky/gtahIatgSI 8RnXhRu5I3guz1QDFdEvIaz4hbGP4aesktuznaPo212AME+YIRM9fZ8rVvtkawvzt/gf aY8brib8BKw+zny1tuoA6CZcPoy7RKDA3uoWzbYjahwMSSA7QeYm0SECUjaa6s2ZcPRl mRBQ== X-Forwarded-Encrypted: i=1; AHgh+RoEf8/gLfyyC0RxKfDsbqk2O3a8Mpw6tcd2UR3ONOd29pz3VKhNvGXn73ctLazavOUP+23Cj2Mg4gGzstk=@vger.kernel.org X-Gm-Message-State: AOJu0YxmA1diGNRi+nq2HDv9o7fT2K/ZxQUitF9uUjLKZUsyWHSKBeO3 Q+fK6jMBDIB2JKAvbpXpGdsawbwLVlwQmVdL4kXpMwpaa3r52OAguV4E X-Gm-Gg: AR+sD100E9xfcUYV6ghzkiC+YJumeKrTh+k80/rgbXRMXnE8UXA8NjAxPWJBXJli3US JJ+S/uxhVU5W70DhSIvbP1QxqpszeDoItjyWek/U5I9kfMDHzQ3VO7M0zdkN0D+kI/BEldJxQAR atnBq8CeszeDO/AsxDPEoDsa3/oTPFWSiV0jvKdq7Mub3IK5k8C5egqj/lSfV3VdUcRdwMKdZLx M1+ND59V8XqQjQC0YrVW7TYrQ2sncH7umekHE7zwmoLWFxcWWewArvJDc+hQFYCKOJWW5apuhmq P3B78lBf/Of9sylP9D7COX79gmJ40UkhHlYdEDBgbPByqUhlqOzw8J0ntrnIiIu4qOeYQl2sSug SDNdt1RkXQWY3Xj7T1Kh0BklrcJFUM1ndrt71w3u5r7Zg61Z/IpTvVYvYZ7zZaHlN1FjSF+1uEZ 7wSPmRI0zPYRmuI64hMs3+prA/84AdDMSR80evovd4WExmu17PQXb++1Afpeg6zB9lseRI5LaQs g== X-Received: by 2002:a17:903:38c3:b0:2ce:93a3:c168 with SMTP id d9443c01a7336-2d37d58376amr36875355ad.7.1786597036243; Wed, 12 Aug 2026 21:57:16 -0700 (PDT) Received: from server.roeck-us.net ([2600:1700:e321:62f0:da43:aeff:fecc:bfd5]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2d37c200408sm3960635ad.12.2026.08.12.21.57.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Aug 2026 21:57:15 -0700 (PDT) Sender: Guenter Roeck Date: Wed, 12 Aug 2026 21:57:14 -0700 From: Guenter Roeck To: Arie Miller Cc: Aleksa Savic , Will Smith , Jonathan Corbet , Shuah Khan , linux-hwmon@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 1/3] hwmon: (asus_rog_ryujin) Add per-device configuration Message-ID: References: <20260812103532.395049-1-renari@arimil.com> <20260812103532.395049-2-renari@arimil.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260812103532.395049-2-renari@arimil.com> On Wed, Aug 12, 2026 at 06:35:30AM -0400, Arie Miller wrote: > Move model-specific report offsets and capabilities into a device > information structure. This prepares the driver for coolers which use > a different report layout or do not include the external fan > controller, while preserving the existing Ryujin II 360 behavior. > > Handles an issue reported by Sashiko where an id could > be missing driver_data. This is introduced by this patch and thus irrelevant for the commit message. > > Link: https://lore.kernel.org/r/5a817284-a9f4-48b2-9f0f-802c5dc6963c@roeck-us.net > Assisted-by: Codex:gpt-5.6-sol sparse > Signed-off-by: Arie Miller We are too close for me to accept this series without independent Tested-by: and/or Reviewed-by: feedback. I plan to apply it after the next commit window closes. I won't mandate that the issues reported by Sashiko are getting fixed, but I wuold strongly suggest for the users of this driver to have a look and consider fixing them. The issues look very real to me. Thanks, Guenter