From: Krzysztof Kozlowski <krzk@kernel.org>
To: Reza Kurniawan <imkyufie@gmail.com>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/3] arm64: dts: qcom: Add UART support for Xiaomi Redmi 5A (riva)
Date: Tue, 18 Aug 2026 11:38:11 +0200 [thread overview]
Message-ID: <bdc31f68-a809-48eb-8dfd-64c94ad7ff53@kernel.org> (raw)
In-Reply-To: <20260818093548.27803-3-imkyufie@gmail.com>
On 18/08/2026 11:35, Reza Kurniawan wrote:
> Signed-off-by: Reza Kurniawan <imkyufie@gmail.com>
Please run scripts/checkpatch.pl on the patches and fix reported
warnings. After that, run also 'scripts/checkpatch.pl --strict' on the
patches and (probably) fix more warnings. Some warnings can be ignored,
especially from --strict run, but the code here looks like it needs a
fix. Feel free to get in touch if the warning is not clear.
Commit msg is where you explain why you are doing, what you want to
achieve, what is the point of this work etc.
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-08-18 9:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-18 9:35 [PATCH v3 0/3] arm64: dts: qcom: Refine device support for Xiaomi Redmi 5A Reza Kurniawan
2026-08-18 9:35 ` [PATCH v3 1/3] arm64: dts: qcom: Add UART support for Xiaomi Redmi 5A (riva) Reza Kurniawan
2026-08-18 9:38 ` Krzysztof Kozlowski [this message]
2026-08-18 9:35 ` [PATCH v3 2/3] arm64: dts: qcom: Add haptic vibrator " Reza Kurniawan
2026-08-18 9:35 ` [PATCH v3 3/3] arm64: dts: qcom: Add notification LED " Reza Kurniawan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bdc31f68-a809-48eb-8dfd-64c94ad7ff53@kernel.org \
--to=krzk@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=imkyufie@gmail.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®