Re: [PATCH v2 4/6] arm64: dts: axiado: Add initial support for AX3000 SoC and eval board

[Harshit Shah <hshah@axiado.com>]

On 6/19/2025 11:08 PM, Krzysztof Kozlowski wrote:
>>>> +
>>>> +             spi_clk: spi_clk {
>>>> +                     compatible = "fixed-clock";
>>>> +                     #clock-cells = <0>;
>>>> +                     clock-frequency = <25000000>;
>>>> +             };
>>>> +
>>>> +             apb_pclk: apb_pclk {
>>> No underscores in node names, but all these look incorrect - don't you
>>> have clock controller?
>> Noted, we will remove the "_" from the nodes. We do have clock
>> controller however that is being accessed by other CPU before Linux will
>> come-up.
> What does it mean? Is the clock controller not available at all for
> Linux or any other OS?

Apologies for the confusion. Yes, clock controller is available however 
it is only accessible by another CPU which boots up before Linux comes up.

This another CPU is setting up the various output clocks (& PLLs) before 
the Linux comes up.

So, that's the reason haven not added the clock controller in this DTS 
but only will add fixed clocks.

>
>> So, the purpose of this clock nodes is to calculate the frequencies for
>> other peripherals. (We will update the nodes with clock-<freq>)
> You do not calculate any frequencies here... You created nodes for fixed
> clocks but I question here whether these are fixed clocks.
>
> Where are these clocks located exactly?

Yes, those clocks are fixed clocks, as it is being controlled by other 
CPU and coming to A53 as fixed clocks.

I will take care of the format in the next revision.

>
>
> Best regards,
> Krzysztof