From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 659586AB8 for ; Sat, 2 Nov 2024 00:25:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730507124; cv=none; b=HAMtxthvUuQuD44qGTtn39kLlJUVTD+z5EcB3NVFtv4yRj/hoNeP5ku7rbPG4h/Xu2hLdOq8dHB4HIhF/AJXNRSG6JwQm2y/FXpLf81P+wu1NHKDlMV3dgoLYlsLeFDXsBNCTQJU8mu24CLGTWYMpZXtEzKMO2A+Whrwf66OM4g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730507124; c=relaxed/simple; bh=PoBluuWksqSKIY8x+1s63UbYr0Aia1sRZxqjFKv/dW8=; h=Message-ID:Date:MIME-Version:Cc:Subject:To:References:From: In-Reply-To:Content-Type; b=cQjtFInXJUJ5+LeH8llnHEBVS+/Sv5/xzTtfjamKC1+xlIuyPIQkUSD+wi3an9P6D+Ugk14l72ci30TMXdJ1wP1pjKgYAJ+HNppwXslIWuJvdGsilWtw4x0z4eCu/MjIoi4pi9RKOCVTApu+z1uBJaOeqwgz5VwOnSFHi9Q7anU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=USHVKQuC; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="USHVKQuC" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A6DB2C4CECD; Sat, 2 Nov 2024 00:25:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1730507123; bh=PoBluuWksqSKIY8x+1s63UbYr0Aia1sRZxqjFKv/dW8=; h=Date:Cc:Subject:To:References:From:In-Reply-To:From; b=USHVKQuC7sGpL0OYwqRt1DfspdDNcqIPA6QozwMZMHvEbwmWXqulvRBDW4pwFgf6e h1xsVceuGJEmH1KPy4oVsUjd8Ra5mh5CZUN0nVs51KDer0yL7yr/zC5RJ9hAiMIpe3 Zgh9HOsdeqtaLKKLB2U2/7ORacZDjJqJoh6A+C3xtTxPU741CXBfuM4ufq62qxL5Zv /tiokc5FPBKx1DGGOScxr+cmtxyKwDWQCXvqafeFMQ0rrZVK2G0Tp6j90ro6i7H9rP xa6BgasKX8tut8jQD9NCAFPE1KJg294bvZJGnwnfEWl4xpssAR9QYNyNyVTKVdt+JP 7i0d763sRbJMQ== Message-ID: Date: Sat, 2 Nov 2024 08:25:23 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Cc: Chao Yu , linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, kernel test robot , Cyril Hrubis Subject: Re: [PATCH] f2fs: fix to map blocks correctly for direct read To: Jaegeuk Kim References: <20241031102200.440407-1-chao@kernel.org> Content-Language: en-US From: Chao Yu Autocrypt: addr=chao@kernel.org; keydata= xsFNBFYs6bUBEADJuxYGZRMvAEySns+DKVtVQRKDYcHlmj+s9is35mtlhrLyjm35FWJY099R 6DL9bp8tAzLJOMBn9RuTsu7hbRDErCCTiyXWAsFsPkpt5jgTOy90OQVyTon1i/fDz4sgGOrL 1tUfcx4m5i5EICpdSuXm0dLsC5lFB2KffLNw/ZfRuS+nNlzUm9lomLXxOgAsOpuEVps7RdYy UEC81IYCAnweojFbbK8U6u4Xuu5DNlFqRFe/MBkpOwz4Nb+caCx4GICBjybG1qLl2vcGFNkh eV2i8XEdUS8CJP2rnp0D8DM0+Js+QmAi/kNHP8jzr7CdG5tje1WIVGH6ec8g8oo7kIuFFadO kwy6FSG1kRzkt4Ui2d0z3MF5SYgA1EWQfSqhCPzrTl4rJuZ72ZVirVxQi49Ei2BI+PQhraJ+ pVXd8SnIKpn8L2A/kFMCklYUaLT8kl6Bm+HhKP9xYMtDhgZatqOiyVV6HFewfb58HyUjxpza 1C35+tplQ9klsejuJA4Fw9y4lhdiFk8y2MppskaqKg950oHiqbJcDMEOfdo3NY6/tXHFaeN1 etzLc1N3Y0pG8qS/mehcIXa3Qs2fcurIuLBa+mFiFWrdfgUkvicSYqOimsrE/Ezw9hYhAHq4 KoW4LQoKyLbrdOBJFW0bn5FWBI4Jir1kIFHNgg3POH8EZZDWbQARAQABzRlDaGFvIFl1IDxj aGFvQGtlcm5lbC5vcmc+wsF3BBMBCgAhBQJWLOm1AhsDBQsJCAcDBRUKCQgLBRYCAwEAAh4B AheAAAoJEKTPgB1/p52Gm2MP/0zawCU6QN7TZuJ8R1yfdhYr0cholc8ZuPoGim69udQ3otet wkTNARnpuK5FG5la0BxFKPlazdgAU1pt+dTzCTS6a3/+0bXYQ5DwOeBPRWeFFklm5Frmk8sy wSTxxEty0UBMjzElczkJflmCiDfQunBpWGy9szn/LZ6jjIVK/BiR7CgwXTdlvKcCEkUlI7MD vTj/4tQ3y4Vdx+p7P53xlacTzZkP+b6D2VsjK+PsnsPpKwaiPzVFMUwjt1MYtOupK4bbDRB4 NIFSNu2HSA0cjsu8zUiiAvhd/6gajlZmV/GLJKQZp0MjHOvFS5Eb1DaRvoCf27L+BXBMH4Jq 2XIyBMm+xqDJd7BRysnImal5NnQlKnDeO4PrpFq4JM0P33EgnSOrJuAb8vm5ORS9xgRlshXh 2C0MeyQFxL6l+zolEFe2Nt2vrTFgjYLsm2vPL+oIPlE3j7ToRlmm7DcAqsa9oYMlVTTnPRL9 afNyrsocG0fvOYFCGvjfog/V56WFXvy9uH8mH5aNOg5xHB0//oG9vUyY0Rv/PrtW897ySEPh 3jFP/EDI0kKjFW3P6CfYG/X1eaw6NDfgpzjkCf2/bYm/SZLV8dL2vuLBVV+hrT1yM1FcZotP WwLEzdgdQffuQwJHovz72oH8HVHD2yvJf2hr6lH58VK4/zB/iVN4vzveOdzlzsFNBFYs6bUB EADZTCTgMHkb6bz4bt6kkvj7+LbftBt5boKACy2mdrFFMocT5zM6YuJ7Ntjazk5z3F3IzfYu 94a41kLY1H/G0Y112wggrxem6uAtUiekR9KnphsWI9lRI4a2VbbWUNRhCQA8ag7Xwe5cDIV5 qb7r7M+TaKaESRx/Y91bm0pL/MKfs/BMkYsr3wA1OX0JuEpV2YHDW8m2nFEGP6CxNma7vzw+ JRxNuyJcNi+VrLOXnLR6hZXjShrmU88XIU2yVXVbxtKWq8vlOSRuXkLh9NQOZn7mrR+Fb1EY DY1ydoR/7FKzRNt6ejI8opHN5KKFUD913kuT90wySWM7Qx9icc1rmjuUDz3VO+rl2sdd0/1h Q2VoXbPFxi6c9rLiDf8t7aHbYccst/7ouiHR/vXQty6vSUV9iEbzm+SDpHzdA8h3iPJs6rAb 0NpGhy3XKY7HOSNIeHvIbDHTUZrewD2A6ARw1VYg1vhJbqUE4qKoUL1wLmxHrk+zHUEyLHUq aDpDMZArdNKpT6Nh9ySUFzlWkHUsj7uUNxU3A6GTum2aU3Gh0CD1p8+FYlG1dGhO5boTIUsR 6ho73ZNk1bwUj/wOcqWu+ZdnQa3zbfvMI9o/kFlOu8iTGlD8sNjJK+Y/fPK3znFqoqqKmSFZ aiRALjAZH6ufspvYAJEJE9eZSX7Rtdyt30MMHQARAQABwsFfBBgBCgAJBQJWLOm1AhsMAAoJ EKTPgB1/p52GPpoP/2LOn/5KSkGHGmdjzRoQHBTdm2YV1YwgADg52/mU68Wo6viStZqcVEnX 3ALsWeETod3qeBCJ/TR2C6hnsqsALkXMFFJTX8aRi/E4WgBqNvNgAkWGsg5XKB3JUoJmQLqe CGVCT1OSQA/gTEfB8tTZAGFwlw1D3W988CiGnnRb2EEqU4pEuBoQir0sixJzFWybf0jjEi7P pODxw/NCyIf9GNRNYByUTVKnC7C51a3b1gNs10aTUmRfQuu+iM5yST5qMp4ls/yYl5ybr7N1 zSq9iuL13I35csBOn13U5NE67zEb/pCFspZ6ByU4zxChSOTdIJSm4/DEKlqQZhh3FnVHh2Ld eG/Wbc1KVLZYX1NNbXTz7gBlVYe8aGpPNffsEsfNCGsFDGth0tC32zLT+5/r43awmxSJfx2P 5aGkpdszvvyZ4hvcDfZ7U5CBItP/tWXYV0DDl8rCFmhZZw570vlx8AnTiC1v1FzrNfvtuxm3 92Qh98hAj3cMFKtEVbLKJvrc2AO+mQlS7zl1qWblEhpZnXi05S1AoT0gDW2lwe54VfT3ySon 8Klpbp5W4eEoY21tLwuNzgUMxmycfM4GaJWNCncKuMT4qGVQO9SPFs0vgUrdBUC5Pn5ZJ46X mZA0DUz0S8BJtYGI0DUC/jAKhIgy1vAx39y7sAshwu2VILa71tXJ In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2024/11/2 5:06, Jaegeuk Kim wrote: > On 11/01, Chao Yu wrote: >> On 2024/11/1 9:22, Jaegeuk Kim wrote: >>> On 10/31, Chao Yu wrote: >>>> f2fs_map_blocks() supports to map continuous holes or preallocated >>>> address, we should avoid setting F2FS_MAP_MAPPED for these cases >>>> only, otherwise, it may fail f2fs_iomap_begin(), and make direct >>>> write fallbacking to use buffered IO and flush, result in performance >>>> regression. >>> >>> Is this fixing direct write or read? >> >> Direct write. > > I was confising the patch subject is saying direct read. Oops, sorry. > >> >>> >>>> >>>> Fixes: 9f0f6bf42714 ("f2fs: support to map continuous holes or preallocated address") >>>> Reported-by: kernel test robot >>>> Closes: https://lore.kernel.org/oe-lkp/202409122103.e45aa13b-oliver.sang@intel.com >>>> Cc: Cyril Hrubis >>>> Signed-off-by: Chao Yu >>>> --- >>>> fs/f2fs/data.c | 7 ++++++- >>>> 1 file changed, 6 insertions(+), 1 deletion(-) >>>> >>>> diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c >>>> index 306b86b0595d..38b85160c6bd 100644 >>>> --- a/fs/f2fs/data.c >>>> +++ b/fs/f2fs/data.c >>>> @@ -1676,7 +1676,12 @@ int f2fs_map_blocks(struct inode *inode, struct f2fs_map_blocks *map, int flag) >>>> /* reserved delalloc block should be mapped for fiemap. */ >>>> if (blkaddr == NEW_ADDR) >>>> map->m_flags |= F2FS_MAP_DELALLOC; >>>> - if (flag != F2FS_GET_BLOCK_DIO || !is_hole) >>>> + /* >>>> + * f2fs_map_blocks() supports to map continuous holes or >>>> + * preallocated address, don't set F2FS_MAP_MAPPED for these >>>> + * cases only. >>>> + */ >>>> + if (flag != F2FS_GET_BLOCK_DIO || map->m_may_create || !is_hole) >>> >>> So, this is adding map->m_may_create, which is for writes? >> >> map->m_may_create is added for write path, w/o this condition, f2fs_map_blocks() >> may missed to tag F2FS_MAP_MAPPED, result in that f2fs_iomap_begin() will return >> -ENOTBLK. > > Is that something like this? > > /* DIO READ and hole case, should not map the blocks. */ > if (!(flag == F2FS_GET_BLOCK_DIO && is_hole && !map->m_may_create)) More clear, will update w/ this. Thanks, > >> >> Am I missing someting? >> >> Thanks, >> >>> >>>> map->m_flags |= F2FS_MAP_MAPPED; >>>> map->m_pblk = blkaddr; >>>> -- >>>> 2.40.1